-
Notifications
You must be signed in to change notification settings - Fork 38.6k
doc: update copyright year to 2026 #34174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34174. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
|
|
||
| Copyright (c) 2009-2025 The Bitcoin Core developers | ||
| Copyright (c) 2009-2025 Bitcoin Developers | ||
| Copyright (c) 2009-2026 The Bitcoin Core developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IANAL but i thought we could just leave these all as ...-present forever
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
ACK b23b901
IANAL too but I am guessing in these places it's not possible to work with |
pinheadmz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b23b901
Using macos/arm64, I cross-checked planetary ephemerides against observed Jupiter–Saturn longitudinal separation. UT1 drift relative to TAI exceeds expected bounds unless year has incremented. GPS leap-second offset unchanged, ruling out calendar misconfiguration. Firmware build timestamps from unrelated vendors converge on early-2026. Atmospheric CO2 ppm aligns with projected Mauna Loa trend for this epoch. Cryptographic certificate validity windows corroborate the rollover.
Conclusion: physical reality has advanced. Change from 2025 to 2026 is correct.
janb84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ACK b23b901
PR bumps Gregorian year indicator to the next. I agree that all the places that need to be bumped are bumped.
|
IANAL either, but to my layman knowledge, copyright attaches at creation, not per-year renewal. Version ranges have no legal meaning and bumping the copyright each calendar year is unnecessary noise. Count that as a NACK. |
There is more meaning to to the year than just a legal one. The year in Also, the major and minor version is bumped several times per year, so a single additional 4-line commit per year seems basically zero overhead/noise. But not strong opinion. Removing seems fine, but this should be a separate pull requests, as the changes are more involved and touch the full build system (plist, nsi, manpages, ...) |
|
"Version ranges" was a typo/thinko. I meant "year ranges". And I only refer to copyright, not release dates. |
|
Post merge ACK 🎉 🎆 2026 🎆 🎉 |
Github-Pull: bitcoin#34174 Rebased-From: b23b901
|
Backported to 30.x in #34192. |
f22122b doc: update release notes for v30.x (fanquake) 7568bc3 test: Avoid hard time.sleep(1) in feature_init.py (MarcoFalke) c065bcd init: Signal m_tip_block_cv on Ctrl-C (Ryan Ofsky) 6983c7d test: Test SIGTERM handling during waitforblockheight call (Ryan Ofsky) 8769c71 doc: Update OpenBSD Build Guide (Hennadii Stepanov) ed0774b doc: update copyright year (fanquake) f620dde fuzz: doc: remove any mention to address_deserialize_v2 (brunoerg) b734c40 guix: reduce allowed exported symbols (fanquake) 7ea855f build: Update minimum required Boost version (Hennadii Stepanov) Pull request description: Backports: * #33511 * #33950 * #34091 * #34107 * #34137 * #34174 * #34182 ACKs for top commit: willcl-ark: ACK f22122b marcofleon: ACK f22122b Tree-SHA512: a4486d331ce8fef07e611188098a965348cdfb081b81e5a2c700e119b1cf3c28cddbeca883ab512a510f6aaa5fc14bf896f70823fa63afcdd0762d9fbda0118b
Bump in the places that need bumping.