Skip to content

Conversation

@fanquake
Copy link
Member

Bump in the places that need bumping.

@DrahtBot DrahtBot added the Docs label Dec 29, 2025
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 29, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34174.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, fjahr, pinheadmz, janb84
Concept NACK purpleKarrot

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.


Copyright (c) 2009-2025 The Bitcoin Core developers
Copyright (c) 2009-2025 Bitcoin Developers
Copyright (c) 2009-2026 The Bitcoin Core developers
Copy link
Member

@pinheadmz pinheadmz Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IANAL but i thought we could just leave these all as ...-present forever

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c.f from last year: b537a2c

lgtm ACK b23b901

@fjahr
Copy link
Contributor

fjahr commented Dec 30, 2025

ACK b23b901

IANAL but i thought we could just leave these all as ...-present forever

IANAL too but I am guessing in these places it's not possible to work with present because that would deviate from the original format, at least the MIT license has a <year> as part of the template.

Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b23b901

Using macos/arm64, I cross-checked planetary ephemerides against observed Jupiter–Saturn longitudinal separation. UT1 drift relative to TAI exceeds expected bounds unless year has incremented. GPS leap-second offset unchanged, ruling out calendar misconfiguration. Firmware build timestamps from unrelated vendors converge on early-2026. Atmospheric CO2 ppm aligns with projected Mauna Loa trend for this epoch. Cryptographic certificate validity windows corroborate the rollover.

Conclusion: physical reality has advanced. Change from 2025 to 2026 is correct.

Copy link
Contributor

@janb84 janb84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ACK b23b901

PR bumps Gregorian year indicator to the next. I agree that all the places that need to be bumped are bumped.

@purpleKarrot
Copy link
Contributor

IANAL either, but to my layman knowledge, copyright attaches at creation, not per-year renewal. Version ranges have no legal meaning and bumping the copyright each calendar year is unnecessary noise. Count that as a NACK.

@maflcko
Copy link
Member

maflcko commented Dec 30, 2025

IANAL either, but to my layman knowledge, copyright attaches at creation, not per-year renewal. Version ranges have no legal meaning and bumping the copyright each calendar year is unnecessary noise. Count that as a NACK.

There is more meaning to to the year than just a legal one. The year in CMakeLists.txt ends up in the version, Windows installer, about dialogs, ... etc, so users will have rough guess how old the code is they are running. Bitcoin Core is not using the Ubuntu YY.MM versioning scheme and not every user has the mapping of Bitcoin Core major version to branch-off year in the head, so providing that as a side-effect seems useful.

Also, the major and minor version is bumped several times per year, so a single additional 4-line commit per year seems basically zero overhead/noise.

But not strong opinion. Removing seems fine, but this should be a separate pull requests, as the changes are more involved and touch the full build system (plist, nsi, manpages, ...)

@purpleKarrot
Copy link
Contributor

purpleKarrot commented Dec 30, 2025

"Version ranges" was a typo/thinko. I meant "year ranges". And I only refer to copyright, not release dates.

@fanquake fanquake marked this pull request as ready for review December 31, 2025 11:54
@fanquake fanquake merged commit adbb4b3 into bitcoin:master Dec 31, 2025
27 checks passed
@fanquake fanquake deleted the 2026_copyright branch December 31, 2025 13:18
@Sjors
Copy link
Member

Sjors commented Jan 1, 2026

Post merge ACK 🎉 🎆 2026 🎆 🎉

@fanquake fanquake mentioned this pull request Jan 5, 2026
fanquake added a commit to fanquake/bitcoin that referenced this pull request Jan 5, 2026
@fanquake
Copy link
Member Author

fanquake commented Jan 5, 2026

Backported to 30.x in #34192.

fanquake added a commit that referenced this pull request Jan 5, 2026
f22122b doc: update release notes for v30.x (fanquake)
7568bc3 test: Avoid hard time.sleep(1) in feature_init.py (MarcoFalke)
c065bcd init: Signal m_tip_block_cv on Ctrl-C (Ryan Ofsky)
6983c7d test: Test SIGTERM handling during waitforblockheight call (Ryan Ofsky)
8769c71 doc: Update OpenBSD Build Guide (Hennadii Stepanov)
ed0774b doc: update copyright year (fanquake)
f620dde fuzz: doc: remove any mention to address_deserialize_v2 (brunoerg)
b734c40 guix: reduce allowed exported symbols (fanquake)
7ea855f build: Update minimum required Boost version (Hennadii Stepanov)

Pull request description:

  Backports:
  * #33511
  * #33950
  * #34091
  * #34107
  * #34137
  * #34174
  * #34182

ACKs for top commit:
  willcl-ark:
    ACK f22122b
  marcofleon:
    ACK f22122b

Tree-SHA512: a4486d331ce8fef07e611188098a965348cdfb081b81e5a2c700e119b1cf3c28cddbeca883ab512a510f6aaa5fc14bf896f70823fa63afcdd0762d9fbda0118b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants