Skip to content

Conversation

@Chand-ra
Copy link

Add fuzzing coverage for several missing DescriptorScriptPubKeyMan methods.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 29, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34170.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK bensig

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #32876 (refactor: use options struct for signing and PSBT operations by Sjors)
  • #32857 (wallet: allow skipping script paths by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

  • setup -> set up [“set up” is the verb form; “setup” is a noun — use “set up a new SPKM” for correct grammar]

Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):

  • [spk_manager->FillPSBT(psbt, txdata, sighash_type, sign, bip32derivs, nullptr, finalize)] in src/wallet/test/fuzz/scriptpubkeyman.cpp

2025-12-31

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed.
Task macOS native, fuzz: https://github.com/bitcoin/bitcoin/actions/runs/20572426083/job/59082228214
LLM reason (✨ experimental): Uncaught std::runtime_error "Unable to expand descriptor" in fuzz target scriptpubkeyman caused the CI failure.

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

  • Possibly due to a silent merge conflict (the changes in this pull request being
    incompatible with the current code in the target branch). If so, make sure to rebase on the latest
    commit of the target branch.

  • A sanitizer issue, which can only be found by compiling with the sanitizer and running the
    affected test.

  • An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

Add fuzzing coverage for several missing `DescriptorScriptPubKeyMan`
methods.
@bensig
Copy link
Contributor

bensig commented Jan 7, 2026

ACK 9efc796

Tests ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants