Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Dec 26, 2025

Membership tests of the form not item in stuff may be confusing, because they could be read as (not item) in stuff, which is different.

So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.

@DrahtBot DrahtBot added the Tests label Dec 26, 2025
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 26, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34154.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK rkrux, bensig, l0rinc

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #34098 (test: [move-only] Move lint functions into modules by maflcko)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@rkrux rkrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm crACK fab300b

So enable the ruff E713 lint, which should also help to avoid having to go through review cycles for this.

Thanks for enabling it globally, unrelated lint changes were indeed distracting in #33014 (comment).

@bensig
Copy link
Contributor

bensig commented Jan 3, 2026

ACK fab300b

x not in y is clearer than not x in y - good to have this enforced.

@l0rinc
Copy link
Contributor

l0rinc commented Jan 3, 2026

Recreated the change locally, ended up with the same state.

ACK fab300b

@fanquake fanquake merged commit bd4f478 into bitcoin:master Jan 4, 2026
27 checks passed
@maflcko maflcko deleted the 2512-ruff-E713 branch January 5, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants