validation: reuse should_empty check for chainstate flush
#34125
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34125. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Dec 20, 2025
l0rinc
force-pushed
the
l0rinc/reuse-should-empty
branch
from
bd0c5cf to
511582a
Compare
l0rinc
changed the title
should_empty for chainstate flush conditionshould_empty check for chainstate flush
In `Chainstate::FlushStateToDisk`, the condition for emptying the UTXO cache was duplicated: once in `should_write` and again when choosing between `CoinsTip().Flush()` and `CoinsTip().Sync()`. Compute it once as `should_empty` and reuse it in both places.
l0rinc
force-pushed
the
l0rinc/reuse-should-empty
branch
from
511582a to
66ab897
Compare
Contributor
Author
|
#33866 was just merged, this PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor follow-up to #33866
Reuse the
should_emptypredicate for both the write decision and for selectingCoinsTip().Flush()vsCoinsTip().Sync().This is a pure refactor, no behavior is changed.