refactor: inline constant f_obfuscate = false parameter
#34048
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34048. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
| { | ||
| public: | ||
| DB(const fs::path& path, size_t n_cache_size, | ||
| bool f_memory = false, bool f_wipe = false, bool f_obfuscate = false); |
There was a problem hiding this comment.
i presume this exists to allow indexes to obfuscate, if there is need to? E.g. when storing remote-user-provided data. E.g. an addrindex?
I understand this isn't needed right now, so no strong opinion.
There was a problem hiding this comment.
Yes, it's an unused argument - it's clearer to remove the fake single-instance-abstraction
|
Concept NAck, could be needed in the future, no point in hiding it |
|
if it's needed in the future, it's trivial to reintroduce it. |
It seems like a strong enough option to leave as is still but ill defer to others i dont have a strong opinion |
|
Closing for lack of interest, will keep it in the original PR only |
4 participants
Split out of #33324 since it makes sense on its own.
Currently the parameter is only called with a single constant parameter, it doesn't make sense to needlessly obfuscate the constructor (pun intended).