docs: sync external-signer.md with current external signer flow #33947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33947. ReviewsSee the guideline for information on the review process. |
Member
|
Thanks, however there is an existing PR at #33765. I'd suggest reviewing there first. |
Author
Oh, actually didn't notice that PR |
|
I tried to include some of your improvements in #33765. Feel free to comment or collaborate. |
cobratbq
added a commit
to cobratbq/bitcoin
that referenced
this pull request
Dec 10, 2025
…ntx, contains updates from bitcoin#33947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated external-signer.md to match the current implementation. The signer network selection is passed as --chain rather than --testnet, and transaction signing is performed via stdin using the signtx command with JSON output containing a psbt field or error. Wallet creation for external signers requires external_signer=true with private keys disabled, so the example now uses named arguments. Spending with an external signer goes through the new send/sendall RPCs which build a PSBT, call the signer, and finalize when signatures are sufficient; sendtoaddress is not applicable for such wallets and also returns a plain txid for pk-enabled wallets rather than a complete field. The getdescriptors call is documented with the --account parameter and return shape including receive and internal arrays. Examples for displayaddress and createwallet are corrected, enumeratesigners now shows an optional name field, and references to bitcoin-qt replace the non-existent “bitcoin node” and “bitcoin rpc”.