guix: build bitcoin-qt with static libxcb & utils
#33537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33537. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
This was referenced Oct 4, 2025
Member
Author
Member
Sure. But #29923 also reduces build dependencies. Isn’t that one of the goals of build system design? |
Member
Author
I'm not sure it reduces them; they are just moved into a different repository? That repository will need ongoing maintenance, the deps (headers) copied into there, as well as a fake libc, still need updating (I'm assuming syncronised with the Qt we are shipping in this repo, so changes needed there could also block changes here), as well as maintaining the new tooling that actually generates the wrappers. It also looks like the scope / number of dependencies would also increase over time laanwj/qtsowrap#7 ? |
Contributor
|
@fanquake, what is the motivation for a statically built bitcoin-qt? Is the performance or the package size a concern? |
Member
Author
We currently provide a single binary that can be run on (most) Linux machines (along with anything in https://github.com/bitcoin-core/packaging); however I'd like to remove runtime requirements further. See #33434 for a recent motivation (users shouldn't need to install additional dependencies/install other software to run our software).
Reading the CMake docs, it's not clear that AppImage gains us much? We still have to produce a binary meeting our requirements and bundle any relevant dependencies i.e from https://cmake.org/cmake/help/git-master/cpack_gen/appimage.html:
So it seems that even if we were going to use AppImage, we'd still want to simplify our binaries as much as possible. |
fanquake
force-pushed
the
static_all_libxcb
branch
from
0e40495 to
fe7cddf
Compare
fanquake
changed the title
bitcoin-qt
Member
|
i think making libxcb static is fine, as (as far as i know) no Linux distributions that make breaking interface changes to these. Nor does xcb have global hardcoded configuration such as paths, like the font libraries. |
fanquake
changed the title
bitcoin-qtbitcoin-qt with static libxcb & utils
fanquake
force-pushed
the
static_all_libxcb
branch
from
fe7cddf to
53efca0
Compare
Contributor
Just sharing this here in case it is useful: tobtoht@24cfce4 There probably is a better way to build |
Member
Author
@tobtoht Thanks. I've pushed a change into the |
fanquake
force-pushed
the
static_all_libxcb
branch
2 times, most recently
from
4993cc2 to
1b32c1d
Compare
fanquake
force-pushed
the
static_all_libxcb
branch
from
1b32c1d to
79d5f12
Compare
Member
Author
|
Fixed the linking issue with |
Member
Author
|
I think this is now reviewable / testable. I've updated our Guix symbol check to remove all |
Member
Author
|
Guix Build (x86_64): eacb251187a66b61d420c134b48b4081cac704cfaef3965bc10f61f2dedbe9b1 guix-build-79d5f120f4d1/output/aarch64-linux-gnu/SHA256SUMS.part
245e7592e13a90600f6ccff66442e98027d9f36b868942c88a117c05625e603e guix-build-79d5f120f4d1/output/aarch64-linux-gnu/bitcoin-79d5f120f4d1-aarch64-linux-gnu-debug.tar.gz
083a468e350320244bfb83b46f2015d28a31ab69845fd5f605e31742c9665e27 guix-build-79d5f120f4d1/output/aarch64-linux-gnu/bitcoin-79d5f120f4d1-aarch64-linux-gnu.tar.gz
6031b50181edffe36dc5849b05371f2701ea356d8b7cb3ef2e306acca3756d49 guix-build-79d5f120f4d1/output/arm-linux-gnueabihf/SHA256SUMS.part
40cfea6384091ac07016268a11343fb777730192f1ab1b4b893a12998e1a6c1f guix-build-79d5f120f4d1/output/arm-linux-gnueabihf/bitcoin-79d5f120f4d1-arm-linux-gnueabihf-debug.tar.gz
84a4102e8f0d4bf70d5becc7ec5c9eaa74f3ef6926d626a1d96ad8e24e17dde8 guix-build-79d5f120f4d1/output/arm-linux-gnueabihf/bitcoin-79d5f120f4d1-arm-linux-gnueabihf.tar.gz
31ccf3e9c5e16adc318335ce23e65efba965e459bb3011644dbc8fe868c79044 guix-build-79d5f120f4d1/output/arm64-apple-darwin/SHA256SUMS.part
fcf36b8ce2bd20a8e9911ff3f7265c9a7ccce1b20ac33badbb44a91a6e065a7f guix-build-79d5f120f4d1/output/arm64-apple-darwin/bitcoin-79d5f120f4d1-arm64-apple-darwin-codesigning.tar.gz
476f69e777f67aa4c790115d5d43f16fbe23a39687d895f6ed10df782a065f4b guix-build-79d5f120f4d1/output/arm64-apple-darwin/bitcoin-79d5f120f4d1-arm64-apple-darwin-unsigned.tar.gz
3cf461853de70ffab6cde8cf8541a04ff105c439214a6f3df5c4a0bcaa409690 guix-build-79d5f120f4d1/output/arm64-apple-darwin/bitcoin-79d5f120f4d1-arm64-apple-darwin-unsigned.zip
62e8d68d79b2d4e45e8bdac74260951e3eb02fc2fb8d9b254c9dc5540b41af53 guix-build-79d5f120f4d1/output/dist-archive/bitcoin-79d5f120f4d1.tar.gz
724a5d350a868d48d767e28362e982584e5e0c0a660d64ade4b172afd8ef713b guix-build-79d5f120f4d1/output/powerpc64-linux-gnu/SHA256SUMS.part
7069ea1be2d1f7062d3423bdb8c4936e717092f3f9dae2e0e52c634ffee33f31 guix-build-79d5f120f4d1/output/powerpc64-linux-gnu/bitcoin-79d5f120f4d1-powerpc64-linux-gnu-debug.tar.gz
826e59ce8d788494bc3be3a99c58e520482241d31687374c02540cac489b2bd6 guix-build-79d5f120f4d1/output/powerpc64-linux-gnu/bitcoin-79d5f120f4d1-powerpc64-linux-gnu.tar.gz
66f54e41ec3a2b074a024d72583f2e47a96f1a11261d5b447763fdad662bcf8b guix-build-79d5f120f4d1/output/riscv64-linux-gnu/SHA256SUMS.part
39491096ee0c3b858f9db2bd9099ba7c1d79b42137fcd6898f25108c592596bc guix-build-79d5f120f4d1/output/riscv64-linux-gnu/bitcoin-79d5f120f4d1-riscv64-linux-gnu-debug.tar.gz
8d7e708c4603abc1e491ba77c17b63fbdfec07b2171630d4a0dde07f50cf2d1f guix-build-79d5f120f4d1/output/riscv64-linux-gnu/bitcoin-79d5f120f4d1-riscv64-linux-gnu.tar.gz
693c2d9415d9c2eb875f38fcc42a9b531e0ee8048644aca04de362ca667e275c guix-build-79d5f120f4d1/output/x86_64-apple-darwin/SHA256SUMS.part
e7d3f7d680deeb758e1b3c78ceb4a61ef7174c7e3cebafd91e75c7789423e317 guix-build-79d5f120f4d1/output/x86_64-apple-darwin/bitcoin-79d5f120f4d1-x86_64-apple-darwin-codesigning.tar.gz
f6537ede069919a12c6eeb4927a88417a09e162da6f63a94246d7260a2fecb0f guix-build-79d5f120f4d1/output/x86_64-apple-darwin/bitcoin-79d5f120f4d1-x86_64-apple-darwin-unsigned.tar.gz
01c2774c4f1ea955cba630966b783a90f54e85db6c454f1cb796ef0acdced776 guix-build-79d5f120f4d1/output/x86_64-apple-darwin/bitcoin-79d5f120f4d1-x86_64-apple-darwin-unsigned.zip
c3c2fa563b79f215f94a6dde917e31316832d3866608da91f7d05b1044a42885 guix-build-79d5f120f4d1/output/x86_64-linux-gnu/SHA256SUMS.part
49603d719e8ac90b6e2c9aec2e336db04d0ec132d27885ad44480db35823d43f guix-build-79d5f120f4d1/output/x86_64-linux-gnu/bitcoin-79d5f120f4d1-x86_64-linux-gnu-debug.tar.gz
5c40bd9c9743a7dd4de1f28314b07882e5c65f8d52a6fbcb65a143cdb2f0fbe7 guix-build-79d5f120f4d1/output/x86_64-linux-gnu/bitcoin-79d5f120f4d1-x86_64-linux-gnu.tar.gz
ca670f8e655522125b3c65c8a17a5c85c95020b22357fe4acbfd2b7972b03de2 guix-build-79d5f120f4d1/output/x86_64-w64-mingw32/SHA256SUMS.part
464d63b3f4ec2345b9773154b59e15f2d39ee63761b38d91cbf200fd096be4b3 guix-build-79d5f120f4d1/output/x86_64-w64-mingw32/bitcoin-79d5f120f4d1-win64-codesigning.tar.gz
b8c0727f7ff72c590f4473e7d82d488254b1863ab14aebfdef2ed2af5194ed8e guix-build-79d5f120f4d1/output/x86_64-w64-mingw32/bitcoin-79d5f120f4d1-win64-debug.zip
e27145a1ab2be0f2dac3977cd26accd85b22035aec0bd3d32b624f7a0926eefa guix-build-79d5f120f4d1/output/x86_64-w64-mingw32/bitcoin-79d5f120f4d1-win64-setup-unsigned.exe
0a626eef5325a17a60baf1bbf4694d2e6b074d96d8e1e28b3b4b98a955c87d99 guix-build-79d5f120f4d1/output/x86_64-w64-mingw32/bitcoin-79d5f120f4d1-win64-unsigned.zip |
hebasto
reviewed
Nov 12, 2025
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
nit: a typo in commit 9af749f4a455d4b64080e33c707204dee5369a2d message:
"qdusviewer" --> "qdbusviewer".
hebasto
reviewed
Nov 12, 2025
| XCB::XFIXES | ||
| XCB::XKB | ||
| XCB::XCB | ||
| + X11::Xau |
Member
There was a problem hiding this comment.
I cannot find this change upstream, but it is correct. Otherwise, the xcb_syslibs test fails with the following errors:
xcb_auth.c:(.text+0x81): undefined reference to `XauGetBestAuthByAddr'
...
xcb_auth.c:(.text+0x292): undefined reference to `XauDisposeAuth'
Member
There was a problem hiding this comment.
It would be helpful if someone could report this upstream.
Member
Author
There was a problem hiding this comment.
There's a related report to libxcb here: https://gitlab.freedesktop.org/xorg/lib/libxcb/-/merge_requests/25.
hebasto
approved these changes
Nov 12, 2025
Co-authored-by: tobtoht <[email protected]>
Co-authored-by: tobtoht <[email protected]>
This is unused, and causes issues with static builds.
Co-authored-by: tobtoht <[email protected]>
fanquake
force-pushed
the
static_all_libxcb
branch
from
79d5f12 to
96963b8
Compare
Member
Author
|
Guix Build (x86_64 & aarch64): fe9e088e3481013bf59dfc500803b415bf29a28cb8721974040e1ea7d0a75770 guix-build-96963b888e5a/output/aarch64-linux-gnu/SHA256SUMS.part
7e070397b6bace67e0960c2e9838717c77117571eaff88aaad9e6c03d24a9400 guix-build-96963b888e5a/output/aarch64-linux-gnu/bitcoin-96963b888e5a-aarch64-linux-gnu-debug.tar.gz
9979dbb9896915bf99c9d23accccb5cab8f6b81de17c51d03c328763270f14f3 guix-build-96963b888e5a/output/aarch64-linux-gnu/bitcoin-96963b888e5a-aarch64-linux-gnu.tar.gz
4f4de887fff67f926e0d1226cacad217572b999341764c2730413c6415f1d601 guix-build-96963b888e5a/output/arm-linux-gnueabihf/SHA256SUMS.part
432db3daa5159ee2015b36ee1260129bfd2f58881de6cc63dee35065924d6eca guix-build-96963b888e5a/output/arm-linux-gnueabihf/bitcoin-96963b888e5a-arm-linux-gnueabihf-debug.tar.gz
fb1db1f01142da24dc855e6974dac6b2e55311d54d022ba7509ee608915b7113 guix-build-96963b888e5a/output/arm-linux-gnueabihf/bitcoin-96963b888e5a-arm-linux-gnueabihf.tar.gz
5b45f8f570d29dea0dc3f6e917e21632028f9aa703707deb78ebdfc4aff66e16 guix-build-96963b888e5a/output/arm64-apple-darwin/SHA256SUMS.part
6a86c779f4d6fba7f435b0826a50ef38acc5f7ff181d7461d273d70a326990f2 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-codesigning.tar.gz
56131bcb57cea4d288f0baf07b3b8345f1f8b4fcffc8db50643413aa5d1bef93 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-unsigned.tar.gz
39ec75da181875cb57aad13f8452e9e4761a80585e6b65126a87e7c9df22da85 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-unsigned.zip
5806fd1b6bf6847b17f3305be2109e1ba3b0cc0a634b6cf515db16656e5aa202 guix-build-96963b888e5a/output/dist-archive/bitcoin-96963b888e5a.tar.gz
39d5c1d3d02e20cef924d807689917bdde36f5f381db17a6954794b369a04c9b guix-build-96963b888e5a/output/powerpc64-linux-gnu/SHA256SUMS.part
3770fa7816800118ba5c71b604425002145a97dc83f2636af3c5533cf414640c guix-build-96963b888e5a/output/powerpc64-linux-gnu/bitcoin-96963b888e5a-powerpc64-linux-gnu-debug.tar.gz
ef3bb40df86f5e5331610ebb246a2b460c70fa39a60701043ec7937198567a91 guix-build-96963b888e5a/output/powerpc64-linux-gnu/bitcoin-96963b888e5a-powerpc64-linux-gnu.tar.gz
38bad773b63894d9b717924248e3b65756525fa6db595970755d8af0e530d2aa guix-build-96963b888e5a/output/riscv64-linux-gnu/SHA256SUMS.part
ef49796c6e48f92c109c51d6e460e485a1602d21fb2485cf813ccb8aa3e027eb guix-build-96963b888e5a/output/riscv64-linux-gnu/bitcoin-96963b888e5a-riscv64-linux-gnu-debug.tar.gz
b5f50fa977a8ab3d783bb837d50f03ed82f5614944674c6f06407283ef8e59ae guix-build-96963b888e5a/output/riscv64-linux-gnu/bitcoin-96963b888e5a-riscv64-linux-gnu.tar.gz
89fec540ce3944a95068b206d8bb81bd86412acfefa1ffd7c27cca8a91b8080a guix-build-96963b888e5a/output/x86_64-apple-darwin/SHA256SUMS.part
ef8a2b04f6c74b05c64b800a178e124b15f80440c8617fa4ba7553454456fc40 guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-codesigning.tar.gz
5cdbfd2d9920569a811f7008bc81e71bbd0af22d71ead819c7f8712ad9496cfe guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-unsigned.tar.gz
33b849e1fd05c7e3708728a365a4def1cb9f8ed439b6d3954d6bcda4706efc4e guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-unsigned.zip
d131de58fb61de60b8fd0d80a843d6d517fd1b8b75dc1c9c3226a103fd0342b7 guix-build-96963b888e5a/output/x86_64-linux-gnu/SHA256SUMS.part
8146d3d3d1e331eebae8fedc71d863813b1b94d4de1a466a37e1474c8dcc3274 guix-build-96963b888e5a/output/x86_64-linux-gnu/bitcoin-96963b888e5a-x86_64-linux-gnu-debug.tar.gz
869f26a7f806f2880fa0448d34a740d28c7e2d2c45b92ad0111cb6b01df3bbe5 guix-build-96963b888e5a/output/x86_64-linux-gnu/bitcoin-96963b888e5a-x86_64-linux-gnu.tar.gz
1115aab95017733a67f922a01b82913858163355019cca19ba4abeb89f159670 guix-build-96963b888e5a/output/x86_64-w64-mingw32/SHA256SUMS.part
00d664e161d7324523240b5716f240f4db70892b4b9a4b7ccf7f854380621055 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-codesigning.tar.gz
a96c61b1f803d5c376ac098d15c3d99475faf776d1779256bf8c4aefacea1a26 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-debug.zip
563d0b0314430eac5eefad782202626f0cc449d8dcec282fa9df1d329b1e9261 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-setup-unsigned.exe
1dacf9ecfc03290b44c1af6ad24b0a773215b5cb25a0b5d55379ba96fb070c20 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-unsigned.zip |
Contributor
|
My Guix Build Output (matching) Host architecture: fe9e088e3481013bf59dfc500803b415bf29a28cb8721974040e1ea7d0a75770 guix-build-96963b888e5a/output/aarch64-linux-gnu/SHA256SUMS.part
7e070397b6bace67e0960c2e9838717c77117571eaff88aaad9e6c03d24a9400 guix-build-96963b888e5a/output/aarch64-linux-gnu/bitcoin-96963b888e5a-aarch64-linux-gnu-debug.tar.gz
9979dbb9896915bf99c9d23accccb5cab8f6b81de17c51d03c328763270f14f3 guix-build-96963b888e5a/output/aarch64-linux-gnu/bitcoin-96963b888e5a-aarch64-linux-gnu.tar.gz
4f4de887fff67f926e0d1226cacad217572b999341764c2730413c6415f1d601 guix-build-96963b888e5a/output/arm-linux-gnueabihf/SHA256SUMS.part
432db3daa5159ee2015b36ee1260129bfd2f58881de6cc63dee35065924d6eca guix-build-96963b888e5a/output/arm-linux-gnueabihf/bitcoin-96963b888e5a-arm-linux-gnueabihf-debug.tar.gz
fb1db1f01142da24dc855e6974dac6b2e55311d54d022ba7509ee608915b7113 guix-build-96963b888e5a/output/arm-linux-gnueabihf/bitcoin-96963b888e5a-arm-linux-gnueabihf.tar.gz
5b45f8f570d29dea0dc3f6e917e21632028f9aa703707deb78ebdfc4aff66e16 guix-build-96963b888e5a/output/arm64-apple-darwin/SHA256SUMS.part
6a86c779f4d6fba7f435b0826a50ef38acc5f7ff181d7461d273d70a326990f2 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-codesigning.tar.gz
56131bcb57cea4d288f0baf07b3b8345f1f8b4fcffc8db50643413aa5d1bef93 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-unsigned.tar.gz
39ec75da181875cb57aad13f8452e9e4761a80585e6b65126a87e7c9df22da85 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-unsigned.zip
5806fd1b6bf6847b17f3305be2109e1ba3b0cc0a634b6cf515db16656e5aa202 guix-build-96963b888e5a/output/dist-archive/bitcoin-96963b888e5a.tar.gz
39d5c1d3d02e20cef924d807689917bdde36f5f381db17a6954794b369a04c9b guix-build-96963b888e5a/output/powerpc64-linux-gnu/SHA256SUMS.part
3770fa7816800118ba5c71b604425002145a97dc83f2636af3c5533cf414640c guix-build-96963b888e5a/output/powerpc64-linux-gnu/bitcoin-96963b888e5a-powerpc64-linux-gnu-debug.tar.gz
ef3bb40df86f5e5331610ebb246a2b460c70fa39a60701043ec7937198567a91 guix-build-96963b888e5a/output/powerpc64-linux-gnu/bitcoin-96963b888e5a-powerpc64-linux-gnu.tar.gz
38bad773b63894d9b717924248e3b65756525fa6db595970755d8af0e530d2aa guix-build-96963b888e5a/output/riscv64-linux-gnu/SHA256SUMS.part
ef49796c6e48f92c109c51d6e460e485a1602d21fb2485cf813ccb8aa3e027eb guix-build-96963b888e5a/output/riscv64-linux-gnu/bitcoin-96963b888e5a-riscv64-linux-gnu-debug.tar.gz
b5f50fa977a8ab3d783bb837d50f03ed82f5614944674c6f06407283ef8e59ae guix-build-96963b888e5a/output/riscv64-linux-gnu/bitcoin-96963b888e5a-riscv64-linux-gnu.tar.gz
89fec540ce3944a95068b206d8bb81bd86412acfefa1ffd7c27cca8a91b8080a guix-build-96963b888e5a/output/x86_64-apple-darwin/SHA256SUMS.part
ef8a2b04f6c74b05c64b800a178e124b15f80440c8617fa4ba7553454456fc40 guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-codesigning.tar.gz
5cdbfd2d9920569a811f7008bc81e71bbd0af22d71ead819c7f8712ad9496cfe guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-unsigned.tar.gz
33b849e1fd05c7e3708728a365a4def1cb9f8ed439b6d3954d6bcda4706efc4e guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-unsigned.zip
d131de58fb61de60b8fd0d80a843d6d517fd1b8b75dc1c9c3226a103fd0342b7 guix-build-96963b888e5a/output/x86_64-linux-gnu/SHA256SUMS.part
8146d3d3d1e331eebae8fedc71d863813b1b94d4de1a466a37e1474c8dcc3274 guix-build-96963b888e5a/output/x86_64-linux-gnu/bitcoin-96963b888e5a-x86_64-linux-gnu-debug.tar.gz
869f26a7f806f2880fa0448d34a740d28c7e2d2c45b92ad0111cb6b01df3bbe5 guix-build-96963b888e5a/output/x86_64-linux-gnu/bitcoin-96963b888e5a-x86_64-linux-gnu.tar.gz
1115aab95017733a67f922a01b82913858163355019cca19ba4abeb89f159670 guix-build-96963b888e5a/output/x86_64-w64-mingw32/SHA256SUMS.part
00d664e161d7324523240b5716f240f4db70892b4b9a4b7ccf7f854380621055 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-codesigning.tar.gz
a96c61b1f803d5c376ac098d15c3d99475faf776d1779256bf8c4aefacea1a26 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-debug.zip
563d0b0314430eac5eefad782202626f0cc449d8dcec282fa9df1d329b1e9261 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-setup-unsigned.exe
1dacf9ecfc03290b44c1af6ad24b0a773215b5cb25a0b5d55379ba96fb070c20 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-unsigned.zip |
Member
|
Updated build: |
willcl-ark
approved these changes
Nov 14, 2025
Member
willcl-ark
left a comment
willcl-ark
left a comment
There was a problem hiding this comment.
utACK 96963b8
The changes here LGTM. I didn't test the built bitcoin-qt bin at this time as I have forgotten the incantation needed to do so on NixOS/Wayland at the moment 😢
I did double check the dependencies matched what symbol check is seeing:
master
❯ ldd build/bin/bitcoin-qt
linux-vdso.so.1 (0x00007f246b76e000)
libfontconfig.so.1 => not found
libfreetype.so.6 => not found
libxkbcommon.so.0 => not found
libxkbcommon-x11.so.0 => not found
libxcb-xkb.so.1 => not found
libxcb.so.1 => not found
libxcb-icccm.so.4 => not found
libxcb-image.so.0 => not found
libxcb-keysyms.so.1 => not found
libxcb-randr.so.0 => not found
libxcb-render-util.so.0 => not found
libxcb-shm.so.0 => not found
libxcb-sync.so.1 => not found
libxcb-xfixes.so.0 => not found
libxcb-render.so.0 => not found
libxcb-shape.so.0 => not found
libm.so.6 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libm.so.6 (0x00007f2469117000)
libdl.so.2 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libdl.so.2 (0x00007f246b75d000)
libstdc++.so.6 => /nix/store/dj06r96j515npcqi9d8af1d1c60bx2vn-gcc-14.3.0-lib/lib/libstdc++.so.6 (0x00007f2468e00000)
libgcc_s.so.1 => /nix/store/dj06r96j515npcqi9d8af1d1c60bx2vn-gcc-14.3.0-lib/lib/libgcc_s.so.1 (0x00007f246b72d000)
libc.so.6 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libc.so.6 (0x00007f2468a00000)
/nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/ld-linux-x86-64.so.2 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib64/ld-linux-x86-64.so.2 (0x00007f246b770000)
#33537
❯ ldd build/bin/bitcoin-qt
linux-vdso.so.1 (0x00007ff4a1034000)
libfontconfig.so.1 => not found
libfreetype.so.6 => not found
libm.so.6 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libm.so.6 (0x00007ff49e917000)
libdl.so.2 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libdl.so.2 (0x00007ff4a1029000)
libstdc++.so.6 => /nix/store/dj06r96j515npcqi9d8af1d1c60bx2vn-gcc-14.3.0-lib/lib/libstdc++.so.6 (0x00007ff49e600000)
libgcc_s.so.1 => /nix/store/dj06r96j515npcqi9d8af1d1c60bx2vn-gcc-14.3.0-lib/lib/libgcc_s.so.1 (0x00007ff4a0ff9000)
libc.so.6 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libc.so.6 (0x00007ff49e200000)
/nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/ld-linux-x86-64.so.2 => /nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib64/ld-linux-x86-64.so.2 (0x00007ff4a1036000)
Member
Author
|
Tested a Guix build from this branch on Ubuntu 24.04 (aarch64 VM) 
|
sedited
reviewed
Nov 14, 2025
Contributor
sedited
left a comment
sedited
left a comment
There was a problem hiding this comment.
Tested the binaries on x86 ubuntu 24.04
Guix build
fe9e088e3481013bf59dfc500803b415bf29a28cb8721974040e1ea7d0a75770 guix-build-96963b888e5a/output/aarch64-linux-gnu/SHA256SUMS.part
7e070397b6bace67e0960c2e9838717c77117571eaff88aaad9e6c03d24a9400 guix-build-96963b888e5a/output/aarch64-linux-gnu/bitcoin-96963b888e5a-aarch64-linux-gnu-debug.tar.gz
9979dbb9896915bf99c9d23accccb5cab8f6b81de17c51d03c328763270f14f3 guix-build-96963b888e5a/output/aarch64-linux-gnu/bitcoin-96963b888e5a-aarch64-linux-gnu.tar.gz
4f4de887fff67f926e0d1226cacad217572b999341764c2730413c6415f1d601 guix-build-96963b888e5a/output/arm-linux-gnueabihf/SHA256SUMS.part
432db3daa5159ee2015b36ee1260129bfd2f58881de6cc63dee35065924d6eca guix-build-96963b888e5a/output/arm-linux-gnueabihf/bitcoin-96963b888e5a-arm-linux-gnueabihf-debug.tar.gz
fb1db1f01142da24dc855e6974dac6b2e55311d54d022ba7509ee608915b7113 guix-build-96963b888e5a/output/arm-linux-gnueabihf/bitcoin-96963b888e5a-arm-linux-gnueabihf.tar.gz
5b45f8f570d29dea0dc3f6e917e21632028f9aa703707deb78ebdfc4aff66e16 guix-build-96963b888e5a/output/arm64-apple-darwin/SHA256SUMS.part
6a86c779f4d6fba7f435b0826a50ef38acc5f7ff181d7461d273d70a326990f2 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-codesigning.tar.gz
56131bcb57cea4d288f0baf07b3b8345f1f8b4fcffc8db50643413aa5d1bef93 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-unsigned.tar.gz
39ec75da181875cb57aad13f8452e9e4761a80585e6b65126a87e7c9df22da85 guix-build-96963b888e5a/output/arm64-apple-darwin/bitcoin-96963b888e5a-arm64-apple-darwin-unsigned.zip
5806fd1b6bf6847b17f3305be2109e1ba3b0cc0a634b6cf515db16656e5aa202 guix-build-96963b888e5a/output/dist-archive/bitcoin-96963b888e5a.tar.gz
39d5c1d3d02e20cef924d807689917bdde36f5f381db17a6954794b369a04c9b guix-build-96963b888e5a/output/powerpc64-linux-gnu/SHA256SUMS.part
3770fa7816800118ba5c71b604425002145a97dc83f2636af3c5533cf414640c guix-build-96963b888e5a/output/powerpc64-linux-gnu/bitcoin-96963b888e5a-powerpc64-linux-gnu-debug.tar.gz
ef3bb40df86f5e5331610ebb246a2b460c70fa39a60701043ec7937198567a91 guix-build-96963b888e5a/output/powerpc64-linux-gnu/bitcoin-96963b888e5a-powerpc64-linux-gnu.tar.gz
38bad773b63894d9b717924248e3b65756525fa6db595970755d8af0e530d2aa guix-build-96963b888e5a/output/riscv64-linux-gnu/SHA256SUMS.part
ef49796c6e48f92c109c51d6e460e485a1602d21fb2485cf813ccb8aa3e027eb guix-build-96963b888e5a/output/riscv64-linux-gnu/bitcoin-96963b888e5a-riscv64-linux-gnu-debug.tar.gz
b5f50fa977a8ab3d783bb837d50f03ed82f5614944674c6f06407283ef8e59ae guix-build-96963b888e5a/output/riscv64-linux-gnu/bitcoin-96963b888e5a-riscv64-linux-gnu.tar.gz
89fec540ce3944a95068b206d8bb81bd86412acfefa1ffd7c27cca8a91b8080a guix-build-96963b888e5a/output/x86_64-apple-darwin/SHA256SUMS.part
ef8a2b04f6c74b05c64b800a178e124b15f80440c8617fa4ba7553454456fc40 guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-codesigning.tar.gz
5cdbfd2d9920569a811f7008bc81e71bbd0af22d71ead819c7f8712ad9496cfe guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-unsigned.tar.gz
33b849e1fd05c7e3708728a365a4def1cb9f8ed439b6d3954d6bcda4706efc4e guix-build-96963b888e5a/output/x86_64-apple-darwin/bitcoin-96963b888e5a-x86_64-apple-darwin-unsigned.zip
d131de58fb61de60b8fd0d80a843d6d517fd1b8b75dc1c9c3226a103fd0342b7 guix-build-96963b888e5a/output/x86_64-linux-gnu/SHA256SUMS.part
8146d3d3d1e331eebae8fedc71d863813b1b94d4de1a466a37e1474c8dcc3274 guix-build-96963b888e5a/output/x86_64-linux-gnu/bitcoin-96963b888e5a-x86_64-linux-gnu-debug.tar.gz
869f26a7f806f2880fa0448d34a740d28c7e2d2c45b92ad0111cb6b01df3bbe5 guix-build-96963b888e5a/output/x86_64-linux-gnu/bitcoin-96963b888e5a-x86_64-linux-gnu.tar.gz
1115aab95017733a67f922a01b82913858163355019cca19ba4abeb89f159670 guix-build-96963b888e5a/output/x86_64-w64-mingw32/SHA256SUMS.part
00d664e161d7324523240b5716f240f4db70892b4b9a4b7ccf7f854380621055 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-codesigning.tar.gz
a96c61b1f803d5c376ac098d15c3d99475faf776d1779256bf8c4aefacea1a26 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-debug.zip
563d0b0314430eac5eefad782202626f0cc449d8dcec282fa9df1d329b1e9261 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-setup-unsigned.exe
1dacf9ecfc03290b44c1af6ad24b0a773215b5cb25a0b5d55379ba96fb070c20 guix-build-96963b888e5a/output/x86_64-w64-mingw32/bitcoin-96963b888e5a-win64-unsigned.zip
Member
Author
|
Also tested on aarch64 with Debian 13.x. |
sedited
approved these changes
Nov 17, 2025
Contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use] |
hebasto
added a commit
that referenced
this pull request
Nov 20, 2025
f541b92 depends: expat 2.7.3 (fanquake) 2ebf435 depends: libxcb 1.17.0 (Hennadii Stepanov) ba7ac87 depends: xcb_proto 1.17.0 (Hennadii Stepanov) 42d0692 depends: libxcb-util-cursor 0.1.6 (fanquake) 25b8591 depends: libxcb 1.15 (fanquake) d129384 depends: libxcb-util-wm 0.4.2 (fanquake) 0b857ae depends: libxcb-util-renderutil 0.3.10 (fanquake) 35e5048 depends: libxcb-util-keysyms 0.4.1 (fanquake) 74b68ad depends: libxcb-util-image 0.4.1 (fanquake) 5bc0dde depends: libxcb-util 0.4.1 (fanquake) 8d07292 depends: libXau 1.0.12 (fanquake) Pull request description: Update libxcb and related package versions: libXau 1.0.9 -> 1.0.12 libxcb 1.14 -> 1.17 libxcb_util 0.4.0 -> 0.4.1 libxcb_util_cursor 0.1.5 -> 0.1.6 libxcb_util_image 0.4.0 -> 0.4.1 libxcb_util_keysyms 0.4.0 -> 0.4.1 libxcb_util_render 0.3.9 -> 0.3.10 libxcb_util_wm 0.4.1 -> 0.4.2 xcb_proto 1.15.2 -> 1.17.0 These recently became static in #33537. Also update expat 2.4.8 -> 2.7.3. ACKs for top commit: hebasto: ACK f541b92, due to the last commit, I also tested an LTO build on Ubuntu 25.10 using GCC 15.2.0. Tree-SHA512: 63f32e22743d8fa59b6e78fa8ea301e5cfaa55832454a8bc87ebb18e3d03379e9354519acd040ce861b4b1f3879b9cf9fb724dca69f6e0f8d2ef9ebfa7a032bf
stringintech
added a commit
to stringintech/go-bitcoinkernel
that referenced
this pull request
Nov 24, 2025
0690514d4f Merge bitcoin/bitcoin#33770: init: Require explicit -asmap filename b2f88b53e0 Merge bitcoin/bitcoin#33286: doc: update multisig tutorial to use multipath descriptors 313cdd2bfb Merge bitcoin/bitcoin#33915: test: Retry download in get_previous_releases.py 17072f7005 Merge bitcoin/bitcoin#33912: clang-format: Set PackConstructorInitializers: CurrentLine 6b2d17b132 Merge bitcoin/bitcoin#33888: ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG ac71df4338 Merge bitcoin/bitcoin#33870: refactor: remove incorrect lifetimebounds 6cdb51c14e Merge bitcoin/bitcoin#33887: doc: Improve CI docs on env and qemu-user-static 29c37651c7 Merge bitcoin/bitcoin#33880: test: Fix race condition in IPC interface block progation test 32368cd3e9 Merge bitcoin/bitcoin#33905: ci: Consistenly only cache on the default branch e55c49f851 Merge bitcoin/bitcoin#33851: depends: update xcb-util packages to latest versions a07bd8415d Merge bitcoin/bitcoin#33824: ci: Enable experimental kernel stuff in most CI tasks via `dev-mode` f541b92cf2 depends: expat 2.7.3 fad06f3bb4 test: retry download in get_previous_releases.py 2ebf4356e6 depends: libxcb 1.17.0 ba7ac870a3 depends: xcb_proto 1.17.0 fad0c76d0a clang-format: Set PackConstructorInitializers: CurrentLine 42d0692f91 depends: libxcb-util-cursor 0.1.6 25b85919ab depends: libxcb 1.15 d129384ca9 depends: libxcb-util-wm 0.4.2 0b857ae9e5 depends: libxcb-util-renderutil 0.3.10 35e50488b2 depends: libxcb-util-keysyms 0.4.1 74b68ad28b depends: libxcb-util-image 0.4.1 5bc0dde85d depends: libxcb-util 0.4.1 8d07292c28 depends: libXau 1.0.12 1af46cff94 Merge bitcoin/bitcoin#33896: clang-format: Set InsertNewlineAtEOF: true 27ac11ea0a Merge bitcoin/bitcoin#33867: kernel: handle null or empty directories in implementation 2578e6fc0f test: Fix race condition in IPC interface block propagation test 288b8c30be doc: Drop (default: none) from -i2psam description 509dc91db1 Merge bitcoin/bitcoin#33026: test, refactor: Embedded ASMap [1/3]: Selected minor preparatory work b126f98194 Merge bitcoin-core/gui#910: Added test coverage for qt gui#901 console history filter 7d7b829c36 Merge bitcoin-core/gui#908: Remove HD seed reference from blank wallet tooltip 53b72372da Merge bitcoin/bitcoin#31734: miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()` a7f9bbe4c5 Merge bitcoin/bitcoin#32821: rpc: Handle -named argument parsing where '=' character is used 55555db055 doc: Add missing --platform=linux to docker build command fa0ce4c148 ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG faa0973de2 ci: [refactor] Rename CIRRUS_PR env var to LINT_CI_IS_PR fa411f938e ci: Consistenly only cache on the default branch 552eb90071 doc: CI - Describe qemu-user-static usage 2afbbddee5 doc: CI - Clarify how important `env -i` is and why 2444488f6a Merge bitcoin/bitcoin#33894: net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` fa1bf6818f clang-format: Set InsertNewlineAtEOF: true 115d298a9f Merge bitcoin/bitcoin#33872: init: completely remove `-maxorphantx` option a90f3922ff Merge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 4d893c0f46 net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` fa1dacaebe ci: Move lint exec snippet to stand-alone py file ead849c9f1 Merge bitcoin/bitcoin#33886: test: Remove tests violating hardened std::span c03081fdb4 Merge bitcoin/bitcoin#33776: ci: Lint follow-ups fadb4f63cb test: Remove tests violating hardened std::span 6e21558160 Merge bitcoin/bitcoin#33869: refactor: Avoid -W*-whitespace in git archive c8715aca95 Merge bitcoin/bitcoin#33247: build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings ee5de407e3 Merge bitcoin/bitcoin#33537: guix: build `bitcoin-qt` with static libxcb & utils 024a787350 Merge bitcoin/bitcoin#33876: doc: Update NetBSD Build Guide c66e988754 Merge bitcoin/bitcoin#33865: cmake: Specify Windows plugin path in `test_bitcoin-qt` property c29eaeeaf9 doc: Update NetBSD Build Guide 7f318e1dd0 test: Add better coverage for Autofile size() e221b25246 Merge bitcoin/bitcoin#33860: depends: drop Qt patches b7af960eb8 refactor: Add AutoFile::size ec0f75862e refactor: Modernize logging in util/asmap.cpp 606a251e0a tests: add unit test vectors for asmap interpreter 6657bcbdb4 kernel: allow null data_directory 0aebdac95d init: completely remove `-maxorphantx` option 99d012ec80 refactor: return reference instead of pointer f743e6c5dd refactor: add missing LIFETIMEBOUND annotation for parameter fa95353902 ci: Run macos tasks in a git archive, not git checkout 141117f5e8 refactor: remove incorrect LIFETIMEBOUND annotations fae3618fd6 ci: Annotate all check runs with the pull request number faf05d637d ci: Retry lint image building once after failure 96963b888e depends: static libxcb ad06843fab depends: avoid qdbusviewer in Qt build 6848ed56dc depends: apply Qt patches to fix static libxcb use dfde31f2ec Merge bitcoin/bitcoin#33864: scripted-diff: fix leftover references to `policy/fees.h` 5f1b016beb depends: static libxcb-util-image 98a2fbbe70 depends: static libxkbcommon 1412baf772 depends: static libxcb-util-wm a4009dadf4 depends: static libxcb-keysyms bcfb8679b3 depends: static libxcb-render-util faf99ae379 refactor: Avoid -W*-whitespace in git archive 2594d5a189 build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings 310e4979b3 qt: Added test coverage for qt gui#901 console history filter 0dd8d5c237 cmake: Specify Windows plugin path in `test_bitcoin-qt` property b0a3887154 scripted-diff: fix leftover references to `policy/fees.h` 48d4b936e0 Merge bitcoin/bitcoin#33511: init: Fix Ctrl-C shutdown hangs during wait calls 3c3c6adb72 Merge bitcoin/bitcoin#33745: mining: check witness commitment in submitBlock e652b69b8d Merge bitcoin/bitcoin#33003: test: add option to skip large re-org test in feature_block 3789215f73 Merge bitcoin/bitcoin#33724: refactor: Return uint64_t from GetSerializeSize d4e2a45833 Merge bitcoin/bitcoin#33750: doc: document fingerprinting risk when operating node on multiple networks 47618446a0 Merge bitcoin/bitcoin#33853: kernel: Allow null arguments for serialized data 3e9aca6f1b depends: drop qtbase-moc-ignore-gcc-macro.patch qt patch fac4f6de28 ci: Rewrite lint task Bash snippet to Python fa0d37a579 ci: Rewrite Bash to check inputs to Python 0da5a82700 depends: drop unused qt patch fae83611b8 ci: [refactor] Use --preset=dev-mode in mac_native task fadb67b4b4 ci: [refactor] Base nowallet task on --preset=dev-mode 6666980e86 ci: Enable bitcoin-chainstate and test_bitcoin-qt in win64 task d0da953773 Merge bitcoin/bitcoin#32482: build: add `-W*-whitespace` f450761f83 Merge bitcoin/bitcoin#33842: build: Bump g++ minimum supported version to 12 faff7b2312 ci: Enable experimental kernel stuff in i686 task fa1632eecf ci: Enable experimental kernel stuff in mac-cross tasks fad10ff7c9 ci: Enable experimental kernel stuff in armhf task fa9d67c13d ci: Enable experimental kernel stuff in Alpine task fab3fb8302 ci: Enable experimental kernel stuff in s390x task fa7da8a646 ci: Enable experimental kernel stuff in valgrind task fa9c2973d6 ci: Enable experimental kernel stuff in TSan task fad30d4395 ci: Enable experimental kernel stuff in MSan task fa9f29a4a7 doc: Recommend latest Debian stable or Ubuntu LTS fa1711ee0d doc: Add GCC-12 min release notes faa8be75c9 ci: Enable experimental kernel stuff in G++-12 task (previous releases) fabce97b30 test: Remove gccbug_90348 test case fa3854e432 test: Remove unused fs::create_directories test fa9dacdbde util: [refactor] Remove unused create_directories workaround 138726a6f8 Merge bitcoin/bitcoin#33850: depends: drop qtbase_avoid_native_float16 qt patch 1c3d5c8ffd Merge bitcoin/bitcoin#33840: test: [refactor] Use reference over ptr to chainman 40dcbf580d build: add -Wtrailing-whitespace=any a3ac59a431 ci: Enable experimental kernel stuff in ASan task 5b89956eeb kernel: Allow null arguments for serialized data 169f93d2ac depends: drop qtbase_avoid_native_float16 qt patch d7659cd7e6 build: add -Wleading-whitespace=spaces d86650220a cmake: Disable `-Wtrailing-whitespace` warnings for RCC-generated files aabc5ca6ed cmake: Switch from AUTORCC to `qt6_add_resources` 25ae14c339 subprocess: replace tab with space 0c2b9dadd5 scripted-diff: remove whitespace in sha256_sse4.cpp 4da084fbc9 scripted-diff: change whitespace to spaces in univalue e6caf150b3 ci: add moreutils to lint job a7e8067610 Merge bitcoin/bitcoin#33181: guix: build for Linux HOSTS with `-static-libgcc` b354d1ce5c Merge bitcoin/bitcoin#33820: kernel: trim Chain interface fa807f78ae build: Bump g++ minimum supported version to 12 a4e96cae7d Merge bitcoin/bitcoin#33042: refactor: inline constant return values from `dbwrapper` write methods 8c2710b041 Merge bitcoin/bitcoin#32517: rpc: add "ischange: true" to decoded tx outputs in wallet gettransaction response 1fe851a478 Merge bitcoin/bitcoin#32180: p2p: Advance pindexLastCommonBlock early after connecting blocks 5f0303b93f Merge bitcoin/bitcoin#33443: log: reduce excessive "rolling back/forward" messages during block replay f4903dddc9 Merge bitcoin/bitcoin#33433: Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found 7a4901c902 test, refactor: Fix `-Warray-bounds` warning 06e9458869 Merge bitcoin/bitcoin#32856: Update `minisketch` subtree 66978a1a95 kernel: remove btck_chain_get_tip 4dd7e6dc48 kernel: remove btck_chain_get_genesis faf2759c8c test: [refactor] Use reference over ptr to chainman 490cb056f6 Merge bitcoin/bitcoin#33785: util: Allow `Assert` (et al.) in contexts without __func__ dcd0099a76 Merge bitcoin/bitcoin#33826: scripted-diff: Remove obsolete comment 01adbbcd9c Merge bitcoin/bitcoin#33827: doc: Correct `pkgin` command usage on NetBSD eec21bc7c8 Merge bitcoin/bitcoin#33536: doc: reference fuzz coverage steps in quick-start 035f934e02 Merge bitcoin/bitcoin#33823: ci: Use cmake --preset=dev-mode in test-each-commit task ddd2afac10 Merge bitcoin/bitcoin#33676: interfaces: enable cancelling running `waitNext` calls dee7eec643 doc: mention coverage build in quickstart section 0698c6b494 doc: Correct `pkgin` command usage on NetBSD 36724205fc scripted-diff: Remove obsolete comment ca1ce52a0f Merge bitcoin/bitcoin#33825: refactor: Add missing include in bitcoinkernel_wrapper.h fa1e8d8bad refactor: Add missing include in bitcoinkernel_wrapper.h fa6db67369 ci: [refactor] Extract build_dir constant in ci-test-each-commit-exec.py fa95e6cdc1 ci: Use cmake --preset=dev-mode in test-each-commit task 513a0da2e0 Merge bitcoin/bitcoin#33818: ci: Extend tidy job to cover kernel code 5d0a40d607 ci: Extend tidy job to cover kernel code 93e79181da Merge bitcoin/bitcoin#33786: script: remove dead code in `CountWitnessSigOps` 3c4bec6223 Merge bitcoin/bitcoin#33782: test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py 4b12beedae Merge bitcoin/bitcoin#33793: test: move create_malleated_version() to messages.py for reuse 0b45e6db10 Merge bitcoin/bitcoin#33789: doc: add cmake help option in Windows build docs 2b9c351198 Merge bitcoin/bitcoin#33768: refactor: remove dead branches in `SingletonClusterImpl` fad6efd3be refactor: Use STR_INTERNAL_BUG macro where possible fada379589 doc: Remove unused bugprone-lambda-function-name suppression f06c6e1898 guix: build for Linux HOSTS with -static-libgcc 1bdf4695b0 guix: patch store paths out of libunwind 078a72c35f guix: move static-libc++ into CMAKE_EXE_LINKER_FLAGS flags 2bd155e6ee test: move create_malleated_version() to messages.py for reuse 9577daa3b8 doc: Add cmake help option in Windows build instructions fae1d99651 refactor: Use const reference to std::source_location fa5fbcd615 util: Allow Assert() in contexts without __func__ 24bcad3d4d refactor: remove dead code in `CountWitnessSigOps` ec8516ceb7 test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py 2d23820ee1 refactor: remove dead branches in `SingletonClusterImpl` e346ecae83 Add eclipse, partitioning, and fingerprinting note to i2p.md f6ec3519a3 init: Require explicit -asmap filename 6eaa00fe20 test: clarify submitBlock() mutates the template 862bd43283 mining: ensure witness commitment check in submitBlock 00d1b6ef4b doc: clarify UpdateUncommittedBlockStructures 929f69d0ff qt: Remove HD seed reference from blank wallet tooltip 19a6a3e75e Add eclipse, partitioning, and fingerprinting note in tor.md fa6c0bedd3 refactor: Return uint64_t from GetSerializeSize fad0c8680e refactor: Use uint64_t over size_t for serialized-size values fa4f388fc9 refactor: Use fixed size ints over (un)signed ints for serialized values 060bb55508 rpc: add decoded tx details to gettransaction with extra wallet fields ad1c3bdba5 [move only] move DecodeTxDoc() to a common util file for sharing d633db5416 rpc: add "ischange: true" in wallet gettransaction decoded tx output fa01f38e53 move-only: Move CBlockFileInfo to kernel namespace fa2bbc9e4c refactor: [rpc] Remove cast when reporting serialized size fa364af89b test: Remove outdated comment dcb56fd4cb interfaces: add interruptWait method de7c3587cd doc: Update add checksum instructions in tutorial c235aa468b Update minisketch subtree to latest upstream 4543a3bde2 Squashed 'src/minisketch/' changes from ea8f66b1ea..d1bd01e189 01cc20f330 test: improve coverage for a resolved stalling situation 9af6daf07e test: remove magic number when checking for blocks that have arrived 3069d66dca p2p: During block download, adjust pindexLastCommonBlock better 2a46e94a16 doc: Update multisig-tutorial.md to use multipath descriptors c25a5e670b init: Signal m_tip_block_cv on Ctrl-C f53dbbc505 test: Add functional tests for named argument parsing 694f04e2bd rpc: Handle -named argument parsing where '=' character is used 6a29f79006 test: Test SIGTERM handling during waitforblockheight call 1fc7a81f1f log: reduce excessive messages during block replay 79b4c276e7 Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found 743abbcbde refactor: inline constant return value of `BlockTreeDB::WriteBatchSync` and `BlockManager::WriteBlockIndexDB` and `BlockTreeDB::WriteFlag` e030240e90 refactor: inline constant return value of `CDBWrapper::Erase` and `BlockTreeDB::WriteReindexing` cdab9480e9 refactor: inline constant return value of `CDBWrapper::Write` d1847cf5b5 refactor: inline constant return value of `TxIndex::DB::WriteTxs` 50b63a5698 refactor: inline constant return value of `CDBWrapper::WriteBatch` 8810642b57 test: add option to skip large re-org test in feature_block d31158d364 psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 28a4fcb03c test: check listdescriptors do not return a mix of hardened derivation marker 975783cb79 descriptor: account for all StringType in MiniscriptDescriptor::ToStringHelper() git-subtree-dir: depend/bitcoin git-subtree-split: 0690514d4f72aac251ee0b876cded9187d42c63e
alexanderwiederin
added a commit
to alexanderwiederin/rust-bitcoinkernel
that referenced
this pull request
Dec 1, 2025
…356041e58d1 6356041e58d1 Merge bitcoin/bitcoin#33972: cmake: Make `BUILD_KERNEL_TEST` depend on `BUILD_KERNEL_LIB` 7d7cb1bb48f1 Merge bitcoin/bitcoin#33971: cmake: Set `WITH_ZMQ` to `ON` in Windows presets fe1815d48f0c cmake: Make `BUILD_KERNEL_TEST` depend on `BUILD_KERNEL_LIB` 49c672853503 cmake: Set `WITH_ZMQ` to `ON` in Windows presets f6acbef1084e Merge bitcoin/bitcoin#33764: ci: Add Windows + UCRT jobs for cross-compiling and native testing 808f1d972be3 Merge bitcoin/bitcoin#32009: contrib: turn off compression of macOS SDK to fix determinism (across distros) 4de26b111f4d Merge bitcoin/bitcoin#33514: ci: clear out space on CentOS, depends, gui GHA job 38c8474d0d77 Merge bitcoin/bitcoin#33914: Change Parse descriptor argument to string_view 4b25b274de66 Merge bitcoin/bitcoin#33951: test: check for output to stdout in `TestShell` test 52230a7f697f test: check for output to stdout in `TestShell` test 85d058dc537e Merge bitcoin/bitcoin#33946: interfaces: remove redundant mempool lock in ChainImpl::isInMempool() e07e57368e9f ci: clear out space on centos job 79d6e874e1da Merge bitcoin/bitcoin#32587: test: Fix reorg patterns in tests to use proper fork-based approach e249ea7da6c2 Merge bitcoin/bitcoin#33945: depends: latest config.guess & config.sub 3e01b5d0e7be contrib: rename gen-sdk to gen-sdk.py c1213a35abed macdeploy: disable compression in macOS gen-sdk script a33d03454508 contrib: more selectively pick files for macOS SDK 70d9e8f0a15d fix: reorg behaviour in mempool tests to match real one 540ed333f6c8 Move the create_empty_fork method to the test framework's blocktools.py module to enable reuse across multiple tests. 2909655fba91 fix: remove redundant mempool lock in ChainImpl::isInMempool() d5ed4ba9d862 Merge bitcoin/bitcoin#33906: depends: Add patch for Windows11Style plugin 3e4355314b1a depends: latest config.sub 04eb84fe3f73 depends: latest config.guess b30262dcaa28 Merge bitcoin/bitcoin#33903: ci: Remove redundant busybox option 1a5f1eb08067 Merge bitcoin/bitcoin#33921: doc: clarify and cleanup macOS fuzzing notes 72cb8cef9778 Merge bitcoin/bitcoin#33862: txgraph: drop move assignment operator ade0397f59f2 txgraph: drop move assignment operator 5336bcd57849 Merge bitcoin/bitcoin#33855: kernel: add btck_block_tree_entry_equals 4f65a1c5db84 Merge bitcoin/bitcoin#33917: clang-format: Set Bitcoin Core IncludeCategories 902717b66dc1 Merge bitcoin/bitcoin#33918: depends: Update Qt download link 68ab2b65bfac Merge bitcoin/bitcoin#33919: ci: Run GUI unit tests in cross-Windows task 7e129b644ec9 Merge bitcoin/bitcoin#33893: test: add `-alertnotify` test for large work invalid chain warning 5fe753b56f45 Merge bitcoin/bitcoin#32655: depends: sqlite 3.50.4; switch to autosetup ff8c2f37497f Merge bitcoin/bitcoin#33932: ci: Use latest Xcode that the minimum macOS version allows fa283d28e261 Merge bitcoin/bitcoin#33629: Cluster mempool 2e27bd9c3af9 ci: Add Windows + UCRT jobs for cross-compiling and native testing 238c1c8933b1 Merge bitcoin-core/gui#914: Revert "gui, qt: brintToFront workaround for Wayland" 8343a9ffcc75 test: add `-alertnotify` test for large work invalid chain warning c34bc01b2ff2 doc: clarify and cleanup macOS fuzzing notes fa9537cde101 ci: Use latest Xcode that the minimum macOS version allows 17cf9ff7efdb Use cluster size limit for -maxmempool bound, and allow -maxmempool=0 in general 315e43e5d86c Sanity check `GetFeerateDiagram()` in CTxMemPool::check() de2e9a24c40e test: extend package rbf functional test to larger clusters 4ef4ddb504e5 doc: update policy/packages.md for new package acceptance logic 79f73ad713a8 Add check that GetSortedScoreWithTopology() agrees with CompareMiningScoreWithTopology() a86ac1176817 Update comments for CTxMemPool class 9567eaa66da8 Invoke TxGraph::DoWork() at appropriate times 0690514d4f72 Merge bitcoin/bitcoin#33770: init: Require explicit -asmap filename b2f88b53e0ec Merge bitcoin/bitcoin#33286: doc: update multisig tutorial to use multipath descriptors 313cdd2bfb71 Merge bitcoin/bitcoin#33915: test: Retry download in get_previous_releases.py bd130db994e2 ci: Rename items specific to Windows + MSVCRT 0672e727bf1d Revert "gui, qt: brintToFront workaround for Wayland" 17072f70051d Merge bitcoin/bitcoin#33912: clang-format: Set PackConstructorInitializers: CurrentLine fa7ea497c3ef ci: Run GUI unit tests in cross-Windows task fa0fee44a89c ci: Remove redundant busybox option fa102ec69fae doc: Shorten ci name fa7e222a2326 clang-format: Set Bitcoin Core IncludeCategories 222222378048 doc: Remove bash -c wrapper 6b2d17b13220 Merge bitcoin/bitcoin#33888: ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG ac71df43383a Merge bitcoin/bitcoin#33870: refactor: remove incorrect lifetimebounds 6cdb51c14eba Merge bitcoin/bitcoin#33887: doc: Improve CI docs on env and qemu-user-static 50cbde3295b4 depends: Update Qt download link 29c37651c74b Merge bitcoin/bitcoin#33880: test: Fix race condition in IPC interface block progation test 32368cd3e9f3 Merge bitcoin/bitcoin#33905: ci: Consistenly only cache on the default branch e55c49f85143 Merge bitcoin/bitcoin#33851: depends: update xcb-util packages to latest versions a07bd8415df4 Merge bitcoin/bitcoin#33824: ci: Enable experimental kernel stuff in most CI tasks via `dev-mode` c0bfe72f6e1f Change Parse descriptor argument to string_view f541b92cf2bb depends: expat 2.7.3 fad06f3bb436 test: retry download in get_previous_releases.py 2ebf4356e63d depends: libxcb 1.17.0 ba7ac870a32a depends: xcb_proto 1.17.0 fad0c76d0a10 clang-format: Set PackConstructorInitializers: CurrentLine 42d0692f9131 depends: libxcb-util-cursor 0.1.6 25b85919ab62 depends: libxcb 1.15 d129384ca97f depends: libxcb-util-wm 0.4.2 0b857ae9e555 depends: libxcb-util-renderutil 0.3.10 35e50488b25a depends: libxcb-util-keysyms 0.4.1 74b68ad28ba2 depends: libxcb-util-image 0.4.1 5bc0dde85d74 depends: libxcb-util 0.4.1 8d07292c286f depends: libXau 1.0.12 1af46cff9478 Merge bitcoin/bitcoin#33896: clang-format: Set InsertNewlineAtEOF: true 27ac11ea0a27 Merge bitcoin/bitcoin#33867: kernel: handle null or empty directories in implementation 2578e6fc0f4a test: Fix race condition in IPC interface block propagation test 288b8c30be42 doc: Drop (default: none) from -i2psam description 509dc91db143 Merge bitcoin/bitcoin#33026: test, refactor: Embedded ASMap [1/3]: Selected minor preparatory work b126f981943d Merge bitcoin-core/gui#910: Added test coverage for qt gui#901 console history filter 7d7b829c36b7 Merge bitcoin-core/gui#908: Remove HD seed reference from blank wallet tooltip 8558902e576e depends: Add patch for Windows11Style plugin 53b72372da91 Merge bitcoin/bitcoin#31734: miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()` a7f9bbe4c5e7 Merge bitcoin/bitcoin#32821: rpc: Handle -named argument parsing where '=' character is used 55555db055b5 doc: Add missing --platform=linux to docker build command fa0ce4c1486b ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG faa0973de296 ci: [refactor] Rename CIRRUS_PR env var to LINT_CI_IS_PR fa411f938e47 ci: Consistenly only cache on the default branch 6c5c44f77405 test: add functional test for new cluster mempool RPCs 72f60c877e00 doc: Update mempool_replacements.md to reflect feerate diagram checks 21693f031a53 Expose cluster information via rpc 72e74e0d4228 fuzz: try to add more code coverage for mempool fuzzing f107417490ab bench: add more mempool benchmarks 7976eb1ae77a Avoid violating mempool policy limits in tests 84de685cf7ee Stop tracking parents/children outside of txgraph 88672e205ba1 Rewrite GatherClusters to use the txgraph implementation 1ca4f01090cf Fix miniminer_tests to work with cluster limits 1902111e0f20 Eliminate CheckPackageLimits, which no longer does anything 3a646ec46264 Rework RBF and TRUC validation 19b8479868e5 Make getting parents/children a function of the mempool, not a mempool entry 5560913e51af Rework truc_policy to use descendants, not children a4458d6c4062 Use txgraph to calculate descendants c8b6f70d6492 Use txgraph to calculate ancestors 241a3e666b59 Simplify ancestor calculation functions b9cec7f0a1e0 Make removeConflicts private 0402e6c78080 Remove unused limits from CalculateMemPoolAncestors 08be765ac26a Remove mempool logic designed to maintain ancestor/descendant state fc4e3e6bc122 Remove unused members from CTxMemPoolEntry ff3b398d124b mempool: eliminate accessors to mempool entry ancestor/descendant cached state b9a2039f5122 Eliminate use of cached ancestor data in miniminer_tests and truc_policy ba09fc9774d5 mempool: Remove unused function CalculateDescendantMaximum 8e49477e86b3 wallet: Replace max descendant count with cluster_count e031085fd464 Eliminate Single-Conflict RBF Carve Out cf3ab8e1d0a2 Stop enforcing descendant size/count limits 89ae38f48965 test: remove rbf carveout test from mempool_limit.py c0bd04d18fdf Calculate descendant information for mempool RPC output on-the-fly bdcefb8a8b06 Use mempool/txgraph to determine if a tx has descendants 69e1eaa6ed22 Add test case for cluster size limits to TRUC logic 9cda64b86c59 Stop enforcing ancestor size/count limits 1f93227a84a5 Remove dependency on cached ancestor data in mini-miner 9fbe0a4ac26c rpc: Calculate ancestor data from scratch for mempool rpc calls 7961496dda2e Reimplement GetTransactionAncestry() to not rely on cached data feceaa42e8eb Remove CTxMemPool::GetSortedDepthAndScore 21b5cea588a7 Use cluster linearization for transaction relay sort order 6445aa7d9755 Remove the ancestor and descendant indices from the mempool 216e69372903 Implement new RBF logic for cluster mempool ff8f115dec6e policy: Remove CPFP carveout rule c3f1afc934e6 test: rewrite PopulateMempool to not violate mempool policy (cluster size) limits 47ab32fdb158 Select transactions for blocks based on chunk feerate dec138d1ddc7 fuzz: remove comparison between mini_miner block construction and miner 6c2bceb200aa bench: rewrite ComplexMemPool to not create oversized clusters 1ad4590f6385 Limit mempool size based on chunk feerate b11c89cab210 Rework miner_tests to not require large cluster limit 95a8297d481e Check cluster limits when using -walletrejectlongchains 95762e675959 Do not allow mempool clusters to exceed configured limits edb3e7cdf636 [test] rework/delete feature_rbf tests requiring large clusters 435fd5671116 test: update feature_rbf.py replacement test 34e32985e811 Add new (unused) limits for cluster size/count 838d7e355366 Add transactions to txgraph, but without cluster dependencies 552eb90071fd doc: CI - Describe qemu-user-static usage 2afbbddee550 doc: CI - Clarify how important `env -i` is and why 2444488f6ad3 Merge bitcoin/bitcoin#33894: net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` fa1bf6818f09 clang-format: Set InsertNewlineAtEOF: true 115d298a9fa3 Merge bitcoin/bitcoin#33872: init: completely remove `-maxorphantx` option a90f3922ff7d Merge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 4d893c0f4605 net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` fa1dacaebe5d ci: Move lint exec snippet to stand-alone py file ead849c9f177 Merge bitcoin/bitcoin#33886: test: Remove tests violating hardened std::span c03081fdb467 Merge bitcoin/bitcoin#33776: ci: Lint follow-ups fadb4f63cb0f test: Remove tests violating hardened std::span 6e2155816058 Merge bitcoin/bitcoin#33869: refactor: Avoid -W*-whitespace in git archive c8715aca95d0 Merge bitcoin/bitcoin#33247: build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings ee5de407e369 Merge bitcoin/bitcoin#33537: guix: build `bitcoin-qt` with static libxcb & utils 024a7873500e Merge bitcoin/bitcoin#33876: doc: Update NetBSD Build Guide c66e98875439 Merge bitcoin/bitcoin#33865: cmake: Specify Windows plugin path in `test_bitcoin-qt` property c29eaeeaf937 doc: Update NetBSD Build Guide 7f318e1dd049 test: Add better coverage for Autofile size() e221b2524659 Merge bitcoin/bitcoin#33860: depends: drop Qt patches b7af960eb82f refactor: Add AutoFile::size ec0f75862e67 refactor: Modernize logging in util/asmap.cpp 606a251e0a31 tests: add unit test vectors for asmap interpreter 6657bcbdb4d0 kernel: allow null data_directory 0aebdac95da9 init: completely remove `-maxorphantx` option 99d012ec80a4 refactor: return reference instead of pointer f743e6c5dd38 refactor: add missing LIFETIMEBOUND annotation for parameter fa95353902b7 ci: Run macos tasks in a git archive, not git checkout 141117f5e8b4 refactor: remove incorrect LIFETIMEBOUND annotations fae3618fd6c8 ci: Annotate all check runs with the pull request number faf05d637d67 ci: Retry lint image building once after failure 96963b888e5a depends: static libxcb ad06843fab06 depends: avoid qdbusviewer in Qt build 6848ed56dc5f depends: apply Qt patches to fix static libxcb use dfde31f2ec1f Merge bitcoin/bitcoin#33864: scripted-diff: fix leftover references to `policy/fees.h` 5f1b016bebd2 depends: static libxcb-util-image 98a2fbbe70b8 depends: static libxkbcommon 1412baf77295 depends: static libxcb-util-wm a4009dadf466 depends: static libxcb-keysyms bcfb8679b3ba depends: static libxcb-render-util faf99ae37963 refactor: Avoid -W*-whitespace in git archive 2594d5a189e5 build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings 310e4979b36c qt: Added test coverage for qt gui#901 console history filter 0dd8d5c237e2 cmake: Specify Windows plugin path in `test_bitcoin-qt` property b0a38871546d scripted-diff: fix leftover references to `policy/fees.h` 48d4b936e09f Merge bitcoin/bitcoin#33511: init: Fix Ctrl-C shutdown hangs during wait calls 3c3c6adb7260 Merge bitcoin/bitcoin#33745: mining: check witness commitment in submitBlock e652b69b8da4 Merge bitcoin/bitcoin#33003: test: add option to skip large re-org test in feature_block 3e9aca6f1b52 depends: drop qtbase-moc-ignore-gcc-macro.patch qt patch fac4f6de28e7 ci: Rewrite lint task Bash snippet to Python fa0d37a57985 ci: Rewrite Bash to check inputs to Python 0da5a82700e9 depends: drop unused qt patch fae83611b8ef ci: [refactor] Use --preset=dev-mode in mac_native task fadb67b4b4e1 ci: [refactor] Base nowallet task on --preset=dev-mode 6666980e8653 ci: Enable bitcoin-chainstate and test_bitcoin-qt in win64 task 096924d39d64 kernel: add btck_block_tree_entry_equals faff7b231246 ci: Enable experimental kernel stuff in i686 task fa1632eecf58 ci: Enable experimental kernel stuff in mac-cross tasks fad10ff7c923 ci: Enable experimental kernel stuff in armhf task fa9d67c13d0d ci: Enable experimental kernel stuff in Alpine task fab3fb83026e ci: Enable experimental kernel stuff in s390x task fa7da8a646ed ci: Enable experimental kernel stuff in valgrind task fa9c2973d60b ci: Enable experimental kernel stuff in TSan task fad30d439502 ci: Enable experimental kernel stuff in MSan task d5ed9cb3eb52 Add accessor for sigops-adjusted weight 1bf3b513966e Add sigops adjusted weight calculator c18c68a950d3 Create a txgraph inside CTxMemPool 29a94d5b2f26 Make CTxMemPoolEntry derive from TxGraph::Ref 92b0079fe386 Allow moving CTxMemPoolEntry objects, disallow copying f6ec3519a330 init: Require explicit -asmap filename 6eaa00fe2020 test: clarify submitBlock() mutates the template 862bd432837e mining: ensure witness commitment check in submitBlock 00d1b6ef4b12 doc: clarify UpdateUncommittedBlockStructures 929f69d0ff29 qt: Remove HD seed reference from blank wallet tooltip 1db74914706f depends: sqlite 3.50.4 286f3e49c84c guix: sqlite wants tcl de7c3587cd45 doc: Update add checksum instructions in tutorial 6c73e4744837 mempool: Store iterators into mapTx in mapNextTx 51430680ecb7 Allow moving an Epoch::Marker 2a46e94a1600 doc: Update multisig-tutorial.md to use multipath descriptors c25a5e670b27 init: Signal m_tip_block_cv on Ctrl-C f53dbbc5057b test: Add functional tests for named argument parsing 694f04e2bd34 rpc: Handle -named argument parsing where '=' character is used 6a29f79006a9 test: Test SIGTERM handling during waitforblockheight call 8810642b571e test: add option to skip large re-org test in feature_block d31158d3646f psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 28a4fcb03c0f test: check listdescriptors do not return a mix of hardened derivation marker 975783cb79e9 descriptor: account for all StringType in MiniscriptDescriptor::ToStringHelper() git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: 6356041e58d1ba86695e2e7c219c68ee5abe583f
yuvicc
added a commit
to yuvicc/bitcoinkernel-jdk
that referenced
this pull request
Dec 16, 2025
30367c1b3e kernel: Add support for block headers 4eda3a00da kernel: Add Handle/View pattern for BlockValidationState 0690514d4f Merge bitcoin/bitcoin#33770: init: Require explicit -asmap filename b2f88b53e0 Merge bitcoin/bitcoin#33286: doc: update multisig tutorial to use multipath descriptors 313cdd2bfb Merge bitcoin/bitcoin#33915: test: Retry download in get_previous_releases.py 17072f7005 Merge bitcoin/bitcoin#33912: clang-format: Set PackConstructorInitializers: CurrentLine 6b2d17b132 Merge bitcoin/bitcoin#33888: ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG ac71df4338 Merge bitcoin/bitcoin#33870: refactor: remove incorrect lifetimebounds 6cdb51c14e Merge bitcoin/bitcoin#33887: doc: Improve CI docs on env and qemu-user-static 29c37651c7 Merge bitcoin/bitcoin#33880: test: Fix race condition in IPC interface block progation test 32368cd3e9 Merge bitcoin/bitcoin#33905: ci: Consistenly only cache on the default branch e55c49f851 Merge bitcoin/bitcoin#33851: depends: update xcb-util packages to latest versions a07bd8415d Merge bitcoin/bitcoin#33824: ci: Enable experimental kernel stuff in most CI tasks via `dev-mode` f541b92cf2 depends: expat 2.7.3 fad06f3bb4 test: retry download in get_previous_releases.py 2ebf4356e6 depends: libxcb 1.17.0 ba7ac870a3 depends: xcb_proto 1.17.0 fad0c76d0a clang-format: Set PackConstructorInitializers: CurrentLine 42d0692f91 depends: libxcb-util-cursor 0.1.6 25b85919ab depends: libxcb 1.15 d129384ca9 depends: libxcb-util-wm 0.4.2 0b857ae9e5 depends: libxcb-util-renderutil 0.3.10 35e50488b2 depends: libxcb-util-keysyms 0.4.1 74b68ad28b depends: libxcb-util-image 0.4.1 5bc0dde85d depends: libxcb-util 0.4.1 8d07292c28 depends: libXau 1.0.12 1af46cff94 Merge bitcoin/bitcoin#33896: clang-format: Set InsertNewlineAtEOF: true 27ac11ea0a Merge bitcoin/bitcoin#33867: kernel: handle null or empty directories in implementation 2578e6fc0f test: Fix race condition in IPC interface block propagation test 288b8c30be doc: Drop (default: none) from -i2psam description 509dc91db1 Merge bitcoin/bitcoin#33026: test, refactor: Embedded ASMap [1/3]: Selected minor preparatory work b126f98194 Merge bitcoin-core/gui#910: Added test coverage for qt gui#901 console history filter 7d7b829c36 Merge bitcoin-core/gui#908: Remove HD seed reference from blank wallet tooltip 53b72372da Merge bitcoin/bitcoin#31734: miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()` a7f9bbe4c5 Merge bitcoin/bitcoin#32821: rpc: Handle -named argument parsing where '=' character is used 55555db055 doc: Add missing --platform=linux to docker build command fa0ce4c148 ci: Re-enable LINT_CI_SANITY_CHECK_COMMIT_SIG faa0973de2 ci: [refactor] Rename CIRRUS_PR env var to LINT_CI_IS_PR fa411f938e ci: Consistenly only cache on the default branch 552eb90071 doc: CI - Describe qemu-user-static usage 2afbbddee5 doc: CI - Clarify how important `env -i` is and why 2444488f6a Merge bitcoin/bitcoin#33894: net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` fa1bf6818f clang-format: Set InsertNewlineAtEOF: true 115d298a9f Merge bitcoin/bitcoin#33872: init: completely remove `-maxorphantx` option a90f3922ff Merge bitcoin/bitcoin#32419: psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 4d893c0f46 net: Remove unused `local_socket_bytes` variable in `CConnman::GetAddresses()` fa1dacaebe ci: Move lint exec snippet to stand-alone py file ead849c9f1 Merge bitcoin/bitcoin#33886: test: Remove tests violating hardened std::span c03081fdb4 Merge bitcoin/bitcoin#33776: ci: Lint follow-ups fadb4f63cb test: Remove tests violating hardened std::span 6e21558160 Merge bitcoin/bitcoin#33869: refactor: Avoid -W*-whitespace in git archive c8715aca95 Merge bitcoin/bitcoin#33247: build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings ee5de407e3 Merge bitcoin/bitcoin#33537: guix: build `bitcoin-qt` with static libxcb & utils 024a787350 Merge bitcoin/bitcoin#33876: doc: Update NetBSD Build Guide c29eaeeaf9 doc: Update NetBSD Build Guide 7f318e1dd0 test: Add better coverage for Autofile size() b7af960eb8 refactor: Add AutoFile::size ec0f75862e refactor: Modernize logging in util/asmap.cpp 606a251e0a tests: add unit test vectors for asmap interpreter 6657bcbdb4 kernel: allow null data_directory 0aebdac95d init: completely remove `-maxorphantx` option 99d012ec80 refactor: return reference instead of pointer f743e6c5dd refactor: add missing LIFETIMEBOUND annotation for parameter fa95353902 ci: Run macos tasks in a git archive, not git checkout 141117f5e8 refactor: remove incorrect LIFETIMEBOUND annotations fae3618fd6 ci: Annotate all check runs with the pull request number faf05d637d ci: Retry lint image building once after failure 96963b888e depends: static libxcb ad06843fab depends: avoid qdbusviewer in Qt build 6848ed56dc depends: apply Qt patches to fix static libxcb use 5f1b016beb depends: static libxcb-util-image 98a2fbbe70 depends: static libxkbcommon 1412baf772 depends: static libxcb-util-wm a4009dadf4 depends: static libxcb-keysyms bcfb8679b3 depends: static libxcb-render-util faf99ae379 refactor: Avoid -W*-whitespace in git archive 2594d5a189 build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings 310e4979b3 qt: Added test coverage for qt gui#901 console history filter fac4f6de28 ci: Rewrite lint task Bash snippet to Python fa0d37a579 ci: Rewrite Bash to check inputs to Python fae83611b8 ci: [refactor] Use --preset=dev-mode in mac_native task fadb67b4b4 ci: [refactor] Base nowallet task on --preset=dev-mode 6666980e86 ci: Enable bitcoin-chainstate and test_bitcoin-qt in win64 task faff7b2312 ci: Enable experimental kernel stuff in i686 task fa1632eecf ci: Enable experimental kernel stuff in mac-cross tasks fad10ff7c9 ci: Enable experimental kernel stuff in armhf task fa9d67c13d ci: Enable experimental kernel stuff in Alpine task fab3fb8302 ci: Enable experimental kernel stuff in s390x task fa7da8a646 ci: Enable experimental kernel stuff in valgrind task fa9c2973d6 ci: Enable experimental kernel stuff in TSan task fad30d4395 ci: Enable experimental kernel stuff in MSan task f6ec3519a3 init: Require explicit -asmap filename 929f69d0ff qt: Remove HD seed reference from blank wallet tooltip de7c3587cd doc: Update add checksum instructions in tutorial 2a46e94a16 doc: Update multisig-tutorial.md to use multipath descriptors f53dbbc505 test: Add functional tests for named argument parsing 694f04e2bd rpc: Handle -named argument parsing where '=' character is used d31158d364 psbt: clarify PSBT, PSBTInput, PSBTOutput unserialization flows 28a4fcb03c test: check listdescriptors do not return a mix of hardened derivation marker 975783cb79 descriptor: account for all StringType in MiniscriptDescriptor::ToStringHelper() git-subtree-dir: bitcoinkernel/bitcoin git-subtree-split: 30367c1b3e7e94ed59d0a3ee816da14a3ee0424f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #33434.
Tested on:
bitcoin-qtwith static libxcb & utils #33537 (review).bitcoin-qtwith static libxcb & utils #33537 (comment).bitcoin-qtwith static libxcb & utils #33537 (comment).