Skip to content

guix: use LIEF 0.17.1 #33522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
fanquake wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

guix: use LIEF 0.17.1 #33522

fanquake wants to merge 2 commits into from
+3 −3

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Oct 2, 2025 •
edited
Loading

Update LIEF in Guix & the CI to 0.17.1: https://lief.re/doc/stable/changelog.html#october-25th-2025.

Guix Build:

64adb8b9b944ef3de68dbe0d8baa45f688b0d3fa0914448ac331a5339575d697  guix-build-98a6d95a0a0a/output/aarch64-linux-gnu/SHA256SUMS.part
704f85c222bfb6bd80f2253d5b9892451f932162377c1ecf7288457ad6c15aba  guix-build-98a6d95a0a0a/output/aarch64-linux-gnu/bitcoin-98a6d95a0a0a-aarch64-linux-gnu-debug.tar.gz
6ab1b8070f3c7addeaee76780cdba27b7ff4c65f6b6fc53402e3863cb94abf77  guix-build-98a6d95a0a0a/output/aarch64-linux-gnu/bitcoin-98a6d95a0a0a-aarch64-linux-gnu.tar.gz
5a8a30b6ea069f61d2f1373217a654f0f8883cd0c291d92837c85259e9552317  guix-build-98a6d95a0a0a/output/arm-linux-gnueabihf/SHA256SUMS.part
cc771236cbd4a013e27a30ea215ea153bbb919862356358431c7aff3789ed745  guix-build-98a6d95a0a0a/output/arm-linux-gnueabihf/bitcoin-98a6d95a0a0a-arm-linux-gnueabihf-debug.tar.gz
1cc32c3d361dc3fd53241c9a5749b27640186310cc74f1646f7c39f2326f4d6b  guix-build-98a6d95a0a0a/output/arm-linux-gnueabihf/bitcoin-98a6d95a0a0a-arm-linux-gnueabihf.tar.gz
765ad83372fde56601c69d582da0e88e6b957e03738c2349a586dc69472a8e80  guix-build-98a6d95a0a0a/output/arm64-apple-darwin/SHA256SUMS.part
4f60db487fa6b53e4876878be0849a207b1a4ccfc31a49a0a2b12c275f15d5db  guix-build-98a6d95a0a0a/output/arm64-apple-darwin/bitcoin-98a6d95a0a0a-arm64-apple-darwin-codesigning.tar.gz
274cd2843ae6518c9ebc4d82e6f1e9038c1057fb923125cc484b88502f0653cc  guix-build-98a6d95a0a0a/output/arm64-apple-darwin/bitcoin-98a6d95a0a0a-arm64-apple-darwin-unsigned.tar.gz
f83f12bb83cbdac89dd5d82ed9888f382506f24e0c5c5d8afaa69ac002a7820c  guix-build-98a6d95a0a0a/output/arm64-apple-darwin/bitcoin-98a6d95a0a0a-arm64-apple-darwin-unsigned.zip
29c30dfc1192cafb34313921aa9329c77358914b1ab5ea6c572afeeb3a0cf791  guix-build-98a6d95a0a0a/output/dist-archive/bitcoin-98a6d95a0a0a.tar.gz
d8b3d18093607cf7e54557d6701b612aea320b12f4c5750278ea8e9df98e84e8  guix-build-98a6d95a0a0a/output/powerpc64-linux-gnu/SHA256SUMS.part
5cafe7a3232a25721bbd6e137327e8885cbc2dde0ad31149210be35ee63940c3  guix-build-98a6d95a0a0a/output/powerpc64-linux-gnu/bitcoin-98a6d95a0a0a-powerpc64-linux-gnu-debug.tar.gz
02adb5302d4ec684e68a18de50f86c7ad7209953c293813b2366eb237290556a  guix-build-98a6d95a0a0a/output/powerpc64-linux-gnu/bitcoin-98a6d95a0a0a-powerpc64-linux-gnu.tar.gz
d1d8a3a48f244095c94c03d541bea04a424b9b419fd46f924309d5a3960a4b9b  guix-build-98a6d95a0a0a/output/riscv64-linux-gnu/SHA256SUMS.part
b94bb2d5ac5cc4d4e39086185d6195caba061a2a2cd783bcefadde3686f011de  guix-build-98a6d95a0a0a/output/riscv64-linux-gnu/bitcoin-98a6d95a0a0a-riscv64-linux-gnu-debug.tar.gz
b372f4fab761e8a2fd3bcf65a53ca3780ba31295fe4e06118ed6c4157cf3b79f  guix-build-98a6d95a0a0a/output/riscv64-linux-gnu/bitcoin-98a6d95a0a0a-riscv64-linux-gnu.tar.gz
b13b8cda5240d0b77acc41c1d313d8935af419179f6e960f574a402812efd73f  guix-build-98a6d95a0a0a/output/x86_64-apple-darwin/SHA256SUMS.part
f093b5db8aefa0d2f5fa9121fdf61679cd3abe0709c888e260f0193c6377ba27  guix-build-98a6d95a0a0a/output/x86_64-apple-darwin/bitcoin-98a6d95a0a0a-x86_64-apple-darwin-codesigning.tar.gz
7cf5b518b4bf11da7f865c72d356869d338054ac450e3d67c8e557d1055b556f  guix-build-98a6d95a0a0a/output/x86_64-apple-darwin/bitcoin-98a6d95a0a0a-x86_64-apple-darwin-unsigned.tar.gz
69e9d0e2b75439ba687bc387002cf9b8d9e634dd1d99d74c0d2105853751214a  guix-build-98a6d95a0a0a/output/x86_64-apple-darwin/bitcoin-98a6d95a0a0a-x86_64-apple-darwin-unsigned.zip
80d12585a20c593c25b389be03abf62c4a7aa64f82a192250e0d7134b8d42ee2  guix-build-98a6d95a0a0a/output/x86_64-linux-gnu/SHA256SUMS.part
18d84260035542953cba39299a6f6a022ff8a652739f9fd4207f0ca8bdeed703  guix-build-98a6d95a0a0a/output/x86_64-linux-gnu/bitcoin-98a6d95a0a0a-x86_64-linux-gnu-debug.tar.gz
32c5fff612ea33ce9b3a79641ba6e228713b6fe546dd1db7c4580b0798282466  guix-build-98a6d95a0a0a/output/x86_64-linux-gnu/bitcoin-98a6d95a0a0a-x86_64-linux-gnu.tar.gz
f1a8d8d8c8271c7c462ff1150c47986a9b55adc701037a178eb065242e3be90f  guix-build-98a6d95a0a0a/output/x86_64-w64-mingw32/SHA256SUMS.part
1959bd2e96784c71f53750a40bc0e2f90c7fe05d3bf3b4090e22b4830763ac00  guix-build-98a6d95a0a0a/output/x86_64-w64-mingw32/bitcoin-98a6d95a0a0a-win64-codesigning.tar.gz
4f299e92122829810d9e75901d689682455a2500329483381524115ef4dc8c99  guix-build-98a6d95a0a0a/output/x86_64-w64-mingw32/bitcoin-98a6d95a0a0a-win64-debug.zip
a6864c11dadcdbc91fabec44f6c3fc17928df7c65ee8360254e4a530ce4ba344  guix-build-98a6d95a0a0a/output/x86_64-w64-mingw32/bitcoin-98a6d95a0a0a-win64-setup-unsigned.exe
e5628bbed9444fe1d490688fd993ce65d9af67d584f5371fef0f92f1cc2375ed  guix-build-98a6d95a0a0a/output/x86_64-w64-mingw32/bitcoin-98a6d95a0a0a-win64-unsigned.zip

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 2, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33522.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

@janb84
Copy link
Contributor

janb84 commented Oct 3, 2025 •
edited
Loading

This works for my guix build

Guix Build Output

Host architecture: aarch64
Commit: 0123c5f56c20

 f83387eefc9384d17a6986dc5390f2f45cc30391af559dbb0dfa7975e3bab6c1  guix-build-0123c5f56c20/output/aarch64-linux-gnu/SHA256SUMS.part
 336c4f647e5318d34119580377f7bb957fe4cc2009160712f14b04f5d6876386  guix-build-0123c5f56c20/output/aarch64-linux-gnu/bitcoin-0123c5f56c20-aarch64-linux-gnu-debug.tar.gz
 8f6d8197eec76f8bf20ad936dde15e06cfa5b6911092637982ae9f8c5dd93730  guix-build-0123c5f56c20/output/aarch64-linux-gnu/bitcoin-0123c5f56c20-aarch64-linux-gnu.tar.gz
 5605c92e1346948f63ef0ecc09508b58ac89b57b661ff58aa0f6962817ab3e6d  guix-build-0123c5f56c20/output/arm-linux-gnueabihf/SHA256SUMS.part
 c86d9258a2519868899dbf75bbbc5d4336a12dadeed9f79e1948e8a0d6e68dcd  guix-build-0123c5f56c20/output/arm-linux-gnueabihf/bitcoin-0123c5f56c20-arm-linux-gnueabihf-debug.tar.gz
 2369b55f28fd3c9db990796c1540afd2acd3f5a157b12153bcc896432028b212  guix-build-0123c5f56c20/output/arm-linux-gnueabihf/bitcoin-0123c5f56c20-arm-linux-gnueabihf.tar.gz
 0a4de960ad114661bdc71faaacfc0e7bfb594465b5904c1ab4aba4354331776e  guix-build-0123c5f56c20/output/arm64-apple-darwin/SHA256SUMS.part
 76dabdc770be5ae0b75344202dd781c26cf9115ed4abc69abf816f31de10e593  guix-build-0123c5f56c20/output/arm64-apple-darwin/bitcoin-0123c5f56c20-arm64-apple-darwin-codesigning.tar.gz
 b0776606da2d4a75a6533709cfb1c23dc502cc90cf92763136284461816daeda  guix-build-0123c5f56c20/output/arm64-apple-darwin/bitcoin-0123c5f56c20-arm64-apple-darwin-unsigned.tar.gz
 a5530924ac5e25172fa55b4f2467d43d0fc5b84306eef29344817164ab759dc5  guix-build-0123c5f56c20/output/arm64-apple-darwin/bitcoin-0123c5f56c20-arm64-apple-darwin-unsigned.zip
 43bb29d4abaa8f167cbbebe10ed035f3aaf90438cfd177e581d17b4cb402e29f  guix-build-0123c5f56c20/output/dist-archive/bitcoin-0123c5f56c20.tar.gz
 6e1401fac4062a9ff90634fdbae0f895ee1f8f87a779122a1f4a079e59de8ef7  guix-build-0123c5f56c20/output/powerpc64-linux-gnu/SHA256SUMS.part
 d0a81e59ed9020075d530332c8ec274fd0c03dc5e0259b32c82ff69e989aef5c  guix-build-0123c5f56c20/output/powerpc64-linux-gnu/bitcoin-0123c5f56c20-powerpc64-linux-gnu-debug.tar.gz
 1524d9a971a039abcb23b4d85a6b2bf9156307825f7bf3d22ed974915d7c4a8a  guix-build-0123c5f56c20/output/powerpc64-linux-gnu/bitcoin-0123c5f56c20-powerpc64-linux-gnu.tar.gz
 e42a87d62ed0bd70e8349e2e393e49ef8482bd783899ce6e2bfd1d07f5b42ebf  guix-build-0123c5f56c20/output/riscv64-linux-gnu/SHA256SUMS.part
 265d2d38885a0e9f81843359cd20dd77f06fe0b1195ace26e5cc3e99e5f96d7b  guix-build-0123c5f56c20/output/riscv64-linux-gnu/bitcoin-0123c5f56c20-riscv64-linux-gnu-debug.tar.gz
 e521c214f294b48623eac64b2b741e0a8f0e13bad8427e4e7dfae6983763872d  guix-build-0123c5f56c20/output/riscv64-linux-gnu/bitcoin-0123c5f56c20-riscv64-linux-gnu.tar.gz
 ea2ef9859ef3f195ae75470e8dd891f92277efafce51b2fd39ac7f3394baf50a  guix-build-0123c5f56c20/output/x86_64-apple-darwin/SHA256SUMS.part
 2a5c3121570160c83c5d73278714b966cd5259bbb87e0202f11347b01757de4c  guix-build-0123c5f56c20/output/x86_64-apple-darwin/bitcoin-0123c5f56c20-x86_64-apple-darwin-codesigning.tar.gz
 dbff6ceb495f8a0d57e852036bb61dded7bf9923664b1947c4ca3e786b6bd655  guix-build-0123c5f56c20/output/x86_64-apple-darwin/bitcoin-0123c5f56c20-x86_64-apple-darwin-unsigned.tar.gz
 d607087f3a2dbe36e69e64389c1032fd848f1d78c90ee614c2fa18080edf1eda  guix-build-0123c5f56c20/output/x86_64-apple-darwin/bitcoin-0123c5f56c20-x86_64-apple-darwin-unsigned.zip
 1a9eb49e09ff105f8aeb5d660aa7e93585c305527ffc382bc5a5820a02c80e4b  guix-build-0123c5f56c20/output/x86_64-linux-gnu/SHA256SUMS.part
 2e75b3573fb0e3f93a972fc62ac2a8e783aeee3ab0358f63abd371280b180be1  guix-build-0123c5f56c20/output/x86_64-linux-gnu/bitcoin-0123c5f56c20-x86_64-linux-gnu-debug.tar.gz
 cd5dce2de56f9739019d04ff2361c3fc52ddd2ca13f020cc50e23fcc7b3ebe92  guix-build-0123c5f56c20/output/x86_64-linux-gnu/bitcoin-0123c5f56c20-x86_64-linux-gnu.tar.gz
 a47d2033156be5ff1e1aeba1406685a2f82ea5b10ea085e66667ac7db5e87a0a  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/SHA256SUMS.part
 851a7e608507c5c0db7d9d9a7189aae62624eb7e65c3b0de60cccdbe1e422a40  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-codesigning.tar.gz
 e0e922ac6f6d62e9622e2e8241d487c370e3587177dbfa442e8231075c66659d  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-debug.zip
 eaadc3fafd5fee285063ec7ef2eb35acdef51c5340120cf05909b1339829b59b  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-setup-unsigned.exe
 015914432fbafda4852591948fc08a018aebcd81c7f01325128b7adeaad6956b  guix-build-0123c5f56c20/output/x86_64-w64-mingw32/bitcoin-0123c5f56c20-win64-unsigned.zip

hebasto
hebasto reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no bugs are fixed and no new features are needed, perhaps we should do the opposite and wait until the Guix commit used for release builds is updated to include 0.16.6 as a package?

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 4, 2025

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File commit 1ed00a0
(master)		 commit 618d962b66afb9d4965d5b2585656bcd57f0fb30
(pull/33522/merge)
*-aarch64-linux-gnu-debug.tar.gz f652d2b4a99c10fb... 92e2aa3c5c718127...
*-aarch64-linux-gnu.tar.gz 7253b1b45c4bf927... 819cb2e6f9d680f4...
*-arm-linux-gnueabihf-debug.tar.gz b08d65cf393432fb... 77bdf855b8dacf39...
*-arm-linux-gnueabihf.tar.gz cfa2f37406a6c21b... 5a86f7a1cde00caf...
*-arm64-apple-darwin-codesigning.tar.gz b6c460fff7359f92... e322123457d87064...
*-arm64-apple-darwin-unsigned.tar.gz fa81438a0c0cabc7... b09553d0160e6cc9...
*-arm64-apple-darwin-unsigned.zip 97cc6c32dbf0c773... 7d8de19798e8879a...
*-powerpc64-linux-gnu-debug.tar.gz e16d19a46cb63056... 995ac7709d4523dc...
*-powerpc64-linux-gnu.tar.gz 2e3ed0f5ab2668ae... b15d591236fd4dde...
*-riscv64-linux-gnu-debug.tar.gz 3d7ff75c715f9615... 53e0f598bf4a004f...
*-riscv64-linux-gnu.tar.gz f62f501d74e3c1a7... b3626eb225b7b371...
*-x86_64-apple-darwin-codesigning.tar.gz aa36886ca35c784d... 04674cda6d163c64...
*-x86_64-apple-darwin-unsigned.tar.gz 5f45d902ade8dc16... e41eb24f91076221...
*-x86_64-apple-darwin-unsigned.zip 440b818e04a2473f... 01c3cfbcfc7e3331...
*-x86_64-linux-gnu-debug.tar.gz f985717d80ea092f... 88b9b4ba2fae0955...
*-x86_64-linux-gnu.tar.gz dd12f58006398e14... f59541d57cdcd38c...
*.tar.gz 8b784dc973055ded... 8f88f881fcb8e471...
SHA256SUMS.part 81b44c26d551a6b9... 48d0718c003c3a27...
guix_build.log fb9c62457b4c62fd... 3095d0700ccb5de3...
guix_build.log.diff 4d264aa5b71bf334...

@fanquake fanquake changed the title guix: use LIEF 0.17.0 guix: use LIEF 0.17.1 Oct 28, 2025
@fanquake fanquake force-pushed the lief_0_17_0 branch 2 times, most recently from c40f0e3 to 98a6d95 Compare December 8, 2025 11:18
@DrahtBot DrahtBot mentioned this pull request Dec 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hebasto hebasto hebasto left review comments

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fanquake @DrahtBot @janb84 @hebasto