Sanitize assert usage and refuse to compile with NDEBUG. #3344
Conversation
There were quite a few places where assert() was used with side effects, making operation with NDEBUG non-functional. This commit fixes all the cases I know about, but also adds an #error on NDEBUG because the code is untested without assertions and may still have vulnerabilities if used without assert.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9b59e3bda8c137bff885db5b1f9150346e36e076 for binaries and test log. |
|
ACK. Merging because it is obviously better. |
Sanitize assert usage and refuse to compile with NDEBUG.
3 participants
There were quite a few places where assert() was used with side effects,
making operation with NDEBUG non-functional. This commit fixes all the
cases I know about, but also adds an #error on NDEBUG because the code
is untested without assertions and may still have vulnerabilities if
used without assert.