[30.0] rc2 backports #33356
Merged
[30.0] rc2 backports #33356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during text selection by only setting plaintext mime data. Github-Pull: bitcoin-core/gui#886 Rebased-From: 6a371b7
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33356. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Rather than trying to match the apt installed clang version, which is prone to intermittent issues. i.e bitcoin#33345. Github-Pull: bitcoin#33364 Rebased-From: b736052
Github-Pull: bitcoin#33310 Rebased-From: 93a29ff
If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: e76c2f7
Instead of checking whether the total amount of inputs known by the wallet is greater than 0, we should be checking for whether the input is known by the wallet. This enables us to determine whether a transaction spends an of output with an amount of 0, which is necessary for marking 0-value dust outputs as spent. Github-Pull: bitcoin#33268 Rebased-From: 39a7dbd
Github-Pull: bitcoin#33268 Rebased-From: c40dc82
Github-Pull: bitcoin#33268 Rebased-From: 609d265
m_cached_from_me is used to track whether a transaction is "from me", i.e. has any inputs which belong to the wallet. This is held in memory only in the same way that a transaction's balances are. Github-Pull: bitcoin#33268 Rebased-From: 113a422
The `enable_language` command must be called in file scope, not in a function call. See: https://cmake.org/cmake/help/latest/command/enable_language.html Github-Pull: bitcoin#33379 Rebased-From: 9193c3e
added 2 commits
September 15, 2025 10:23
Github-Pull: bitcoin#33243 Rebased-From: facfde2
Github-Pull: bitcoin#33243 Rebased-From: fa96a4a
mzumsande pointed out bitcoin#32345 (comment) that this test was causing a warning: Warning: Disk space for "/tmp/test_common bitcoin/node_init_tests/init_test/bf78678cb7723a3e84b5/blocks" may not accommodate the block files. Approximately 810 GB of data will be stored in this directory. Fix by setting regtest instead of mainnet network before running the test. Github-Pull: bitcoin#33391 Rebased-From: bdf01c6
Co-Authored-By: Sjors Provoost <[email protected]> Github-Pull: bitcoin#33380 Rebased-From: 0a26731
Tor inbound connections do not reveal the peer's actual network address. Therefore do not apply whitelist permissions to them. Co-authored-by: Vasil Dimov <[email protected]> Github-Pull: bitcoin#33395 Rebased-From: f563ce9
Github-Pull: bitcoin#33407 Rebased-From: 7584a4f
darosior
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
secp256k1.cmake#33379bitcoinmanpage #33407