Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Sep 3, 2025

MarcoFalke and others added 2 commits September 3, 2025 16:14
Also, use update-alternatives to avoid having to manually specify
clang-${APT_LLVM_V} or llvm-symbolizer-${APT_LLVM_V} everywhere.

Github-Pull: bitcoin#32999
Rebased-From: fad040a
@DrahtBot
Copy link
Contributor

DrahtBot commented Sep 3, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33294.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK marcofleon

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

  • intrumentation -> instrumentation [spelling error in release notes list item making the word invalid]

drahtbot_id_5_m

Qt is disabled, as the build is now taking a very long time.

Github-Pull: bitcoin#33099
Rebased-From: b09af2c
Github-Pull: bitcoin#33258
Rebased-From: 4cf0ae4
@fanquake fanquake added this to the 29.2 milestone Sep 3, 2025
@DrahtBot DrahtBot removed the CI failed label Sep 3, 2025
@fanquake fanquake marked this pull request as ready for review September 4, 2025 08:54
@fanquake fanquake requested a review from willcl-ark September 4, 2025 12:57
@willcl-ark
Copy link
Member

Are you planning on adding these to release notes in this PR?

@fanquake
Copy link
Member Author

fanquake commented Sep 5, 2025

Are you planning on adding these to release notes in this PR?

Added a commit for that.

@fanquake fanquake requested a review from marcofleon September 8, 2025 14:01
Copy link
Contributor

@marcofleon marcofleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7c6be9a, looks okay to me

@fanquake fanquake merged commit a0e438b into bitcoin:29.x Sep 8, 2025
18 checks passed
@fanquake fanquake deleted the 29_ci_backports branch September 8, 2025 16:17
@glozow glozow mentioned this pull request Oct 9, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants