guix: Build for macOS using Clang only #32764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32764. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
|
My Guix build: |
fanquake
reviewed
Jun 19, 2025
Member
|
My Guix build matches @hebasto. No opinion on the change though. |
1 task
hebasto
force-pushed
the
250617-guix-libcxx
branch
from
4be8f47 to
9377153
Compare
fanquake
added a commit
that referenced
this pull request
Oct 28, 2025
…32266f1e6059e2 59c4898 guix: remove python-pydantic-core input from LIEF (fanquake) 9f2a692 guix: use Clang & LLVM 19 for macOS build (fanquake) 9570ddb guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2 (fanquake) 7b5cc27 guix: patch around riscv issue with newer (2.40+) binutils (fanquake) 91b5cba ci: use Debian Trixie for macOS cross job (fanquake) Pull request description: https://codeberg.org/guix/guix/commit/5cb84f2013c5b1e48a7d0e617032266f1e6059e2 isn't super recent, but it's enough to get access to some newer packages, such as LLVM 19, and avoids having to add any further work arounds for things that we know are fixed later (i.e nsis). Once things upstream have stabilized a bit more (the `core-updates` branch was fairly recently merged), we could look at bumping to something newer. Package updates: (base) glibc 2.35 -> 2.39 binutils 2.38 -> 2.41 diffutils 3.8 -> 3.10 gawk 5.2.1 -> 5.3.0 git-minimal 2.45.2 -> 2.46.0 grep 3.8 -> 3.11 gzip 1.12 -> 1.13 linux-headers 6.1.106 -> 6.1.119 make 4.3 -> 4.4.1 xz 5.2.8 -> 5.4.5 CMake 3.30 becomes available. Clang/LLVM 19 becomes available. Could be used for #32764. ACKs for top commit: hebasto: re-ACK 59c4898. willcl-ark: ACK 59c4898 Tree-SHA512: c44965d5a315e4c862f5e40d8e98c645713405fec72a61055f95b6c68b7d2dcc69a61a084e397a4556d4c1df18f1cfa7a905234643fe4a7df9c58d486e26c097
hebasto
force-pushed
the
250617-guix-libcxx
branch
from
9377153 to
ced5091
Compare
Member
Author
|
Rebased to resolve a conflict with the merged #33185. |
hebasto
force-pushed
the
250617-guix-libcxx
branch
from
ced5091 to
7c97bae
Compare
Member
Author
|
My Guix build: UPD. Same hashes on |
fanquake
reviewed
Oct 29, 2025
| (("^install-others =.*$") | ||
| (string-append "install-others = " out "/etc/rpc\n"))))))))))))) | ||
|
|
||
| ;; This can be dropped after commit 2877c75dc5db0dbf664fb6170d5754068e941d91. |
Member
There was a problem hiding this comment.
This can be dropped after commit 2877c75dc5db0dbf664fb6170d5754068e941d91.
Would be good for this to explain why (is libunwind causing build issues?). Could also mention that this is copy-pasted from Guix, and I assume the intention isn't to change it here, if we plan on dropping it?
fanquake
reviewed
Oct 29, 2025
| export GUIX_LD_WRAPPER_DISABLE_RPATH=yes | ||
| case "$HOST" in | ||
| *darwin*) | ||
| # The auto-rpath behavior is necessary for darwin builds as some native |
Member
There was a problem hiding this comment.
as some native tools
If we are re-introducing this, I think we can be explicit about which tools. Can we just build them statically to not need to do this?
Member
|
Member
|
Looks like this still using the GNU binutils for building native tools. |
This was referenced Nov 4, 2025
hebasto
force-pushed
the
250617-guix-libcxx
branch
from
7c97bae to
3332d59
Compare
Member
Author
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes macOS builds Clang-only by switching the build compiler in depends to
clang+libc++.See: #30206.