rpc: Add optional peer_ids param to filter getpeerinfo #32741

waketraindev · 2025-06-12T21:51:05Z

Adds an optional peer_ids parameter to getpeerinfo to filter results by peer IDs.

This is useful when using bitcoin-cli or the console to inspect specific peers referenced in debug.log.

DrahtBot · 2025-06-12T21:51:09Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32741.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	danielabrozzoni, rkrux

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34004 (Implementation of SwiftSync by rustaceanrob)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

Also, missing tests?

src/rpc/net.cpp

0xB10C · 2025-06-13T09:17:58Z

I'm frequently using something like bitcoin-cli getpeerinfo | jq '[.[] | select(.id == 24430)]' for this. Doesn't work in the GUI console though.

DrahtBot · 2025-06-13T13:22:00Z

🚧 At least one of the CI tasks failed.
_{Task lint: https://github.com/bitcoin/bitcoin/runs/44049534572}
_{LLM reason (✨ experimental): The CI failure is caused by lint errors, specifically a trailing whitespace issue detected during the lint check.}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

test/functional/rpc_net.py

danielabrozzoni

Concept ACK, I think this is a good addition, as introducing a peer_id parameter to filter the getpeerinfo response is useful for debugging.

This needs a release note :)

src/rpc/net.cpp

rkrux

Concept ACK

Useful addition, I can see myself using the filtering here.

As mentioned in #32741 (review), a release note would be helpful as per this: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#release-notes

src/rpc/net.cpp

DrahtBot · 2025-07-04T12:42:25Z

🚧 At least one of the CI tasks failed.
_{Task lint: https://github.com/bitcoin/bitcoin/runs/45364101888}
_{LLM reason (✨ experimental): Lint check failed due to a coding style error in rpc_net.py caused by an unnecessary semicolon.}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

waketraindev · 2025-10-14T20:49:52Z

Rebased on current master.

rkrux

crACK 599628ab9c23cd53a30fcbcb5d4ac370bb536547

rkrux · 2025-10-21T07:58:00Z

test/functional/rpc_net.py

+        nonexistent_id = max(p["id"] for p in all_peers) + 1000
+        assert_equal(node.getpeerinfo(nonexistent_id), [])
+        assert_raises_rpc_error(-8, "must be a number or an array of numbers", node.getpeerinfo, {})
+


Nit if retouched:

diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py index 209e804021..47834c8375 100755 --- a/test/functional/rpc_net.py +++ b/test/functional/rpc_net.py @@ -200,6 +200,7 @@ class NetTest(BitcoinTestFramework): nonexistent_id = max(p["id"] for p in all_peers) + 1000 assert_equal(node.getpeerinfo(nonexistent_id), []) assert_raises_rpc_error(-8, "must be a number or an array of numbers", node.getpeerinfo, {}) + assert_equal(len(node.getpeerinfo([ids[0], nonexistent_id])), 1) no_version_peer.peer_disconnect() self.wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 2)

rkrux

ACK 8471074

maflcko · 2025-11-19T08:06:41Z

the commit message is wrong?

waketraindev · 2025-11-19T11:00:12Z

the commit message is wrong?

Thanks. Must've replaced it by mistake when I rebased. Fixed now

danielabrozzoni

tACK 9b6090d

I left a micro-nit, but I'd say avoid fixing it unless you already need to update, so you don't invalidate the ack :)

danielabrozzoni · 2025-12-11T18:06:57Z

src/rpc/net.cpp

-        "Returns data about each connected network peer as a json array of objects.",
-        {},
+        "Returns data about each connected network peer as a json array of objects.\n"
+        "Optionally filter by peer ids.\n",


nit if retouched: "peer IDs" (so it stays consistent with the rest of the help text)

rkrux

lgtm re-ACK 9b6090d

DrahtBot added the RPC/REST/ZMQ label Jun 12, 2025

maflcko reviewed Jun 13, 2025

View reviewed changes

src/rpc/net.cpp Outdated Show resolved Hide resolved

src/rpc/net.cpp Outdated Show resolved Hide resolved

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch from 6285d75 to 85f4703 Compare June 13, 2025 12:24

This comment was marked as off-topic.

Sign in to view

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch from f1f5c11 to 4705d4e Compare June 13, 2025 13:21

DrahtBot added the CI failed label Jun 13, 2025

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch 4 times, most recently from a53bd91 to 53c5ce9 Compare June 13, 2025 15:23

waketraindev requested a review from maflcko June 13, 2025 15:26

DrahtBot removed the CI failed label Jun 13, 2025

kevkevinpal reviewed Jun 15, 2025

View reviewed changes

test/functional/rpc_net.py Outdated Show resolved Hide resolved

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch from 53c5ce9 to af1c1df Compare June 15, 2025 23:21

This comment was marked as off-topic.

Sign in to view

danielabrozzoni reviewed Jun 24, 2025

View reviewed changes

DrahtBot mentioned this pull request Jun 24, 2025

wallet: add codex32 argument to addhdkey #32652

Closed

luke-jr reviewed Jun 30, 2025

View reviewed changes

src/rpc/net.cpp Outdated Show resolved Hide resolved

src/rpc/net.cpp Outdated Show resolved Hide resolved

rkrux reviewed Jul 3, 2025

View reviewed changes

src/rpc/net.cpp Outdated Show resolved Hide resolved

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch 2 times, most recently from 7550c6f to 9393b33 Compare July 4, 2025 12:41

DrahtBot added the CI failed label Jul 4, 2025

DrahtBot removed the CI failed label Jul 4, 2025

This comment was marked as off-topic.

Sign in to view

DrahtBot mentioned this pull request Jul 14, 2025

rpc,net: Add getpeerbyid and listpeersbyids RPCs #32972

Closed

waketraindev changed the title ~~rpc: add optional nodeid param to filter getpeerinfo~~ rpc: add optional peer_id param to filter getpeerinfo Jul 15, 2025

DrahtBot mentioned this pull request Sep 15, 2025

rpc: Handle -named argument parsing where '=' character is used #32821

Merged

waketraindev closed this Sep 24, 2025

0xB10C mentioned this pull request Sep 26, 2025

Ability to retrieve peer info by peer id #33478

Closed

waketraindev reopened this Oct 9, 2025

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch from 43857ab to 599628a Compare October 14, 2025 20:49

waketraindev requested review from danielabrozzoni, kevkevinpal, luke-jr and rkrux October 17, 2025 14:22

rkrux reviewed Oct 21, 2025

View reviewed changes

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch from 599628a to 8471074 Compare October 22, 2025 15:20

waketraindev requested a review from rkrux October 24, 2025 14:06

rkrux approved these changes Oct 25, 2025

View reviewed changes

waketraindev changed the title ~~rpc: add optional peer_ids param to filter getpeerinfo~~ rpc: Add optional peer_ids param to filter getpeerinfo Nov 3, 2025

DrahtBot added the Needs rebase label Nov 18, 2025

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch 3 times, most recently from 3e28ffb to e8764d8 Compare November 18, 2025 23:34

DrahtBot added CI failed and removed CI failed Needs rebase labels Nov 18, 2025

rpc: Add optional peer_ids param to filter getpeerinfo

9b6090d

waketraindev force-pushed the 2025-06-getpeerinfo-filterid branch from e8764d8 to 9b6090d Compare November 19, 2025 10:31

DrahtBot mentioned this pull request Dec 4, 2025

Implementation of SwiftSync #34004

Draft

danielabrozzoni reviewed Dec 11, 2025

View reviewed changes

DrahtBot requested a review from rkrux December 11, 2025 18:13

rkrux approved these changes Dec 17, 2025

View reviewed changes

rpc: Add optional peer_ids param to filter getpeerinfo #32741

Are you sure you want to change the base?

rpc: Add optional peer_ids param to filter getpeerinfo #32741

Conversation

waketraindev commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0xB10C commented Jun 13, 2025

Uh oh!

This comment was marked as off-topic.

DrahtBot commented Jun 13, 2025

Uh oh!

Uh oh!

This comment was marked as off-topic.

danielabrozzoni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rkrux left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DrahtBot commented Jul 4, 2025

Uh oh!

This comment was marked as off-topic.

waketraindev commented Oct 14, 2025

Uh oh!

rkrux left a comment

Choose a reason for hiding this comment

Uh oh!

rkrux Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

rkrux left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 19, 2025

Uh oh!

waketraindev commented Nov 19, 2025

Uh oh!

danielabrozzoni left a comment

Choose a reason for hiding this comment

Uh oh!

danielabrozzoni Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

rkrux left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

waketraindev commented Jun 12, 2025 •

edited

Loading

DrahtBot commented Jun 12, 2025 •

edited

Loading

rkrux left a comment •

edited

Loading