wallet: add codex32 argument to addhdkey #32652
Conversation
unused() descriptors do not have scriptPubKeys. Instead, the wallet uses them to store keys without having any scripts to watch for.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32652. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. LLM Linter (✨ experimental)Possible typos and grammar issues:
drahtbot_id_4_m |
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
|
Concept ACK-ish This is certainly better than the previous approach. |
roconnor-blockstream
force-pushed
the
codex32
branch
from
46b0e70 to
3335c14
Compare
In the next commit we will implement a new checksum, codex32, which uses the same encoding and HRP rules as bech32 and bech32m, but has a substantially different checksum verification procedure. To minimize duplicated code, we expose the character conversion in a new bech32::internals module.
roconnor-blockstream
force-pushed
the
codex32
branch
from
3335c14 to
b0d9b94
Compare
roconnor-blockstream
force-pushed
the
codex32
branch
from
b0d9b94 to
59777ef
Compare
|
Can you elaborate? |
|
I suppose NACK is a bit too strong. While codex32 itself is interesting, it is not interesting enough that any contributors to this project is interested in reviewing PRs including it. |
|
I still haven't gotten around to trying the paper booklet instructions. If and when I do that, I'll probably review this. But no idea when that is. |
From BIP-0093:
To encode some codex32 strings to import without the paper booklet there are libraries in Rust, Ruby and Python. |
7 participants
Rebase of #27351 onto #29136.
WIP
This PR introduces the ability to import BIP 93/codex32 master seeds with the
addhdkeycommand. It currently expects seeds to be provided in either as a single seed or as a list of shares which can be assembled via Shamir Secret Sharing.