Skip to content

Conversation

@AndreaLanfranchi
Copy link

Build process on WIndows creates the "out" folder by default which is not excluded from changes tracked by git.
Also additional directories .vs and .vscode are created with files exclusively relevant to the local development environment: commits should not be dirtied by those.

This PR

  • Excludes dirs used by VS family.
  • Also exclude "out" build directory (default on WIndows)

Exclude dirs used by VS family.
Also exclude "out" build directory (default on WIndows)
@DrahtBot
Copy link
Contributor

DrahtBot commented May 1, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32392.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@hebasto
Copy link
Member

hebasto commented May 1, 2025

We generally do not accept IDE-specific entries in the project’s .gitignore. Please adjust your build environment by other means.

@fanquake fanquake closed this May 1, 2025
@AndreaLanfranchi AndreaLanfranchi deleted the gitignore branch May 1, 2025 09:27
@laanwj
Copy link
Member

laanwj commented May 1, 2025

hebasto added a commit that referenced this pull request May 5, 2025
…cludes

fada115 doc: Explain that .gitignore is not for IDE-specific excludes (MarcoFalke)

Pull request description:

  This comes up frequently, so document it.

  Examples:

  * #27275
  * #21894
  * #32392
  * #17868

  ...

ACKs for top commit:
  l0rinc:
    ACK fada115
  hebasto:
    ACK fada115.
  janb84:
    ACK [fada115](fada115)

Tree-SHA512: 6fd1e48de54b40118a49ef61ad157fea278bba568286a022559a4815e53f26650db98a779a1ea2b3085237ded5cbee20d4c2dd1ef51e6a2d3d6085d7063f5309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants