[28.x] Backports #32299
[28.x] Backports #32299
Conversation
Github-Pull: bitcoin#32187 Rebased-From: fa69c42
From the GNU make 3.82 release announcement: * The 'define' make directive now allows a variable assignment operator after the variable name, to allow for simple, conditional, or appending multi-line variable assignment. macOS ships with 3.81. This caused the multiprocess config options to be ignored. Fixes bitcoin#32068 Co-authored-by: Ryan Ofsky <[email protected]> Github-Pull: bitcoin#32070 Rebased-From: 9157d9e
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32299. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This is required for the next commit. Github-Pull: bitcoin#32336 Rebased-From: fa0c1ba
fanquake
force-pushed
the
28_x_backports
branch
from
1dbb93a to
573460c
Compare
-BEGIN VERIFY SCRIPT-
ren() { sed --regexp-extended -i "s/$1/$2/g" $( git grep --extended-regexp -l "$1" ) ; }
ren 'cflags=\["-Wno-error=implicit-function-declaration"\]' 'cflags=bpf_cflags()'
-END VERIFY SCRIPT-
Github-Pull: bitcoin#32336
Rebased-From: facb9b3
fanquake
force-pushed
the
28_x_backports
branch
from
573460c to
a325ca3
Compare
There was a problem hiding this comment.
crACK a325ca34653872534529e7934d07fe4e2ca29cae
Backports all look clean to me.
Would only check that #32336 was left out of the release notes intentionally (it's not really "notable")?
Fixed that up. |
willcl-ark
left a comment
willcl-ark
left a comment
There was a problem hiding this comment.
ACK 812e637
Only changes to release note since previous ACK.
5 participants
Backports:
-Wduplicate-decl-specifierin bpfcc #32336