depends: patch Qt rounding bugs #32081
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32081. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
When compiled under -O0, this code was causing runtime failures in the 32-bit Clang gui wallet tests. Work around that by importing a commit from upstream: qt/qtbase@8c8b9a4.
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK 9ca76aa
Reviewed by comparing https://github.com/qt/qtbase/commit/8c8b9a4173f4add522ec13de85107deba7c82da0.patch and
https://github.com/fanquake/bitcoin/raw/refs/heads/fix_qt_32_O0/depends/patches/qt/normalize_round.patch and confirming they are effectively the same patch.
|
I guess this won't be needed after #30997 (assuming that it makes it in for the next release) |
I agree: |
|
Qt 6 should make it in, so wont bother with this. |
5 participants
When compiled under -O0, this code was causing runtime failures in the 32-bit Clang gui wallet tests. Work around that by importing a commit from upstream: qt/qtbase@8c8b9a4.
Can be recreated with:
Test failure output: https://gist.github.com/fanquake/16535691162170dc313b8f9f80988fa9.
Split from #29796.