-
Notifications
You must be signed in to change notification settings - Fork 38.6k
[29.x] bump to v29.0rc1 #32046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[29.x] bump to v29.0rc1 #32046
Conversation
glozow
commented
Mar 12, 2025
- "backport" build: bump CLIENT_VERSION_MAJOR to 29 #32041
- bump version to v29.0rc1
- generate manpages
- add example bitcoin.conf
- add release-notes.md pointing to wiki
Github-Pull: bitcoin#32041 Rebased-From: a3f0e9a
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32046. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 628e4f59b8784fcde2de176fb98260e71def18ec, I have reviewed the code and it looks OK.
Revoked. Man pages for |
628e4f5 to
868a757
Compare
|
Great, fixed. |
My apologies for not checking all stuff at once, but |
868a757 to
47e2fa8
Compare
|
Thanks @hebasto! |
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 47e2fa8.
|
It appears that
|
|
ACK 47e2fa8 Other than the issue with the example bitcoin.conf, everything seems correct. I think we can move forward with rc1 and just backport the gen-bitcoin-conf.sh fixes for rc2 (or final). The script has to be rerun for every rc anyways. |
|
ACK 47e2fa8 I'm ~0 on whether or not the release candidate should be held up by the example |
|
There's likely going to be more rcs than usual, so just getting this out for testing with the incomplete example .conf is fine. |