Skip to content

Conversation

@satscoffee
Copy link

doc: updated comments in line 1 from:

// Copyright (c) 2012-2022 The Bitcoin Core developers
to
// Copyright (c) 2012-2025 The Bitcoin Core developers

PR was for comment update only so no testing was performed.

Changed Line 1 comment from:
// Copyright (c) 2012-2022 The Bitcoin Core developers 
to
// Copyright (c) 2012-2025 The Bitcoin Core developers
doc: updated line 1 note to expand copyright from 2012-2025 instead of 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 11, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31642.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@fanquake fanquake closed this Jan 11, 2025
@satscoffee satscoffee deleted the Coypright-date-update branch January 11, 2025 16:33
fanquake added a commit that referenced this pull request Dec 19, 2025
fa4cb13 test: [doc] Manually unify stale headers (MarcoFalke)
fa5f297 scripted-diff: [doc] Unify stale copyright headers (MarcoFalke)

Pull request description:

  Historically, the upper year range in file headers was bumped manually
  or with a script.

  This has many issues:

  * The script is causing churn. See for example commit 306ccd4, or
    drive-by first-time contributions bumping them one-by-one. (A few from
    this year: #32008,
    #31642,
    #32963, ...)
  * Some, or likely most, upper year values were wrong. Reasons for
    incorrect dates could be code moves, cherry-picks, or simply bugs in
    the script.
  * The upper range is not needed for anything.
  * Anyone who wants to find the initial file creation date, or file
    history, can use `git log` or `git blame` to get more accurate
    results.
  * Many places are already using the `-present` suffix, with the meaning
    that the upper range is omitted.

  To fix all issues, this bumps the upper range of the copyright headers
  to `-present`.

  Further notes:

  * Obviously, the yearly 4-line bump commit for the build system (c.f.
    b537a2c) is fine and will remain.
  * For new code, the date range can be fully omitted, as it is done
    already by some developers. Obviously, developers are free to pick
    whatever style they want. One can list the commits for each style.
  * For example, to list all commits that use `-present`:
    `git log --format='%an (%ae) [%h: %s]' -S 'present The Bitcoin'`.
  * Alternatively, to list all commits that use no range at all:
    `git log --format='%an (%ae) [%h: %s]' -S '(c) The Bitcoin'`.

  <!--
  * The lower range can be wrong as well, so it could be omitted as well,
    but this is left for a follow-up. A previous attempt was in
    #26817.

ACKs for top commit:
  l0rinc:
    ACK fa4cb13
  rkrux:
    re-ACK fa4cb13
  janb84:
    ACK fa4cb13

Tree-SHA512: e5132781bdc4417d1e2922809b27ef4cf0abb37ffb68c65aab8a5391d3c917b61a18928ec2ec2c75ef5184cb79a5b8c8290d63e949220dbeab3bd2c0dfbdc4c5
@bitcoin bitcoin locked and limited conversation to collaborators Jan 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants