tests: Handle BDB dynamic pagesize #31222
Conversation
BDB may choose to use a pagesize other than 4096. As such, the parser should use the pagesize given by the BDB file.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31222. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| with open(filename, 'rb') as f: | ||
| data = f.read(PAGESIZE) | ||
| # Read the outer meta page for the page size. It will always be at least 512 bytes. | ||
| metadata = dump_meta_page(f.read(MIN_PAGESIZE)) |
There was a problem hiding this comment.
Might want to do some basic checks on the pagesize; eg
MIN_PAGESIZE = 512
MAX_PAGESIZE = 65536
⋮
assert pagesize >= MIN_PAGESIZE and pagesize <= MAX_PAGESIZE and (pagesize & (pagesize-1) == 0)
|
Concept ACK Note that a similar change is also included in #30125, but happy to rebase if this one goes in first. |
Oh, right, forgot about that PR. Closing in favor of it. |
4 participants
BDB may choose to use a pagesize other than 4096. As such, the parser should use the pagesize given by the BDB file.
Fixes #31210