Skip to content

Remove bsdmainutils from doc/ci #30749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 3 commits into from
Aug 29, 2024
Merged

Remove bsdmainutils from doc/ci #30749

fanquake merged 3 commits into from
Aug 29, 2024

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Aug 29, 2024

This was previously used to install hexdump (for the tests). However that isn't used by CMake. I'm not aware of any other tools from this package being used.

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 29, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto
hebasto approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously used to install hexdump (for the tests).

(via the bsdextrautils package, at least on Ubuntu 24.04)

ACK c462276e6eea70efb0dd3a486f50fb32a7934500.

@maflcko
Copy link
Member

maflcko commented Aug 29, 2024 

-- Checking for module 'libzmq>=4'
--   Package 'libzmq', required by 'virtual:world', not found
CMake Error at /usr/local/share/cmake-3.30/Modules/FindPkgConfig.cmake:645 (message):
  The following required packages were not found:

   - libzmq>=4

Call Stack (most recent call first):
  /usr/local/share/cmake-3.30/Modules/FindPkgConfig.cmake:873 (_pkg_check_modules_internal)
  CMakeLists.txt:150 (pkg_check_modules)


-- Configuring incomplete, errors occurred!

@fanquake
Copy link
Member Author

fanquake commented Aug 29, 2024

Yea, see my comment here: https://github.com/bitcoin/bitcoin/pull/30740/files#r1735920877. I will just add the proper dependency.

@fanquake fanquake mentioned this pull request Aug 29, 2024
Merged
@maflcko
Copy link
Member

maflcko commented Aug 29, 2024

ACK 78358ce

@DrahtBot DrahtBot requested a review from hebasto August 29, 2024 10:13
@maflcko maflcko added Bug and removed Bug labels Aug 29, 2024
hebasto
hebasto approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 78358ce.

@hebasto hebasto mentioned this pull request Aug 29, 2024
Merged
@fanquake
Copy link
Member Author

fanquake commented Aug 29, 2024

Going to merge this now, to prevent any further unrelated CI failures in other PRs.

@fanquake fanquake merged commit 5c7d4b9 into bitcoin:master Aug 29, 2024
@fanquake fanquake deleted the no_bsd_main_utils branch August 29, 2024 11:32
@Sjors
Copy link
Member

Sjors commented Aug 29, 2024

Just ran into this as well, thanks for the fix.

@fanquake fanquake mentioned this pull request Sep 3, 2024
Merged
@bitcoin bitcoin locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fanquake @DrahtBot @maflcko @Sjors @hebasto