Skip to content

Conversation

@glozow
Copy link
Member

@glozow glozow commented Aug 6, 2024

Followup to #30493. Update bips.md and policy/*.md to reflect new default rules around signaling requirements in RBF.
Also, log a warning when -mempoolfullrbf=0 that this config option is deprecated and will be removed in a future release.

@glozow glozow added the Docs label Aug 6, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 6, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK petertodd, tdb3, instagibbs

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30592 (Remove mempoolfullrbf by instagibbs)
  • #29520 (add -limitdummyscriptdatasize option by Retropex)
  • #29309 (Add a -permitbarepubkey option by vostrnad)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@petertodd
Copy link
Contributor

petertodd commented Aug 6, 2024

ACK 1f93e3c

@fanquake fanquake added this to the 28.0 milestone Aug 6, 2024
@glozow glozow changed the title docs: update documentation for new mempoolfullrbf default docs: doc update for mempoolfullrbf default + log deprecation Aug 6, 2024
@DrahtBot DrahtBot mentioned this pull request Aug 6, 2024
Copy link
Contributor

@tdb3 tdb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK

@DrahtBot DrahtBot requested a review from tdb3 August 7, 2024 07:41
@glozow glozow force-pushed the 2024-07-fullrbf-docs branch from ac6b8c3 to 1f93e3c Compare August 7, 2024 09:20
Copy link
Contributor

@tdb3 tdb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1f93e3c

@instagibbs
Copy link
Member

ACK 1f93e3c

@glozow glozow merged commit 676abd1 into bitcoin:master Aug 7, 2024
@glozow glozow deleted the 2024-07-fullrbf-docs branch August 7, 2024 13:52
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Feb 22, 2025
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 5, 2025
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jul 17, 2025
@bitcoin bitcoin locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants