Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 4, 2024

Small follow-up to commit 8e31cf9

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 4, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK dergoegge, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30385 ([WIP] p2p: send not_found msgs for unknown, pruned or unwilling to share blocks by furszy)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot changed the title net_processing: use existing RNG object in ProcessGetBlockData net_processing: use existing RNG object in ProcessGetBlockData Jul 4, 2024
@maflcko maflcko changed the title net_processing: use existing RNG object in ProcessGetBlockData refactor: use existing RNG object in ProcessGetBlockData Jul 4, 2024
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fa01c2af9eb91aebcdb87947145ba34b519bdfd8

There was some discussion on #29625 about reverting #28558 but this lgtm for now.

@maflcko
Copy link
Member Author

maflcko commented Jul 4, 2024

There was some discussion on #29625 about reverting #28558 but this lgtm for now.

Happy to drop it, if the reason still applies, but I couldn't find one.

@sipa
Copy link
Member

sipa commented Jul 5, 2024

It appears we can drop Shuffle entirely: #30396

@maflcko maflcko marked this pull request as draft July 5, 2024 14:57
@maflcko maflcko marked this pull request as ready for review July 5, 2024 14:58
@maflcko maflcko force-pushed the 2407-rand-fixups branch from fa01c2a to fa2e748 Compare July 5, 2024 14:59
@maflcko
Copy link
Member Author

maflcko commented Jul 5, 2024

Nice. Dropped that commit here.

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fa2e748

Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa2e748

@glozow glozow merged commit 79b8472 into bitcoin:master Jul 9, 2024
@maflcko maflcko deleted the 2407-rand-fixups branch July 9, 2024 13:46
@bitcoin bitcoin locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants