Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jun 5, 2024

Forgotten in #30198.
Addresses: #30198 (comment).

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 5, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Jun 5, 2024
Copy link
Contributor

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e6636ff

@fanquake fanquake merged commit bd642ee into bitcoin:master Jun 10, 2024
@fanquake fanquake deleted the doc_qt_5_15_14 branch June 10, 2024 09:51
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 2, 2024
Summary:
```
Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS.
```

Backport of [[bitcoin/bitcoin#30198 | core#30198]] and [[bitcoin/bitcoin#30227 | core#30227]].

Test Plan: Run the guix builds

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17265
roqqit pushed a commit to doged-io/doged that referenced this pull request Dec 19, 2024
Summary:
```
Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS.
```

Backport of [[bitcoin/bitcoin#30198 | core#30198]] and [[bitcoin/bitcoin#30227 | core#30227]].

Test Plan: Run the guix builds

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D17265
@bitcoin bitcoin locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants