[27.1] Finalize #30222
Merged
[27.1] Finalize #30222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#30216 Rebased-From: 3299abc
See: boostorg/boost-tasks#3 Github-Pull: bitcoin#30217 Rebased-From: ffbc173
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This was referenced Jun 4, 2024
Member
Agree. |
fanquake
force-pushed
the
27_1_rc2_or_rel
branch
from
69776cd to
d756a38
Compare
stickies-v
approved these changes
Jun 11, 2024
Contributor
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
ACK d756a38
I checked that:
- backports are clean and look correct
- manpages are identical to mine
- release notes are correct
willcl-ark
approved these changes
Jun 11, 2024
Member
willcl-ark
left a comment
willcl-ark
left a comment
There was a problem hiding this comment.
ACK d756a38
Version updates and manpages LGTM.
Also ran a scripted backport check to verify no unwarranted changes:
output
₿ bitcoin-diff-backports --base-branch="upstream/27.x"
1c1
< commit ffbc173ca1ed6b93de8bf3f88b8aed0743f4916c
---
> commit f2e05cd2a9bdc42fa45d284a5162f1f670d07ab6
7a8,10
>
> Github-Pull: #30217
> Rebased-From: ffbc173ca1ed6b93de8bf3f88b8aed0743f4916c
10c13
< index 7f0389b30d..938e9971ba 100644
---
> index ab43764b38..5e61036227 100644
18,20c21,23
< $(package)_file_name=boost_$(subst .,_,$($(package)_version)).tar.gz
< $(package)_sha256_hash=205666dea9f6a7cfed87c7a6dfbeb52a2c1b9de55712c9c1a87735d7181452b6
<
---
> $(package)_file_name=boost_$(subst .,_,$($(package)_version)).tar.bz2
> $(package)_sha256_hash=71feeed900fbccca04a3b4f2f84a7c217186f28a940ed8b7ed4725986baf99fa
> $(package)_patches=process_macos_sdk.patch
1c1
< commit 3299abce948f205bb1354993614b669189f9b89f
---
> commit ba359205421e2f765391a8330e8a61055acd87fc
5a6,8
>
> Github-Pull: #30216
> Rebased-From: 3299abce948f205bb1354993614b669189f9b89f
8c11
< index 62a82189c1..0cb3b185ad 100644
---
> index 9f9bdbbd0c..a8a52e3ca5 100644
11c14
< @@ -277,7 +277,7 @@ FUZZ_SUITE_LD_COMMON += $(LIBBITCOIN_ZMQ) $(ZMQ_LIBS)
---
> @@ -274,7 +274,7 @@ FUZZ_SUITE_LD_COMMON += $(LIBBITCOIN_ZMQ) $(ZMQ_LIBS)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
fuzzbinary on on SunOS / illumos #30216I don't think either of these changes warrants an
rc2cycle.