doc: Correct pull request prefix for scripts and tools #30150
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
willcl-ark
left a comment
willcl-ark
left a comment
There was a problem hiding this comment.
ACK fa3e115
I'm half tempted to bikeshed this to using tools, but this also seems totally fine to me :)
The bot will understand it, so you are free to use it. :) Edit: But I haven't seen anyone use it yet, so updating the docs can be done as a follow-up when people are using |
6 participants
scriptis confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f.CScriptinscript.h, or pull requests such as #27122 using the prefix).This could be fixed by renaming it to
scripts(with a pluralsat the end), however, looking at the current usagecontribandcliseem more common (#29687, #26953, #26584, #24864, #30074, #29433 ...)