rpc: Remove index-based Arg accessor #29997
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
|
Concept ACK |
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK fadb3eb57b4d207a678067b89caa45abf1f93702
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
ACK fadb3eb57b4d207a678067b89caa45abf1f93702
Can't think of any situations where index-based is preferable over key-based, so this seems like a nice cleanup.
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
Oops, left my nits on the wrong PR. Nothing blocking, only if you re-touch.
maflcko
force-pushed
the
2404-rpc-no-int-arg-
branch
from
fadb3eb to
fa3169b
Compare
|
re-ACK fa3169b, addressed doc nits |
|
ACK fa3169b |
6 participants
The index-based Arg accessor is redundant with the name-based one. It does not provide any benefit to the code reader, or otherwise, so remove it.