28950 followups #29722
28950 followups #29722
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
LGTM. Did you want to take #28950 (comment)? |
|
@glozow punting on that one, thanks |
instagibbs
force-pushed
the
2024-03-maxfee-followup
branch
from
cb0e681 to
cc2a4a6
Compare
|
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
test/txpackage_tests.cpp:821:103: error: argument name 'client_maxfeerate' in comment does not match parameter name 'client_max_feerate' [bugprone-argument-comment,-warnings-as-errors]
821 | package_rich_parent, /*test_accept=*/false, /*client_maxfeerate=*/{});
| ^~~~~~~~~~~~~~~~~~~~~~
| /*client_max_feerate=*/ |
There was a problem hiding this comment.
Approach ACK cc2a4a6b8ec2c01ef4eed464c5173255d2ff7497. First commit should probably be a scripted-diff though, and I think the last 2 commits make more sense when squashed?
LGTM. Did you want to take #28950 (comment)?
I think that's fine to leave as is, as per #28950 (comment)
instagibbs
force-pushed
the
2024-03-maxfee-followup
branch
3 times, most recently
from
a270bac to
e32fde0
Compare
-BEGIN VERIFY SCRIPT- git grep -l 'max_sane_feerate' | xargs sed -i 's/max_sane_feerate/client_maxfeerate/g' -END VERIFY SCRIPT-
instagibbs
force-pushed
the
2024-03-maxfee-followup
branch
from
e32fde0 to
7b29119
Compare
both done, thanks |
5 participants
Follow-ups to #28950