Skip to content

test: loading assumeutxo snapshot start states #29681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrandonOdiwuor wants to merge 2 commits into from
Closed

test: loading assumeutxo snapshot start states #29681

BrandonOdiwuor wants to merge 2 commits into from

Conversation

@BrandonOdiwuor
Copy link
Contributor

@BrandonOdiwuor BrandonOdiwuor commented Mar 20, 2024 •
edited
Loading

Fixes: #28648

Add assumeutxo test:

  • loading snapshot with current chain tip at snapshot_base_height
  • loading snapshot with current chain tip a descendant of snapshot block

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 20, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29996 (Assumeutxo: bugfix on loadtxoutset with a divergent chain + test by alfonsoromanz)
  • #29553 (assumeutxo: Add dumptxoutset height param, remove shell scripts by fjahr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@BrandonOdiwuor BrandonOdiwuor force-pushed the test_assumeutxo_snapshot_height branch 3 times, most recently from a2fdb5e to bd36ec3 Compare March 23, 2024 07:39
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 23, 2024

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/23007390361

@DrahtBot DrahtBot mentioned this pull request Mar 23, 2024
Merged
@BrandonOdiwuor BrandonOdiwuor changed the title test: loading assumeutxo snapshot with current chaintip at snapshot_base_height test: loading assumeutxo snapshot start states Mar 25, 2024
@maflcko
Copy link
Member

maflcko commented Apr 23, 2024

Are you still working on this?

@BrandonOdiwuor BrandonOdiwuor force-pushed the test_assumeutxo_snapshot_height branch from ec81c97 to e724b44 Compare April 24, 2024 07:14
@DrahtBot DrahtBot mentioned this pull request Apr 29, 2024
Merged
@DrahtBot DrahtBot mentioned this pull request May 23, 2024
Closed
@BrandonOdiwuor
Copy link
Contributor Author

BrandonOdiwuor commented Jul 8, 2024

Closing PR in favor of #30403

@BrandonOdiwuor BrandonOdiwuor mentioned this pull request Jul 8, 2024
Merged
@bitcoin bitcoin locked and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CI failed Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: Write assumeutxo tests

3 participants

@BrandonOdiwuor @DrahtBot @maflcko