contrib: list other binaries in manpage output #29585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Contributor
|
tACK 7c3ac59 master pr |
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Mar 14, 2024
Github-Pull: bitcoin#29585 Rebased-From: 7c3ac59
luke-jr
suggested changes
Mar 14, 2024
Member
luke-jr
left a comment
luke-jr
left a comment
There was a problem hiding this comment.
The manpage you're viewing shouldn't be listed in See Also...
Member
willcl-ark
approved these changes
Mar 21, 2024
Member
willcl-ark
left a comment
willcl-ark
left a comment
There was a problem hiding this comment.
ACK 7c3ac59
I don't see it as a big issue to list all related binaries in the bitcoin "ecosystem" in the SEE ALSO section myself.
laanwj
reviewed
Apr 24, 2024
Member
|
Good idea, concept ACK. |
laanwj
approved these changes
Apr 24, 2024
hebasto
added a commit
that referenced
this pull request
May 12, 2024
…ine, so don't add an extra one d1ed09a Bugfix: GUI: Help messages already have a trailing newline, so don't add an extra one (Luke Dashjr) Pull request description: Reviewing #29585, I noticed that `bitcoin-qt` adds an extra newline for `-help` and `-version` beyond the other binaries'. ACKs for top commit: hebasto: ACK d1ed09a, tested on Ubuntu 24.04. Tree-SHA512: 15ee9d1060c2492bb3b04a0ac4cb53f7b959bbe32bce415793da0c221f1c963c8f2bb3996ea07d1a7c192bfc2e23be2cd7d4e5649c592eb3fc03906c2763f1aa
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 26, 2024
…ng newline, so don't add an extra one d1ed09a Bugfix: GUI: Help messages already have a trailing newline, so don't add an extra one (Luke Dashjr) Pull request description: Reviewing bitcoin#29585, I noticed that `bitcoin-qt` adds an extra newline for `-help` and `-version` beyond the other binaries'. ACKs for top commit: hebasto: ACK d1ed09a, tested on Ubuntu 24.04. Tree-SHA512: 15ee9d1060c2492bb3b04a0ac4cb53f7b959bbe32bce415793da0c221f1c963c8f2bb3996ea07d1a7c192bfc2e23be2cd7d4e5649c592eb3fc03906c2763f1aa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
SEE ALSOsection to the manpages.Master:
This PR:
Should be enough to close #29558.