Skip to content

Conversation

@fanquake
Copy link
Member

b60d2b7334 Merge bitcoin-core/crc32c-subtree#6: Fix UBSan "misaligned-pointer-use" warning on aarch64
1ac401e32b Fix UBSan "misaligned-pointer-use" warning on aarch64

git-subtree-dir: src/crc32c
git-subtree-split: b60d2b733406cc64025095c6c2cb3933e222b529
@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 27, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, theuni, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359a8d9.

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359a8d9

Thanks :)

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359a8d9

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64)

File commit ba907f9
(master)
commit 4c12f153a26216d0ece3d69b05b1488b16374af1
(master and this pull)
SHA256SUMS.part b5eba8a283436c3b... 6014d3fa4f8be6f8...
*-aarch64-linux-gnu-debug.tar.gz 829c712d2b08d013... 7a7153a5a0fce29d...
*-aarch64-linux-gnu.tar.gz 419ac661f51e5b5a... a12a38cc665d4a10...
*-arm-linux-gnueabihf-debug.tar.gz 5663fee152088d6f... 55743c0631a15bf4...
*-arm-linux-gnueabihf.tar.gz 8d4e834d33f08496... cf5cfc37d93b7c68...
*-arm64-apple-darwin-unsigned.tar.gz 2b74ac81b62642f4... 42bfc2605bdf6d5c...
*-arm64-apple-darwin-unsigned.zip 3c4e78caeed83315... 3531417a72395582...
*-arm64-apple-darwin.tar.gz 876a77dd6de31080... c4b60438e0cdf687...
*-powerpc64-linux-gnu-debug.tar.gz 46ea102b47db3905... 305a03dc0b1d1ccc...
*-powerpc64-linux-gnu.tar.gz 2b3b9a798d909d80... 04a631fbcdc1e3ee...
*-powerpc64le-linux-gnu-debug.tar.gz b0c8e866e7f17f23... 9b4002aff4e4eddb...
*-powerpc64le-linux-gnu.tar.gz 9fa3773087c6550e... 4ce6ddf765710a2c...
*-riscv64-linux-gnu-debug.tar.gz 344064b382c4c6cc... 5450534e3d37235a...
*-riscv64-linux-gnu.tar.gz 870c4ffefb4eeb78... 1518d6b30e06f9ea...
*-x86_64-apple-darwin-unsigned.tar.gz 94d1d92ffd669c37... 7acb6c8ab528e547...
*-x86_64-apple-darwin-unsigned.zip 735ada59d43cbc8d... be2158f92725655a...
*-x86_64-apple-darwin.tar.gz dc837a3576093024... b56f197f441c5aaa...
*-x86_64-linux-gnu-debug.tar.gz f6cc9e3e9a625706... ab7b2ba978490eb0...
*-x86_64-linux-gnu.tar.gz 365e71ff601e95fa... 6094d4261e48d070...
*.tar.gz 43ffebf97a4c5fc5... fa0552e56a65caba...
guix_build.log b98357662408e8ef... 31a470d6933b7964...
guix_build.log.diff 3de41002fef3032d...

@theuni
Copy link
Member

theuni commented Feb 28, 2024

c-i failure appears unrelated.

@fanquake fanquake merged commit d752831 into bitcoin:master Feb 28, 2024
@fanquake fanquake deleted the update_crc32_subtree branch February 28, 2024 22:23
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 24, 2024
5d45552 Squashed 'src/crc32c/' changes from 0bac72c455..b60d2b7334 (fanquake)

Pull request description:

  Update the crc32c subtree. Includes:
  * bitcoin-core/crc32c-subtree#6

  Which fixes bitcoin#29178.

ACKs for top commit:
  hebasto:
    ACK 359a8d9.
  theuni:
    ACK 359a8d9
  dergoegge:
    ACK 359a8d9

Tree-SHA512: 2cec81a34ad26bbbc298aea5daffa41e56114d31cc2eb5fe486f46a77c3467bba22bdeca1c52ae97220e119d98818304272fc6337442af55282accabcd4c5833
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Oct 24, 2024
b70e091 Merge bitcoin#29667: fuzz: actually test garbage >64b in p2p transport test (fanquake)
6d7aa3d Merge bitcoin#29497: test: simplify test_runner.py (fanquake)
d0e15d5 Merge bitcoin#29606: refactor: Reserve memory for ToLower/ToUpper conversions (Ava Chow)
045fa5f Merge bitcoin#29514: tests: Provide more helpful assert_equal errors (Ava Chow)
bd607f0 Merge bitcoin#29393: i2p: log connection was refused due to arbitrary port (Ava Chow)
c961755 Merge bitcoin#29595: doc: Wrap flags with code in developer-notes.md (fanquake)
8d6e5e7 Merge bitcoin#29583: fuzz: Apply fuzz env (suppressions, etc.) when fetching harness list (fanquake)
4dce690 Merge bitcoin#29576: Update functional test runner to return error code when no tests are found to run (fanquake)
910a7d6 Merge bitcoin#29529: fuzz: restrict fopencookie usage to Linux & FreeBSD (fanquake)
fdac2b3 Merge bitcoin#29493: subtree: update crc32c subtree (fanquake)
a23b342 Merge bitcoin#29475: doc: Fix Broken Links (fanquake)
92bad90 Merge bitcoin#28178: fuzz: Generate with random libFuzzer settings (fanquake)
9b6a05d Merge bitcoin#29443: depends: fix BDB compilation on OpenBSD (fanquake)
9963e6b Merge bitcoin#29413: fuzz: increase length of string used for `NetWhitelist{bind}Permissions::TryParse` (fanquake)
3914745 Merge bitcoin#29425: test: fix intermittent failure in wallet_reorgrestore.py (fanquake)
b719883 Merge bitcoin#29399: test: Fix utxo set hash serialisation signedness (fanquake)
f096880 Merge bitcoin#29377: test: Add makefile target for running unit tests (Ava Chow)
03e0bd3 Merge bitcoin#27319: addrman, refactor: improve stochastic test in `AddSingle` (Ava Chow)

Pull request description:

  ## Issue being fixed or feature implemented
  Batch of trivial backports

  ## What was done?
  See commits

  ## How Has This Been Tested?
  built locally; large combined merge passed tests locally

  ## Breaking Changes
  Should be none

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK b70e091
  knst:
    utACK b70e091

Tree-SHA512: 659a931f812c8a92cf3854abb873d92885219a392d6aa8e49ac4b27fe41e8e163ef9a135050e7c2e1bd33cecd2f7dae215e05a9c29f62e837e0057d3c16746d6
@bitcoin bitcoin locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ubsan: misaligned-pointer-use in crc32c/src/crc32c_arm64.cc

5 participants