Skip to content

fuzz: txorphan check wtxids using GenTxid::Wtxid not GenTxid::Txid #28997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Dec 5, 2023
Merged

fuzz: txorphan check wtxids using GenTxid::Wtxid not GenTxid::Txid #28997

fanquake merged 1 commit into from
Dec 5, 2023

Conversation

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Dec 4, 2023

Fixes the bugs in the fuzz test with no more changes as an alternative to #28658

@instagibbs instagibbs marked this pull request as ready for review December 4, 2023 19:46
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 4, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK naumenkogs, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Dec 4, 2023
@instagibbs instagibbs mentioned this pull request Dec 4, 2023
Closed
@fanquake fanquake requested a review from dergoegge December 4, 2023 22:11
@naumenkogs
Copy link
Contributor

naumenkogs commented Dec 5, 2023

ACK 38816ff

dergoegge
dergoegge approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 38816ff

@fanquake fanquake merged commit b3ab0c3 into bitcoin:master Dec 5, 2023
@maflcko
Copy link
Member

maflcko commented Dec 5, 2023

Fixes the bugs in the fuzz test with no more changes as an alternative to #28658

Can you explain the "bugs"? The wtxid is equal to the txid for transactions that have not witness data, and all transactions in this test have no witness data.

Seems fine to fix the style and make this refactor, but I don't see any bugs.

Also, if there was a bug, the test should be fixed to catch it, no?

@bitcoin bitcoin locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dergoegge dergoegge dergoegge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@instagibbs @DrahtBot @naumenkogs @maflcko @dergoegge @fanquake