ci: Reduce use of bash -c #28954
ci: Reduce use of bash -c #28954
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2311-ci-
branch
2 times, most recently
from
fa63d7d to
fa0e499
Compare
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
ACK fad0165de85e1c0a39e511a619e9efcee69ac581 modulo the removal of the now stale reference to TEST_RUNNER_ENV.
It is confusing to treat commands as a single string. This change is also required to support paths and strings with spaces in them in the future. This requires replacing TEST_RUNNER_ENV with a global export, because it no longer works. See: ```bash $ export ENV="A=1" && $ENV ls bash: A=1: command not found... ``` Or in the CI task: + DIR_UNIT_TEST_DATA=/ci_container_base/ci/scratch/qa-assets/unit_test_data/ + LD_LIBRARY_PATH=/ci_container_base/depends/i686-pc-linux-gnu/lib + BITCOIND=bitcoin-node make -j10 check VERBOSE=1 /ci_container_base/ci/test/03_test_script.sh: line 166: BITCOIND=bitcoin-node: command not found https://github.com/bitcoin/bitcoin/pull/28954/checks?check_run_id=19096858944 https://cirrus-ci.com/task/6718317604372480
|
force pushed to remove a leftover stale |
|
utACK fad82fe |
5 participants
It is confusing to treat commands as a single string. This change is
also required to support paths and strings with spaces in them in the
future.