ci: Drop no longer needed "Fix Visual Studio installation" step #28796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying issue has been fixed in the image version 20231029.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
lgtm ACK 5bd1b8d |
hebasto
added a commit
to bitcoin-core/gui
that referenced
this pull request
Nov 21, 2023
…n't handle 91d5bd8 ci: Avoid toolset ambiguity that MSVC can't handle (Hennadii Stepanov) Pull request description: This PR introduces a workaround, which is similar to the one removed in bitcoin/bitcoin#28796, required to work with the new windows-2022 image version [20231115](https://github.com/actions/runner-images/blob/win22/20231115.2/images/windows/toolsets/toolset-2022.json) properly. Tested on the following image versions: - [20231029.1.0](https://github.com/hebasto/bitcoin/actions/runs/6904313692/job/18784722567) - [20231115.2.0](https://github.com/hebasto/bitcoin/actions/runs/6905808606/job/18789398318) Fixes bitcoin/bitcoin#28901. ACKs for top commit: maflcko: lgtm ACK 91d5bd8 , assuming it fixes the CI failures TheCharlatan: utACK 91d5bd8 pablomartin4btc: utACK 91d5bd8 Tree-SHA512: 13c325a24e09cdaa26b04a1c8c9968fe3525d1c0c887d42739c51fdb62c184667367cf56d0e7f64ff616b1f62998f28197b95291164418bb29c576b3f738a6a7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue has been fixed in the image version 20231029.