Skip to content

Conversation

@BrandonOdiwuor
Copy link
Contributor

Fixes #28421, see #28195 (comment)

Remove feature_txindex_compatibility.py in V27, follow up to #28195 being merged which is included in v26

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 30, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, theStack, stickies-v

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28052 (blockstorage: XOR blocksdir *.dat files by maflcko)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Oct 30, 2023

I think you can remove the [27.x] prefix. Branch-off has already happened, so this should be clear.

@BrandonOdiwuor BrandonOdiwuor changed the title [27.x] test: Remove feature_txindex_compatibility.py in V27 test: Remove feature_txindex_compatibility.py in V27 Oct 30, 2023
@DrahtBot DrahtBot added the Tests label Oct 30, 2023
@BrandonOdiwuor BrandonOdiwuor force-pushed the remove_feature_txindex_compatibility_py branch from 720819e to 897d6dd Compare October 30, 2023 10:35
@fanquake fanquake changed the title test: Remove feature_txindex_compatibility.py in V27 test: Remove feature_txindex_compatibility.py Oct 30, 2023
@maflcko
Copy link
Member

maflcko commented Oct 30, 2023

lgtm ACK 897d6dd

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 897d6dd

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 897d6dd

@fanquake fanquake merged commit a3670b2 into bitcoin:master Oct 30, 2023
@BrandonOdiwuor BrandonOdiwuor deleted the remove_feature_txindex_compatibility_py branch November 21, 2023 09:35
@bitcoin bitcoin locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Remove feature_txindex_compatibility.py in v27

6 participants