Skip to content

Conversation

@dergoegge
Copy link
Member

@dergoegge dergoegge commented Oct 20, 2023

closes #28665

The target is buggy and doesn't reach basic coverage.

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 20, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Oct 20, 2023
@glozow glozow added this to the 26.0 milestone Oct 20, 2023
@glozow glozow requested review from fanquake and maflcko October 20, 2023 13:16
@dergoegge
Copy link
Member Author

The lacking coverage was discussed before: #21387 (comment)

@maflcko
Copy link
Member

maflcko commented Oct 20, 2023

lgtm ACK dd4dcbd

Thanks for reminding me that I brought up the issue a long time ago already. Given that no one stepped up in the meantime to maintain it, it should be fine to remove for now. Once and if there is someone to maintain it, it is trivial to add it back in by reverting this commit, or otherwise.

@DrahtBot DrahtBot removed the request for review from maflcko October 20, 2023 13:37
Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dd4dcbd, agree it's better to delete this test until somebody wants to write a better one

@fanquake fanquake merged commit abfc8c9 into bitcoin:master Oct 20, 2023
Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Oct 21, 2023
dd4dcbd [fuzz] Delete i2p target (dergoegge)

Pull request description:

  closes bitcoin#28665

  The target is buggy and doesn't reach basic coverage.

ACKs for top commit:
  maflcko:
    lgtm ACK dd4dcbd
  glozow:
    ACK dd4dcbd, agree it's better to delete this test until somebody wants to write a better one

Tree-SHA512: b6ca6cad1773b1ceb6e5ac0fd501ea615f66507ef811745799deaaa4460f1700d96ae03cf55b740a96ed8cd2283b3d6738cd580ba97f2af619197d6c4414ca21
@bitcoin bitcoin locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'std::out_of_range' crash in I2P fuzz test

5 participants