Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Oct 12, 2023

Seems odd that this has to be done, but for now there are (unknown) size limits on the qa-assets repo. Also, a larger size means that cloning and iterating over the files takes a longer time.

Not sure how to measure the net impact of this, but with some backups reverting this commit, it can be limited on the downside?

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 12, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa190b

In the long run we should find a more scalable solution than a git repo for our corpora and re-enable this.

@dergoegge
Copy link
Member

Not sure how to measure the net impact of this, but with some backups reverting this commit, it can be limited on the downside?

I think oss-fuzz maintains an internal corpus that includes the use_value_profile feature inputs, so the downside (in terms of not finding bugs) should be pretty minimal.

@maflcko
Copy link
Member Author

maflcko commented Oct 12, 2023

The red CI task can be ignored.

@fanquake fanquake merged commit 151a2b1 into bitcoin:master Oct 13, 2023
@maflcko maflcko deleted the 2310-fuzz-less-value- branch October 13, 2023 08:30
Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Oct 13, 2023
faa190b test: Fuzz merge with -use_value_profile=0 for now (MarcoFalke)

Pull request description:

  Seems odd that this has to be done, but for now there are (unknown) size limits on the qa-assets repo. Also, a larger size means that cloning and iterating over the files takes a longer time.

  Not sure how to measure the net impact of this, but with some backups reverting this commit, it can be limited on the downside?

ACKs for top commit:
  dergoegge:
    ACK faa190b

Tree-SHA512: 9f8b3f4526f60e4ff6fca97859a725d145a8339c216bd15c92fad7e53f84308745fee47727527de459c0245ef9d474a9dc836fee599ab2b556b519bd900b9a33
@murchandamus
Copy link
Contributor

Post-merge ACK faa190b

@bitcoin bitcoin locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants