Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Oct 10, 2023

First new point release of zeromq in two and a half years. Mostly bug fixes; the project also completed a relicense to the "Mozilla Public License".

See https://github.com/zeromq/libzmq/releases/tag/v4.3.5.

@fanquake fanquake added this to the 27.0 milestone Oct 10, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 10, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member

hebasto commented Oct 10, 2023

Concept ACK.

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64)

File commit 106ab20
(master)
commit e970a2ad00873d5890ce6471ad51e03f828f078d
(master and this pull)
SHA256SUMS.part 08212b020581600a... 20362a1395d5e524...
*-aarch64-linux-gnu-debug.tar.gz 1e8363a272ca5f2c... 97628c61f09c396d...
*-aarch64-linux-gnu.tar.gz 85fb48931e7ba395... af2eac94828964d0...
*-arm-linux-gnueabihf-debug.tar.gz 5c98b2d8b9527a14... a95157aa7e2ac4a5...
*-arm-linux-gnueabihf.tar.gz b26de3d6ba43f39f... f36629ff862266dd...
*-arm64-apple-darwin-unsigned.tar.gz edf1426e90a784bf... ffc6242b625e5b9a...
*-arm64-apple-darwin-unsigned.zip 71d3f44112fbd882... 8a2676d98904f183...
*-arm64-apple-darwin.tar.gz 0c3d89e7adce2680... b82af9b08bba5b39...
*-powerpc64-linux-gnu-debug.tar.gz 0409d9d530f6a69c... be2c1241f35a8af8...
*-powerpc64-linux-gnu.tar.gz 7cc5074d3be3b6fe... eb997b76638304c8...
*-powerpc64le-linux-gnu-debug.tar.gz 57ba9a602522fa37... c4dbb4bc0bd75dea...
*-powerpc64le-linux-gnu.tar.gz 2c507ce5c2539044... 7295393ae0f3a2f8...
*-riscv64-linux-gnu-debug.tar.gz dadbc3593a2aa505... 3416a757b7009497...
*-riscv64-linux-gnu.tar.gz 0422520e335c22c9... a06e76129207bf0a...
*-x86_64-apple-darwin-unsigned.tar.gz 8cf9b7ffdee9350d... beca824f6dadb735...
*-x86_64-apple-darwin-unsigned.zip ad1eaadf37ed614e... a887a0d03b69ef93...
*-x86_64-apple-darwin.tar.gz 40c296121624ce1f... ecee9d5f0b72ee57...
*-x86_64-linux-gnu-debug.tar.gz 1a895f4bbefaf297... 1918a748eb5fb0fc...
*-x86_64-linux-gnu.tar.gz 9c21b09f854f2ac5... 7292f6838fe70a97...
*.tar.gz 970fa81568c2a0d7... c3359272ccc3f6ba...
guix_build.log 08ea935a0ba9f4ac... 12660adde2c61d17...
guix_build.log.diff bed6a804f8b3dd84...

@fanquake fanquake marked this pull request as ready for review October 24, 2023 11:11
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 986d7fe, I have reviewed the code and it looks OK.

@hebasto
Copy link
Member

hebasto commented Oct 24, 2023

My Guix builds:

x86_64
59b037743bf99c3e8bf4932ed61c595847daf3c88167b12e02b62ec0d28459b9  guix-build-986d7fed057b/output/aarch64-linux-gnu/SHA256SUMS.part
b7baef8a064db9da3743e671c8075826c3949c275a83f69d22e659d1e4d47326  guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu-debug.tar.gz
40c565876bdc15639b69c6bbb61ae7f7be00b3643f232ceea7023d1126ab15fe  guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu.tar.gz
fd63ef307a72332f279ea6b2c6f43826e6d2af7bef3b8db0eb55e20d2cbfcad7  guix-build-986d7fed057b/output/arm-linux-gnueabihf/SHA256SUMS.part
b58ff1c7adeb5a566b5aeeef005f225c8882d85f27a8195e5d5a8365b37d3cac  guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf-debug.tar.gz
2a431f280bd18e3fc873e70b3b8cd07e27089d2efac8a8083ef3604b64b453a7  guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf.tar.gz
ff7eebe52cf818a9bd97cc07d7f931e37daa5a3091c0b990b10ac1f767f5926e  guix-build-986d7fed057b/output/arm64-apple-darwin/SHA256SUMS.part
3119e3a0b031d6a45311c1532220bacd212716186c7bad263eb8b0076c215899  guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.tar.gz
f313f2db12eaa6d5284446f0c2f3af6c529c76574d743d4c033a326baa2095d9  guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.zip
79badcb4070b2b950eed2fac47e9745d52e9181d5dc4ae82e83ba567e787505d  guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin.tar.gz
6410960d0ddc494a95881672e1721140213d3290b2764dec35ceb419f629c2a6  guix-build-986d7fed057b/output/dist-archive/bitcoin-986d7fed057b.tar.gz
3aabb100d5a49af2fc00fbead3e4ff1166c008c2023eaa32257544c355f8bb99  guix-build-986d7fed057b/output/powerpc64-linux-gnu/SHA256SUMS.part
b45d94a09d5231a68f1300f6043b6ea3effc33fe0a177beb8f72eba73dd50191  guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu-debug.tar.gz
8369f5eaaf639c874a500099f7b29a8ad5c7ca1b6ea2fa3a3d946e4464d943ec  guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu.tar.gz
bd98c22bcb077c64802ac6a4fea8c125de3ad51fa059c6cc615961743764c4de  guix-build-986d7fed057b/output/powerpc64le-linux-gnu/SHA256SUMS.part
c4aa32f17d16b5ff11116887dc047fc198942be84431743b667d5e977b975e4c  guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu-debug.tar.gz
6b30377ef2d1996131595134e7b0a2894ca60e17e4e254bec2df8fb3738ac833  guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu.tar.gz
478fda56708f839699493a04b70833a59470d388d8227c2627a0c7ef52aee12a  guix-build-986d7fed057b/output/riscv64-linux-gnu/SHA256SUMS.part
b6fe8284ca15f9a14ce5326b30d1542a007c41ea0e4b0a7b1a81bb63f7002e89  guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu-debug.tar.gz
a11db5ba19c21ac662279595478f7ffe85eb9867d2c56b046c4717e434816d8e  guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu.tar.gz
698abf77725448f82310d0efd661422f39550d377edc565d6042d00a37bf798b  guix-build-986d7fed057b/output/x86_64-apple-darwin/SHA256SUMS.part
27cef1ea92865247cd0692c42228237903f58f14afc29abf0009ceb27e82e158  guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.tar.gz
0ddad23cc0562d8346463f8cb6a37faf8bde2b7a8570c2a41e07748e59deb13f  guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.zip
7bcd078a7eb15e439e931512421622d37cbec4395ba742f04f2594fd23624291  guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin.tar.gz
5ac508736ecaba1e7ccbc70b2728f798d9f31e30f860af7b39dd6ac18c4de2d6  guix-build-986d7fed057b/output/x86_64-linux-gnu/SHA256SUMS.part
25e7dd48f5b3a00d3318084d572737ec380168889dc455a9f6cdd6b5b39ccfbe  guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu-debug.tar.gz
ffb68a445586283bc874d77828cabedf0251565e8c9434ade7b62d7f5f52a4c6  guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu.tar.gz
b7028a690cd2f3534b6506e7c12742a80ab2ea371d2ec329ad82f2eedb457747  guix-build-986d7fed057b/output/x86_64-w64-mingw32/SHA256SUMS.part
aaf07cddfe55e8988b4854463f8dfb3d16e00502ab501f6e8f2a67091b630284  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-debug.zip
82ac6875462f819ff54e77a209062ca51ac4b07d85b518665b6f405864840519  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-setup-unsigned.exe
cde6c04506dda70a1f0cdef3a50186ecf82a7d0551f8c266f795f8883ae82307  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-unsigned.tar.gz
8a904f11110f66d741b3dae1cb6412b7fadc4f29b2d477453540dbd1729001a9  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64.zip

@fanquake fanquake requested a review from sedited October 24, 2023 16:32
@sedited
Copy link
Contributor

sedited commented Oct 24, 2023

Guix builds:

aarch64 and x86_64
59b037743bf99c3e8bf4932ed61c595847daf3c88167b12e02b62ec0d28459b9  guix-build-986d7fed057b/output/aarch64-linux-gnu/SHA256SUMS.part
b7baef8a064db9da3743e671c8075826c3949c275a83f69d22e659d1e4d47326  guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu-debug.tar.gz
40c565876bdc15639b69c6bbb61ae7f7be00b3643f232ceea7023d1126ab15fe  guix-build-986d7fed057b/output/aarch64-linux-gnu/bitcoin-986d7fed057b-aarch64-linux-gnu.tar.gz
fd63ef307a72332f279ea6b2c6f43826e6d2af7bef3b8db0eb55e20d2cbfcad7  guix-build-986d7fed057b/output/arm-linux-gnueabihf/SHA256SUMS.part
b58ff1c7adeb5a566b5aeeef005f225c8882d85f27a8195e5d5a8365b37d3cac  guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf-debug.tar.gz
2a431f280bd18e3fc873e70b3b8cd07e27089d2efac8a8083ef3604b64b453a7  guix-build-986d7fed057b/output/arm-linux-gnueabihf/bitcoin-986d7fed057b-arm-linux-gnueabihf.tar.gz
ff7eebe52cf818a9bd97cc07d7f931e37daa5a3091c0b990b10ac1f767f5926e  guix-build-986d7fed057b/output/arm64-apple-darwin/SHA256SUMS.part
3119e3a0b031d6a45311c1532220bacd212716186c7bad263eb8b0076c215899  guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.tar.gz
f313f2db12eaa6d5284446f0c2f3af6c529c76574d743d4c033a326baa2095d9  guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin-unsigned.zip
79badcb4070b2b950eed2fac47e9745d52e9181d5dc4ae82e83ba567e787505d  guix-build-986d7fed057b/output/arm64-apple-darwin/bitcoin-986d7fed057b-arm64-apple-darwin.tar.gz
6410960d0ddc494a95881672e1721140213d3290b2764dec35ceb419f629c2a6  guix-build-986d7fed057b/output/dist-archive/bitcoin-986d7fed057b.tar.gz
3aabb100d5a49af2fc00fbead3e4ff1166c008c2023eaa32257544c355f8bb99  guix-build-986d7fed057b/output/powerpc64-linux-gnu/SHA256SUMS.part
b45d94a09d5231a68f1300f6043b6ea3effc33fe0a177beb8f72eba73dd50191  guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu-debug.tar.gz
8369f5eaaf639c874a500099f7b29a8ad5c7ca1b6ea2fa3a3d946e4464d943ec  guix-build-986d7fed057b/output/powerpc64-linux-gnu/bitcoin-986d7fed057b-powerpc64-linux-gnu.tar.gz
bd98c22bcb077c64802ac6a4fea8c125de3ad51fa059c6cc615961743764c4de  guix-build-986d7fed057b/output/powerpc64le-linux-gnu/SHA256SUMS.part
c4aa32f17d16b5ff11116887dc047fc198942be84431743b667d5e977b975e4c  guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu-debug.tar.gz
6b30377ef2d1996131595134e7b0a2894ca60e17e4e254bec2df8fb3738ac833  guix-build-986d7fed057b/output/powerpc64le-linux-gnu/bitcoin-986d7fed057b-powerpc64le-linux-gnu.tar.gz
478fda56708f839699493a04b70833a59470d388d8227c2627a0c7ef52aee12a  guix-build-986d7fed057b/output/riscv64-linux-gnu/SHA256SUMS.part
b6fe8284ca15f9a14ce5326b30d1542a007c41ea0e4b0a7b1a81bb63f7002e89  guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu-debug.tar.gz
a11db5ba19c21ac662279595478f7ffe85eb9867d2c56b046c4717e434816d8e  guix-build-986d7fed057b/output/riscv64-linux-gnu/bitcoin-986d7fed057b-riscv64-linux-gnu.tar.gz
698abf77725448f82310d0efd661422f39550d377edc565d6042d00a37bf798b  guix-build-986d7fed057b/output/x86_64-apple-darwin/SHA256SUMS.part
27cef1ea92865247cd0692c42228237903f58f14afc29abf0009ceb27e82e158  guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.tar.gz
0ddad23cc0562d8346463f8cb6a37faf8bde2b7a8570c2a41e07748e59deb13f  guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin-unsigned.zip
7bcd078a7eb15e439e931512421622d37cbec4395ba742f04f2594fd23624291  guix-build-986d7fed057b/output/x86_64-apple-darwin/bitcoin-986d7fed057b-x86_64-apple-darwin.tar.gz
5ac508736ecaba1e7ccbc70b2728f798d9f31e30f860af7b39dd6ac18c4de2d6  guix-build-986d7fed057b/output/x86_64-linux-gnu/SHA256SUMS.part
25e7dd48f5b3a00d3318084d572737ec380168889dc455a9f6cdd6b5b39ccfbe  guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu-debug.tar.gz
ffb68a445586283bc874d77828cabedf0251565e8c9434ade7b62d7f5f52a4c6  guix-build-986d7fed057b/output/x86_64-linux-gnu/bitcoin-986d7fed057b-x86_64-linux-gnu.tar.gz
b7028a690cd2f3534b6506e7c12742a80ab2ea371d2ec329ad82f2eedb457747  guix-build-986d7fed057b/output/x86_64-w64-mingw32/SHA256SUMS.part
aaf07cddfe55e8988b4854463f8dfb3d16e00502ab501f6e8f2a67091b630284  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-debug.zip
82ac6875462f819ff54e77a209062ca51ac4b07d85b518665b6f405864840519  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-setup-unsigned.exe
cde6c04506dda70a1f0cdef3a50186ecf82a7d0551f8c266f795f8883ae82307  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64-unsigned.tar.gz
8a904f11110f66d741b3dae1cb6412b7fadc4f29b2d477453540dbd1729001a9  guix-build-986d7fed057b/output/x86_64-w64-mingw32/bitcoin-986d7fed057b-win64.zip

Copy link
Contributor

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 986d7fe

Independently verified the sha256sum.
Also checked that the now removed patch is indeed in the upstream.

@fanquake fanquake merged commit d53400e into bitcoin:master Oct 24, 2023
@fanquake fanquake deleted the zeromq_4_3_5 branch October 24, 2023 21:05
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 27, 2024
986d7fe depends: zeromq 4.3.5 (fanquake)

Pull request description:

  First new point release of zeromq in two and a half years. Mostly bug fixes; the project also completed a relicense to the "Mozilla Public License".

  See https://github.com/zeromq/libzmq/releases/tag/v4.3.5.

ACKs for top commit:
  hebasto:
    ACK 986d7fe, I have reviewed the code and it looks OK.
  TheCharlatan:
    ACK 986d7fe

Tree-SHA512: cdd6abfbbe10873c1ca267fed648c2e6ff17a4aff50c414924006e63fa39d501e803f8893a5cd966a2078b5c077f2578e482483e6723ea6f5760f16211d40998
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Sep 27, 2024
801c4fc build: followup to 29488 applied to gmp (pasta)
4b704a6 Merge bitcoin#28627: depends: zeromq 4.3.5 (fanquake)
0e6cb98 Merge bitcoin#26421: build: copy config.{guess,sub} post autogen in zmq package (fanquake)
cd33b69 Merge bitcoin#29488: depends: always configure with `--with-pic` (fanquake)
1b88674 Merge bitcoin#29287: depends: Do not override `CFLAGS` when building SQLite with `DEBUG=1` (fanquake)
f50fb6e Merge bitcoin#26998: depends: ensure we are appending to sqlite cflags (Andrew Chow)
25a594f Merge bitcoin#25987: build: compile depends sqlite with more recommended options (Andrew Chow)
d725c58 Merge bitcoin#27312: depends: qrencode 4.1.1 (fanquake)
482e5bb Merge bitcoin#27462: depends: fix compiling bdb with clang-16 on aarch64 (fanquake)
f0a53c9 Merge bitcoin#26994: depends: define `__BSD_VISIBLE` for FreeBSD bdb build (merge-script)
b1ac992 Merge bitcoin#26073: build: fix depends bdb compilation for BSDs (fanquake)
45e0f6e Merge bitcoin#25763: bdb: disable Werror for format-security (fanquake)

Pull request description:

  ## Issue being fixed or feature implemented
  First batch of PRs which lead towards cmake, focusing on having nothing or very little done out of order / with significant conflicts

  ## What was done?
  batch of 11 backports which lead towards cmake

  ## How Has This Been Tested?
  Built locally, seems to work, let's see CI

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 801c4fc
  knst:
    utACK  801c4fc

Tree-SHA512: b8b5299da9d82ab485ba5141ea12ba5c606f1a783b34c957d61e0a68d45865754fbc8bcbb0c5eabe3d410ff6262ce26789cf4a3af696905f7b7908e523c97816
@bitcoin bitcoin locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants