refactor: Use HashWriter over legacy CHashWriter #28341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
DrahtBot
changed the title
theuni
reviewed
Aug 25, 2023
sedited
approved these changes
Aug 28, 2023
Member
|
I'm not sure this improves much, unless we can actually get rid of That said, code review ACK 99995cf |
Member
Author
It is still used in |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 8, 2023
99995cf refactor: Use HashWriter over legacy CHashWriter (via SerializeHash) (MarcoFalke) 5555aa2 refactor: Use HashWriter over legacy CHashWriter (MarcoFalke) Pull request description: `HashWriter` is a slim and less confusing version of `CHashWriter`, so use it in all places where it compiles. This should be correct, if it compiles. ACKs for top commit: sipa: That said, code review ACK 99995cf theuni: ACK 99995cf TheCharlatan: ACK 99995cf Tree-SHA512: fc967a18379bd00bd334ac3d50beb5435b65ca66a48f72623f1dcdbbce3292fd91839160cd0e69b8f4f3d98e258dcbbc6f73f5e91345f938898ee39c903a442b
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 16, 2024
…ible Summary: ``` The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version. So do this here for HashWriter. CHashWriter remains in places where it is not yet possible. ``` Backport of [[bitcoin/bitcoin#25331 | core#25331]] and [[bitcoin/bitcoin#28341 | core#28341]]. Test Plan: ninja all check-extended Reviewers: #bitcoin_abc, roqqit, PiRK Reviewed By: #bitcoin_abc, roqqit, PiRK Subscribers: roqqit Differential Revision: https://reviews.bitcoinabc.org/D16472
roqqit
pushed a commit
to doged-io/doged
that referenced
this pull request
Aug 1, 2024
…ible Summary: ``` The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version. So do this here for HashWriter. CHashWriter remains in places where it is not yet possible. ``` Backport of [[bitcoin/bitcoin#25331 | core#25331]] and [[bitcoin/bitcoin#28341 | core#28341]]. Test Plan: ninja all check-extended Reviewers: #bitcoin_abc, roqqit, PiRK Reviewed By: #bitcoin_abc, roqqit, PiRK Subscribers: roqqit Differential Revision: https://reviews.bitcoinabc.org/D16472
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashWriteris a slim and less confusing version ofCHashWriter, so use it in all places where it compiles.This should be correct, if it compiles.