ci: Disable --coverage temporarily #28285
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Looks like CI is red since ecb2056, but on the pull, it passed last week: https://cirrus-ci.com/task/5524872076460032 |
There was a problem hiding this comment.
ACK based on green CI
Perhaps the following would be better instead, so test/functional/test_runner.py --coverage run locally (as well as in the CI) doesn't needlessly report missing coverage.
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index d93e6fd6da2..14e3a140485 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -847,7 +576,7 @@ class RPCCoverage():
all_cmds = set()
# Consider RPC generate covered, because it is overloaded in
# test_framework/test_node.py and not seen by the coverage check.
- covered_cmds = set({'generate'})
+ # Consider "Internal" to be covered due to the following issue until it is resolved:
+ # https://github.com/bitcoin/bitcoin/issues/27593
+ covered_cmds = set({'Internal', 'generate'})Edit: #28289 seems even better.
|
The root cause for the CI failures is silent merge conflict that should be fixed by #28289 (we might still disable |
4 participants
Looks like this causes all CI builds to be red, and doesn't work anyway, see #27593 . Temporarily disable it to allow for more time to rework it from scratch.