Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Aug 17, 2023

This PR ensures that only a single workflow processes any push or pull request at a time.

A new push will be queued (including the master branch).

For a new pull request update, the previous in-progress one will be cancelled.

Address #28187 (comment).

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 17, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK dergoegge
Concept ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@maflcko
Copy link
Member

maflcko commented Aug 17, 2023

Could do the same in the secp repo?

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0080b56

@hebasto
Copy link
Member Author

hebasto commented Aug 17, 2023

Could do the same in the secp repo?

Sure! Done in bitcoin-core/secp256k1#1403.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 17, 2023
… `github.ref` at a time

0080b56 ci: Ensure that only a single workflow processes `github.ref` at a time (Hennadii Stepanov)

Pull request description:

  This PR ensures that only a single workflow processes any push or pull request at a time.

  A new push will be queued (including the master branch).

  For a new pull request update, the previous in-progress one will be cancelled.

  Address bitcoin#28187 (comment).

ACKs for top commit:
  dergoegge:
    utACK 0080b56

Tree-SHA512: d03f1678c93c817c1c3be5e75171bfe85d494f99a9aab7113c9438e0c820e950edd5c10199cccd54868e6dc50217bb3aa5601b23bc88ad4927c001031e917513
fanquake added a commit to bitcoin-core/gui that referenced this pull request Aug 24, 2023
e7d67ef ci: Use concurrency for pull requests only (Hennadii Stepanov)

Pull request description:

  This PR is an amendment for bitcoin/bitcoin#28282.

  It avoids skipping builds when some pushes were done consequentially:

  ![image](https://github.com/bitcoin/bitcoin/assets/32963518/977e9ead-1856-4020-82eb-d16dbead5753)

  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency):

  > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.**

  No behavior change for pull requests:

  ![image](https://github.com/bitcoin/bitcoin/assets/32963518/4865ae04-fc42-4028-b91e-500c0b36bce6)

ACKs for top commit:
  MarcoFalke:
    review only ACK e7d67ef
  dergoegge:
    lgtm ACK e7d67ef

Tree-SHA512: 360be9dbb46354d988935643e8793ea630c3416609c45aab4c39075a00a427487446a34a4fb93b490ece43cabe43640fcc6fb2ac97760e2c6ee54b95241da826
Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Sep 8, 2023
e7d67ef ci: Use concurrency for pull requests only (Hennadii Stepanov)

Pull request description:

  This PR is an amendment for bitcoin#28282.

  It avoids skipping builds when some pushes were done consequentially:

  ![image](https://github.com/bitcoin/bitcoin/assets/32963518/977e9ead-1856-4020-82eb-d16dbead5753)

  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency):

  > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.**

  No behavior change for pull requests:

  ![image](https://github.com/bitcoin/bitcoin/assets/32963518/4865ae04-fc42-4028-b91e-500c0b36bce6)

ACKs for top commit:
  MarcoFalke:
    review only ACK e7d67ef
  dergoegge:
    lgtm ACK e7d67ef

Tree-SHA512: 360be9dbb46354d988935643e8793ea630c3416609c45aab4c39075a00a427487446a34a4fb93b490ece43cabe43640fcc6fb2ac97760e2c6ee54b95241da826
@bitcoin bitcoin locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants