-
Notifications
You must be signed in to change notification settings - Fork 38.7k
ci: Ensure that only a single workflow processes github.ref at a time
#28282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
87b4892 to
0080b56
Compare
|
Could do the same in the secp repo? |
dergoegge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 0080b56
Sure! Done in bitcoin-core/secp256k1#1403. |
… `github.ref` at a time 0080b56 ci: Ensure that only a single workflow processes `github.ref` at a time (Hennadii Stepanov) Pull request description: This PR ensures that only a single workflow processes any push or pull request at a time. A new push will be queued (including the master branch). For a new pull request update, the previous in-progress one will be cancelled. Address bitcoin#28187 (comment). ACKs for top commit: dergoegge: utACK 0080b56 Tree-SHA512: d03f1678c93c817c1c3be5e75171bfe85d494f99a9aab7113c9438e0c820e950edd5c10199cccd54868e6dc50217bb3aa5601b23bc88ad4927c001031e917513
e7d67ef ci: Use concurrency for pull requests only (Hennadii Stepanov) Pull request description: This PR is an amendment for bitcoin/bitcoin#28282. It avoids skipping builds when some pushes were done consequentially:  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency): > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.** No behavior change for pull requests:  ACKs for top commit: MarcoFalke: review only ACK e7d67ef dergoegge: lgtm ACK e7d67ef Tree-SHA512: 360be9dbb46354d988935643e8793ea630c3416609c45aab4c39075a00a427487446a34a4fb93b490ece43cabe43640fcc6fb2ac97760e2c6ee54b95241da826
e7d67ef ci: Use concurrency for pull requests only (Hennadii Stepanov) Pull request description: This PR is an amendment for bitcoin#28282. It avoids skipping builds when some pushes were done consequentially:  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency): > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.** No behavior change for pull requests:  ACKs for top commit: MarcoFalke: review only ACK e7d67ef dergoegge: lgtm ACK e7d67ef Tree-SHA512: 360be9dbb46354d988935643e8793ea630c3416609c45aab4c39075a00a427487446a34a4fb93b490ece43cabe43640fcc6fb2ac97760e2c6ee54b95241da826
This PR ensures that only a single workflow processes any push or pull request at a time.
A new push will be queued (including the master branch).
For a new pull request update, the previous in-progress one will be cancelled.
Address #28187 (comment).