Skip to content

ci: Refactor: Remove CI_USE_APT_INSTALL #28278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Aug 17, 2023
Merged

ci: Refactor: Remove CI_USE_APT_INSTALL #28278

fanquake merged 1 commit into from
Aug 17, 2023

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Aug 16, 2023 •
edited
Loading

Seems odd to use CI_USE_APT_INSTALL == no as an alias for CI_OS_NAME == macos. Fix this by removing the alias.

Also, for github CI:

  • restore MAKEJOBS to the same value as in cirrus.yml.
  • remove cirrus-only PACKAGE_MANAGER_INSTALL.
  • remove redundant TEST_RUNNER_TIMEOUT_FACTOR
  • Add M1 link

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 16, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Aug 16, 2023
@maflcko maflcko mentioned this pull request Aug 16, 2023
Merged
hebasto
hebasto approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa04623bbb284b35b27b2575b217341ab2e81e48.

Thank you!

@hebasto
Copy link
Member

hebasto commented Aug 17, 2023

Maybe also address the following comments:

in this PR?

hebasto
hebasto approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa26387.

nit: the commit message has lost some details.

@maflcko
Copy link
Member Author

maflcko commented Aug 17, 2023

nit: the commit message has lost some details.

I will copy-paste the pull request description if I have to push again

@fanquake fanquake merged commit 6ce5e8f into bitcoin:master Aug 17, 2023
@maflcko maflcko deleted the 2308-ci-cleanup- branch August 17, 2023 13:46
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 17, 2023
@fanquake
Merge bitcoin#28278: ci: Refactor: Remove CI_USE_APT_INSTALL
28bf821 
fa26387 ci: Refactor: Remove CI_USE_APT_INSTALL (MarcoFalke)

Pull request description:

  Seems odd to use `CI_USE_APT_INSTALL == no` as an alias for `CI_OS_NAME == macos`. Fix this by removing the alias.

  Also, for github CI:
  * restore MAKEJOBS to the same value as in cirrus.yml.
  * remove cirrus-only PACKAGE_MANAGER_INSTALL.
  * remove redundant TEST_RUNNER_TIMEOUT_FACTOR
  * Add M1 link

ACKs for top commit:
  hebasto:
    ACK fa26387.

Tree-SHA512: e235aa70abd60738a9ad1531284a94e2122c9c7a22c2514ede437b49da5c06b2597fba7fccf615541fb3adb4e1f8076aa8c6047f926393191a629713554ab000
@pinheadmz
Copy link
Member

pinheadmz commented Oct 3, 2023

M1 now available in GH actions: https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

@maflcko
Copy link
Member Author

maflcko commented Oct 3, 2023

M1 now available in GH actions: https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

It is commercial-only:

With today’s launch, our macOS larger runners will be priced at $0.16/minute for XL and $0.12/minute for large.

@bitcoin bitcoin locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

CI failed Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maflcko @DrahtBot @hebasto @pinheadmz @fanquake