doc, refactor: changing -torcontrol help to specify that a default port is used #28101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
kevkevinpal
changed the title
kevkevinpal
force-pushed
the
torcontrolHelp
branch
from
e2ecbce to
ea9da2f
Compare
kevkevinpal
force-pushed
the
torcontrolHelp
branch
2 times, most recently
from
9b21c23 to
e70ee8b
Compare
luke-jr
reviewed
Jul 27, 2023
kevkevinpal
force-pushed
the
torcontrolHelp
branch
from
e70ee8b to
61916d0
Compare
Contributor
Author
|
rebased to 5fa09d0 |
Member
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
jonatack
reviewed
Aug 17, 2023
jonatack
reviewed
Aug 17, 2023
kevkevinpal
force-pushed
the
torcontrolHelp
branch
from
5fa09d0 to
5d94b1f
Compare
Contributor
Author
rebased properly in 5d94b1f |
jonatack
reviewed
Aug 17, 2023
Member
|
Approach ACK modulo #28101 (comment) |
kevkevinpal
force-pushed
the
torcontrolHelp
branch
from
5d94b1f to
e5f20cb
Compare
jonatack
reviewed
Aug 17, 2023
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK e5f20cb26848c97d48c6a479c4680f6823f2ec1e
It might be good to prefix the pull title with doc, refactor: instead of init.
kevkevinpal
changed the title
…rt is used Right now when we get the help for -torcontrol it says that there is a default ip and port we dont specify if there is a specified ip that we would also use port 9051 as default
kevkevinpal
force-pushed
the
torcontrolHelp
branch
from
e5f20cb to
9a84200
Compare
Member
|
re-ACK 9a84200 |
Member
|
Anything more needed here? |
kristapsk
approved these changes
Sep 7, 2023
Member
|
ACK 9a84200 |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Sep 16, 2023
…rt is used Right now when we get the help for -torcontrol it says that there is a default ip and port we dont specify if there is a specified ip that we would also use port 9051 as default Github-Pull: bitcoin#28101 Rebased-From: 9a84200
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 19, 2023
…ify that a default port is used 9a84200 doc, refactor: Changing -torcontrol help to specify that a default port is used (kevkevin) Pull request description: Right now when we get the help for -torcontrol it says that there is a default ip and port we dont specify if there is a specified ip that we would also use port 9051 as default Also I create a new const instead of using 9051 directly in the function linking this PR because this was discussed here bitcoin#28018 ACKs for top commit: jonatack: re-ACK 9a84200 achow101: ACK 9a84200 MarnixCroes: utACK 9a84200 kristapsk: utACK 9a84200 Tree-SHA512: 21d9e65f3c280a2853a9cf60d4e93e8d72caccea106206d1862c19535bde7ea6ada7f55e6ea19a1fc0f59dbe791ec6fc4084fdbe7fa6d6991fa89c62070db637
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when we get the help for -torcontrol it says that there is a default ip and port we dont specify if there is a specified ip that we would also use port 9051 as default
Also I create a new const instead of using 9051 directly in the function
linking this PR because this was discussed here #28018