depends: xcb-proto 1.15.2 #28097
Merged
depends: xcb-proto 1.15.2 #28097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves build failures under Python 3.12, i.e building on rawhide: ```bash make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Contributor
|
Guix builds |
Member
|
Concept ACK. |
Contributor
Member
|
Guix builds: |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 19, 2023
7cb88c8 depends: xcb-proto 1.15.2 (fanquake) Pull request description: Resolves build failures with Python 3.12, i.e building on rawhide: ```bash make -C depends -j9 ... make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. Guix Build: ```bash 6d1725c9346bdf04e1eeec2deffda90957bd081700ba896834a143756410fb0e guix-build-7cb88c8b4672/output/aarch64-linux-gnu/SHA256SUMS.part 34486c39daea8a3ce8d92e9c1501f26e5f5e300d9612a25bd56c48ab56353329 guix-build-7cb88c8b4672/output/aarch64-linux-gnu/bitcoin-7cb88c8b4672-aarch64-linux-gnu-debug.tar.gz cb0080d75d0fc4fc5c7fc022b5771470c60609c35836e7b66c4f479a2edcd098 guix-build-7cb88c8b4672/output/aarch64-linux-gnu/bitcoin-7cb88c8b4672-aarch64-linux-gnu.tar.gz 395c332f83206125819aabf9a5dad5c906bdcd78ec13269fdfb4215bb5cc3247 guix-build-7cb88c8b4672/output/arm-linux-gnueabihf/SHA256SUMS.part f9e72693dd59f1b4dce6b6efa7bf325b2b589075a904c57b430dbe5c39add4ff guix-build-7cb88c8b4672/output/arm-linux-gnueabihf/bitcoin-7cb88c8b4672-arm-linux-gnueabihf-debug.tar.gz 14cfcebcd557d30d5a07837ab38ca217346f9b97e238a96376d6467d0db39e1a guix-build-7cb88c8b4672/output/arm-linux-gnueabihf/bitcoin-7cb88c8b4672-arm-linux-gnueabihf.tar.gz 1aaa7c04156a78628060a2ec47077589fb5dfb7a2e558fe604aaaa916b8a7f51 guix-build-7cb88c8b4672/output/arm64-apple-darwin/SHA256SUMS.part 94585898babc8fdce7660c3160fe7b26c6f6749ac53a177f91a8b4226856ab7b guix-build-7cb88c8b4672/output/arm64-apple-darwin/bitcoin-7cb88c8b4672-arm64-apple-darwin-unsigned.dmg 9bcc693e5fad668e6c7beb8280c9c3e6988318569e0efa7d24f8cd990a3c1dd4 guix-build-7cb88c8b4672/output/arm64-apple-darwin/bitcoin-7cb88c8b4672-arm64-apple-darwin-unsigned.tar.gz 3e427a7c2530cc3bb2f87125997bafa94234c21ebb7004cc36dc8408c0b0c9ff guix-build-7cb88c8b4672/output/arm64-apple-darwin/bitcoin-7cb88c8b4672-arm64-apple-darwin.tar.gz 988909c91077cb83b8d5ee77933192525d1fa1fd0bba0874138433314cb64927 guix-build-7cb88c8b4672/output/dist-archive/bitcoin-7cb88c8b4672.tar.gz b13c8b1f4f75505d2356f9e702db384dbb58ee3f7f0af3b110df4b7bc4c80f52 guix-build-7cb88c8b4672/output/powerpc64-linux-gnu/SHA256SUMS.part 6f2f204401c36ee59564c8d56f9adf4f2587471ea0705e0f6a89ade4a8decf55 guix-build-7cb88c8b4672/output/powerpc64-linux-gnu/bitcoin-7cb88c8b4672-powerpc64-linux-gnu-debug.tar.gz c1af63ec54fcbfd267a047d2dca41bdfcace1ae6a5746df11bd710217b17b205 guix-build-7cb88c8b4672/output/powerpc64-linux-gnu/bitcoin-7cb88c8b4672-powerpc64-linux-gnu.tar.gz 2407bc6d0beaa12dd7601ff14ef2c077346752a7b57fdf27df0a512f2af825bd guix-build-7cb88c8b4672/output/powerpc64le-linux-gnu/SHA256SUMS.part ff033b4b2a3c2816555ee3a443e4087cba47d4eb05b00e092603892ff91acc30 guix-build-7cb88c8b4672/output/powerpc64le-linux-gnu/bitcoin-7cb88c8b4672-powerpc64le-linux-gnu-debug.tar.gz ebd9c3ab462290e2c3264dd4184a1d132b90cc93d8359ae28bc23a120b918716 guix-build-7cb88c8b4672/output/powerpc64le-linux-gnu/bitcoin-7cb88c8b4672-powerpc64le-linux-gnu.tar.gz 57afcfe859903b960ef792447d34a17d556e44c98c021f5a35bfbd963f9e7be5 guix-build-7cb88c8b4672/output/riscv64-linux-gnu/SHA256SUMS.part 105e6ef4fbac91e1bbbea3e98c80915654894d247cbfe0e4d2ff89b633ace10e guix-build-7cb88c8b4672/output/riscv64-linux-gnu/bitcoin-7cb88c8b4672-riscv64-linux-gnu-debug.tar.gz e893e321ddd966c29fa949c3d7866fd0dca6ea87f9185e702a17c62896acf90b guix-build-7cb88c8b4672/output/riscv64-linux-gnu/bitcoin-7cb88c8b4672-riscv64-linux-gnu.tar.gz 80e7610cdb2ea9f1a503fa7c9ac7e29600e98fdac020951a76525494822416d9 guix-build-7cb88c8b4672/output/x86_64-apple-darwin/SHA256SUMS.part 8fe050ca40af1d2830f7efe928f8ea8e30800dfa286f5d22549255d7ed893a30 guix-build-7cb88c8b4672/output/x86_64-apple-darwin/bitcoin-7cb88c8b4672-x86_64-apple-darwin-unsigned.dmg 51a06c78edb9b29008deab11f5e98acac04de64080804d22b5a4f30c4b195ee5 guix-build-7cb88c8b4672/output/x86_64-apple-darwin/bitcoin-7cb88c8b4672-x86_64-apple-darwin-unsigned.tar.gz 5cb44b69b2315fd2bb4122fa252158a9460269f24121226d88f6146e52aafc5b guix-build-7cb88c8b4672/output/x86_64-apple-darwin/bitcoin-7cb88c8b4672-x86_64-apple-darwin.tar.gz d57f8ad1041a8112b012472ff00593a214f55215a29c5e5c3bc724d5eb645b1e guix-build-7cb88c8b4672/output/x86_64-linux-gnu/SHA256SUMS.part 76f1865d49cedf4b03f9ac5c4cb968968e54f8b19e96391340d82669a9395e93 guix-build-7cb88c8b4672/output/x86_64-linux-gnu/bitcoin-7cb88c8b4672-x86_64-linux-gnu-debug.tar.gz 63cca6f0cbfd74148b20093bc2494b9abf50594cfb7055c5b5d702583d6c37a4 guix-build-7cb88c8b4672/output/x86_64-linux-gnu/bitcoin-7cb88c8b4672-x86_64-linux-gnu.tar.gz 8d2afd4156525bc4684271092b5017e12f01fcc3dad29608886d10c0ef01b09d guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/SHA256SUMS.part 6ebb038dc1f589bf92bcf3766dfcb0310f7df9ff4f75c943c2eb6fcced1a2580 guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64-debug.zip d73aad8495174a49dad172278fbe590b86104bca9fcec8301a548a9fc8b1118f guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64-setup-unsigned.exe 7697fffdb9b2c2f0c6042f56daf9940c561ed4c950692a2adbb039ecd885e047 guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64-unsigned.tar.gz 4483876d0e5709b25bd2e238958a820f7996eaebe21c1c3f3a8c3f490a0c8562 guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64.zip ``` ACKs for top commit: hebasto: ACK 7cb88c8, tested on Ubuntu Mantic with: Tree-SHA512: 7e01c20f15864c29ada6719051e683fbf7a533aaed810aa74763f50f6810fa49e8d3773d13d18ba88a20404305fc92d3c95190e799ebaf25a82301e97422e7a8
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Jul 21, 2023
Resolves build failures under Python 3.12, i.e building on rawhide: ```bash make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. Github-Pull: bitcoin#28097 Rebased-From: 7cb88c8
Member
Author
|
Backported this to 25.x in #28047, so that we'll avoid build failures with new Python. Already an issue for anyone building the current release branch on rawhide or similar. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Sep 5, 2023
Resolves build failures under Python 3.12, i.e building on rawhide: ```bash make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. Github-Pull: bitcoin#28097 Rebased-From: 7cb88c8
fanquake
added a commit
that referenced
this pull request
Sep 5, 2023
66b2b10 depends: xcb-proto 1.15.2 (fanquake) Pull request description: Resolves build failures under Python 3.12, i.e building on rawhide: ```bash make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. Github-Pull: #28097 Rebased-From: 7cb88c8 Also being backported for 25.x in #28047. ACKs for top commit: hebasto: ACK 66b2b10 Tree-SHA512: 5364c5ced3004bc08a9c8f96e2b3abae3e31b3f0e7b1d10f83ff997f19b314d4d14c2a780ed02e793771c23091f8f02137cf7f5404627f2bd218c8726ae3228f
fanquake
added a commit
that referenced
this pull request
Sep 6, 2023
494f1af depends: xcb-proto 1.15.2 (fanquake) 513ca0a test: wallet, add coverage for watch-only raw sh script migration (furszy) 6d5a510 descriptor: InferScript, do not return top-level only func as sub descriptor (furszy) 37d9cc6 test: wallet, add coverage for addressbook migration (furszy) 4b16650 wallet: migration bugfix, persist empty labels (furszy) 59b06b6 wallet: migration bugfix, clone 'send' record label to all wallets (furszy) Pull request description: Currently backports: * #28038 * #28067 2nd & 3rd commits. * #28097 ACKs for top commit: stickies-v: ACK 494f1af Tree-SHA512: cea134cfa72950d8428191adce79c0881302ca54488f64d3d4a5f9070bb2445d8074e58fa31a482481c4eabb74c852a025f53597540fc646dc20f33b21cf0a06
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 4, 2023
Resolves build failures under Python 3.12, i.e building on rawhide: ```bash make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. Github-Pull: bitcoin#28097 Rebased-From: 7cb88c8
5 tasks
PastaPastaPasta
pushed a commit
to knst/dash
that referenced
this pull request
May 7, 2024
7cb88c8 depends: xcb-proto 1.15.2 (fanquake) Pull request description: Resolves build failures with Python 3.12, i.e building on rawhide: ```bash make -C depends -j9 ... make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. Guix Build: ```bash 6d1725c9346bdf04e1eeec2deffda90957bd081700ba896834a143756410fb0e guix-build-7cb88c8b4672/output/aarch64-linux-gnu/SHA256SUMS.part 34486c39daea8a3ce8d92e9c1501f26e5f5e300d9612a25bd56c48ab56353329 guix-build-7cb88c8b4672/output/aarch64-linux-gnu/bitcoin-7cb88c8b4672-aarch64-linux-gnu-debug.tar.gz cb0080d75d0fc4fc5c7fc022b5771470c60609c35836e7b66c4f479a2edcd098 guix-build-7cb88c8b4672/output/aarch64-linux-gnu/bitcoin-7cb88c8b4672-aarch64-linux-gnu.tar.gz 395c332f83206125819aabf9a5dad5c906bdcd78ec13269fdfb4215bb5cc3247 guix-build-7cb88c8b4672/output/arm-linux-gnueabihf/SHA256SUMS.part f9e72693dd59f1b4dce6b6efa7bf325b2b589075a904c57b430dbe5c39add4ff guix-build-7cb88c8b4672/output/arm-linux-gnueabihf/bitcoin-7cb88c8b4672-arm-linux-gnueabihf-debug.tar.gz 14cfcebcd557d30d5a07837ab38ca217346f9b97e238a96376d6467d0db39e1a guix-build-7cb88c8b4672/output/arm-linux-gnueabihf/bitcoin-7cb88c8b4672-arm-linux-gnueabihf.tar.gz 1aaa7c04156a78628060a2ec47077589fb5dfb7a2e558fe604aaaa916b8a7f51 guix-build-7cb88c8b4672/output/arm64-apple-darwin/SHA256SUMS.part 94585898babc8fdce7660c3160fe7b26c6f6749ac53a177f91a8b4226856ab7b guix-build-7cb88c8b4672/output/arm64-apple-darwin/bitcoin-7cb88c8b4672-arm64-apple-darwin-unsigned.dmg 9bcc693e5fad668e6c7beb8280c9c3e6988318569e0efa7d24f8cd990a3c1dd4 guix-build-7cb88c8b4672/output/arm64-apple-darwin/bitcoin-7cb88c8b4672-arm64-apple-darwin-unsigned.tar.gz 3e427a7c2530cc3bb2f87125997bafa94234c21ebb7004cc36dc8408c0b0c9ff guix-build-7cb88c8b4672/output/arm64-apple-darwin/bitcoin-7cb88c8b4672-arm64-apple-darwin.tar.gz 988909c91077cb83b8d5ee77933192525d1fa1fd0bba0874138433314cb64927 guix-build-7cb88c8b4672/output/dist-archive/bitcoin-7cb88c8b4672.tar.gz b13c8b1f4f75505d2356f9e702db384dbb58ee3f7f0af3b110df4b7bc4c80f52 guix-build-7cb88c8b4672/output/powerpc64-linux-gnu/SHA256SUMS.part 6f2f204401c36ee59564c8d56f9adf4f2587471ea0705e0f6a89ade4a8decf55 guix-build-7cb88c8b4672/output/powerpc64-linux-gnu/bitcoin-7cb88c8b4672-powerpc64-linux-gnu-debug.tar.gz c1af63ec54fcbfd267a047d2dca41bdfcace1ae6a5746df11bd710217b17b205 guix-build-7cb88c8b4672/output/powerpc64-linux-gnu/bitcoin-7cb88c8b4672-powerpc64-linux-gnu.tar.gz 2407bc6d0beaa12dd7601ff14ef2c077346752a7b57fdf27df0a512f2af825bd guix-build-7cb88c8b4672/output/powerpc64le-linux-gnu/SHA256SUMS.part ff033b4b2a3c2816555ee3a443e4087cba47d4eb05b00e092603892ff91acc30 guix-build-7cb88c8b4672/output/powerpc64le-linux-gnu/bitcoin-7cb88c8b4672-powerpc64le-linux-gnu-debug.tar.gz ebd9c3ab462290e2c3264dd4184a1d132b90cc93d8359ae28bc23a120b918716 guix-build-7cb88c8b4672/output/powerpc64le-linux-gnu/bitcoin-7cb88c8b4672-powerpc64le-linux-gnu.tar.gz 57afcfe859903b960ef792447d34a17d556e44c98c021f5a35bfbd963f9e7be5 guix-build-7cb88c8b4672/output/riscv64-linux-gnu/SHA256SUMS.part 105e6ef4fbac91e1bbbea3e98c80915654894d247cbfe0e4d2ff89b633ace10e guix-build-7cb88c8b4672/output/riscv64-linux-gnu/bitcoin-7cb88c8b4672-riscv64-linux-gnu-debug.tar.gz e893e321ddd966c29fa949c3d7866fd0dca6ea87f9185e702a17c62896acf90b guix-build-7cb88c8b4672/output/riscv64-linux-gnu/bitcoin-7cb88c8b4672-riscv64-linux-gnu.tar.gz 80e7610cdb2ea9f1a503fa7c9ac7e29600e98fdac020951a76525494822416d9 guix-build-7cb88c8b4672/output/x86_64-apple-darwin/SHA256SUMS.part 8fe050ca40af1d2830f7efe928f8ea8e30800dfa286f5d22549255d7ed893a30 guix-build-7cb88c8b4672/output/x86_64-apple-darwin/bitcoin-7cb88c8b4672-x86_64-apple-darwin-unsigned.dmg 51a06c78edb9b29008deab11f5e98acac04de64080804d22b5a4f30c4b195ee5 guix-build-7cb88c8b4672/output/x86_64-apple-darwin/bitcoin-7cb88c8b4672-x86_64-apple-darwin-unsigned.tar.gz 5cb44b69b2315fd2bb4122fa252158a9460269f24121226d88f6146e52aafc5b guix-build-7cb88c8b4672/output/x86_64-apple-darwin/bitcoin-7cb88c8b4672-x86_64-apple-darwin.tar.gz d57f8ad1041a8112b012472ff00593a214f55215a29c5e5c3bc724d5eb645b1e guix-build-7cb88c8b4672/output/x86_64-linux-gnu/SHA256SUMS.part 76f1865d49cedf4b03f9ac5c4cb968968e54f8b19e96391340d82669a9395e93 guix-build-7cb88c8b4672/output/x86_64-linux-gnu/bitcoin-7cb88c8b4672-x86_64-linux-gnu-debug.tar.gz 63cca6f0cbfd74148b20093bc2494b9abf50594cfb7055c5b5d702583d6c37a4 guix-build-7cb88c8b4672/output/x86_64-linux-gnu/bitcoin-7cb88c8b4672-x86_64-linux-gnu.tar.gz 8d2afd4156525bc4684271092b5017e12f01fcc3dad29608886d10c0ef01b09d guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/SHA256SUMS.part 6ebb038dc1f589bf92bcf3766dfcb0310f7df9ff4f75c943c2eb6fcced1a2580 guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64-debug.zip d73aad8495174a49dad172278fbe590b86104bca9fcec8301a548a9fc8b1118f guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64-setup-unsigned.exe 7697fffdb9b2c2f0c6042f56daf9940c561ed4c950692a2adbb039ecd885e047 guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64-unsigned.tar.gz 4483876d0e5709b25bd2e238958a820f7996eaebe21c1c3f3a8c3f490a0c8562 guix-build-7cb88c8b4672/output/x86_64-w64-mingw32/bitcoin-7cb88c8b4672-win64.zip ``` ACKs for top commit: hebasto: ACK 7cb88c8, tested on Ubuntu Mantic with: Tree-SHA512: 7e01c20f15864c29ada6719051e683fbf7a533aaed810aa74763f50f6810fa49e8d3773d13d18ba88a20404305fc92d3c95190e799ebaf25a82301e97422e7a8
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
May 7, 2024
… - fix ubuntu 24.04 94a8e1a Merge bitcoin#28097: depends: xcb-proto 1.15.2 (fanquake) Pull request description: ## Issue being fixed or feature implemented Resolves build failures with Python 3.12, i.e building on rawhide: ```bash make -C depends -j9 ... make[3]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' /usr/bin/install -c -m 644 __init__.py error.py expr.py align.py matcher.py state.py xtypes.py '/bitcoin/depends/work/staging/aarch64-unknown-linux-gnu/xcb_proto/1.14.1-4a91ac9dc41/bitcoin/depends/aarch64-unknown-linux-gnu/lib/python3.12/site-packages/xcbgen' Traceback (most recent call last): File "<string>", line 2, in <module> ModuleNotFoundError: No module named 'imp' make[3]: *** [Makefile:271: install-pkgpythonPYTHON] Error 1 ``` `imp` was removed in 3.12: https://docs.python.org/3/library/imp.html. ## What was done? Bitcoin backport bitcoin#28097 ## How Has This Been Tested? Run build `depends` with clean - it doesn't fail ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone Top commit has no ACKs. Tree-SHA512: 61415fcc0c86f57d6b124907505102ae5b319c95d6ee0b531ce75fa2370a82bafd7a40b21e24eb7d1ac38ba93d59d9e7b89829667c61f4f4caf46029e6dd1cf7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves build failures with Python 3.12, i.e building on rawhide:
impwas removed in 3.12: https://docs.python.org/3/library/imp.html.Guix Build: