Skip to content

Conversation

@brunoerg
Copy link
Contributor

Fixes #27980

Using ConnmanTestMsg we can add nodes and be
more effective fuzzing functions like DisconnectNode,
FindNode, GetNodeStats and other ones.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 17, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Jul 17, 2023
@maflcko
Copy link
Member

maflcko commented Jul 17, 2023

lgtm ACK d9bd559638b453b8c6e03e34005ad5c52099b6bf

Using `ConnmanTestMsg` we can add nodes and be
more effective fuzzing functions like `DisconnectNode`,
`FindNode`, `GetNodeStats` and other ones.
@brunoerg brunoerg force-pushed the 2023-07-connman-mnodes branch from d9bd559 to ecfe507 Compare July 22, 2023 16:43
@maflcko
Copy link
Member

maflcko commented Jul 28, 2023

review ACK ecfe507

Didn't test anything nor compile

@brunoerg
Copy link
Contributor Author

friendly ping: @dergoegge

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ecfe507

@fanquake fanquake merged commit 44b05bf into bitcoin:master Jul 31, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 9, 2023
ecfe507 fuzz: use `ConnmanTestMsg` in `connman` (brunoerg)

Pull request description:

  Fixes bitcoin#27980

  Using `ConnmanTestMsg` we can add nodes and be
  more effective fuzzing functions like `DisconnectNode`,
  `FindNode`, `GetNodeStats` and other ones.

ACKs for top commit:
  MarcoFalke:
    review ACK ecfe507
  dergoegge:
    utACK ecfe507

Tree-SHA512: 97c363b422809f2e9755c082d1102237347abfab72c7baca417bd8975f8a595ddf3a085f8353dbdb9f17fb98fbfe830792bfc0b83451168458018faf6c239efa
@bitcoin bitcoin locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fuzz: connman, m_nodes is always empty

5 participants