Skip to content

ci: Remove deprecated container.greedy #28024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Jul 4, 2023
Merged

ci: Remove deprecated container.greedy #28024

fanquake merged 1 commit into from
Jul 4, 2023

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 3, 2023 •
edited
Loading

The option is to be phased out, so remove it to avoid relying on it. Update container.cpu where needed.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 3, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto
Stale ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

@DrahtBot DrahtBot added the Tests label Jul 3, 2023
@hebasto
Copy link
Member

hebasto commented Jul 3, 2023

The option is to be phased out,

It is still mentioned in https://cirrus-ci.org/guide/linux/#linux-containers.

fanquake
fanquake approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa248a4c616be31d231c671e8feb0dbb46ac54cd

@maflcko
Copy link
Member Author

maflcko commented Jul 3, 2023

It is still mentioned

I asked by email.

@maflcko
Copy link
Member Author

maflcko commented Jul 3, 2023

Added an unrelated commit to adjust the CCACHE_SIZE. For some reason the jammy macOS taks is uncacheable? https://cirrus-ci.com/task/4744875699077120?logs=ci#L2486

@hebasto
Copy link
Member

hebasto commented Jul 3, 2023

For some reason the jammy macOS taks is uncacheable? cirrus-ci.com/task/4744875699077120?logs=ci#L2486

See:

@DrahtBot DrahtBot removed the CI failed label Jul 3, 2023
@DrahtBot DrahtBot mentioned this pull request Jul 4, 2023
Closed
ci: Remove deprecated container.greedy
fac14c4 
The option is to be phased out, so remove it to avoid relying on it.
Update container.cpu and timeouts where needed.
@maflcko maflcko force-pushed the 2307-ci-container-update- branch 2 times, most recently from fa5dfda to fac14c4 Compare July 4, 2023 11:13
@maflcko
Copy link
Member Author

maflcko commented Jul 4, 2023

Dropped the CCACHE_SIZE stuff and restored the initial change

hebasto
hebasto approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fac14c4.

Mentioning "timeouts" in the commit message looks unrelated.

@DrahtBot DrahtBot requested a review from fanquake July 4, 2023 16:01
@fanquake fanquake merged commit bc4f6b1 into bitcoin:master Jul 4, 2023
@maflcko maflcko deleted the 2307-ci-container-update- branch July 4, 2023 17:52
@hebasto hebasto mentioned this pull request Aug 16, 2023
Closed
@bitcoin bitcoin locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

@fanquake fanquake Awaiting requested review from fanquake

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maflcko @DrahtBot @hebasto @fanquake