move SelectParamsFromCommandLine() to bitcoin.cpp #2788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move SelectParamsFromCommandLine() from init.cpp to bitcoin.cpp to allow
to use TestNet() for Bitcoin-Qt instead of GetBoolArg("-testnet", false)
Diapolo
referenced
this pull request
Jun 23, 2013
Refactor chain-specific tweaks into a CChainParams class and introduce a regtest mode
Member
|
This won't work. Bitcoind wouldn't ever call SelectParamsFromCommandLine() anymore? |
Member
|
@Diapolo Ah, that's for the RPC client, not for bitcoind's normal functions. |
Author
|
@sipa Could we then place that call ( |
Member
|
No, not before ReadConfigFile. |
Author
|
Doesn't yet do, what it should ;) -> closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to use TestNet() for Bitcoin-Qt instead of GetBoolArg("-testnet", false)
Does this still work for bitcoind, whose check resides in bitcoind.cpp AFAIK?