ci: label docker images and prune dangling images selectively #27793
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
|
Concept ACK. Haven't tested. It would also be nice to have an incantation (e.g. in the help) to kill dangling images after CI failure / interruption (if you don't plan on running it again). |
stickies-v
force-pushed
the
ci-label-images
branch
from
1626211 to
f9b5fe4
Compare
|
Rebased to address merge conflict from #27844.
Thanks, added doc: ci: add instructions for pruning dangling images manually |
|
Concept ACK |
stickies-v
force-pushed
the
ci-label-images
branch
from
f9b5fe4 to
c47c50f
Compare
|
Rebased to address merge conflict from #28138. |
stickies-v
force-pushed
the
ci-label-images
branch
from
c47c50f to
44b36af
Compare
|
Rebased to address merge conflict from #28161. |
|
Concept ACK. |
stickies-v
force-pushed
the
ci-label-images
branch
from
44b36af to
0fe9b99
Compare
|
Force pushed to update documentation addressing this review comment. |
stickies-v
force-pushed
the
ci-label-images
branch
2 times, most recently
from
234b61b to
8c0faec
Compare
|
Could rebase for green CI, if still relevant? |
stickies-v
force-pushed
the
ci-label-images
branch
from
8c0faec to
464873b
Compare
stickies-v
force-pushed
the
ci-label-images
branch
from
464873b to
be99d4d
Compare
|
Rebased to address merge conflict from #27976. |
pablomartin4btc
left a comment
pablomartin4btc
left a comment
There was a problem hiding this comment.
Concept ACK.
Perhaps description needs to be updated regarding the user instructions (ci/README.md).
Thanks, reverted that description. |
|
Closed, not an essential change and doesn't seem like there's sufficient interest. |
This allows us or the user to perform batch operations on all images produced by the ci, e.g. to prune all dangling images, without affecting non-ci images.
Since all bitcoin-ci-test images are now labeled, we can always prune all dangling images, regardless of whether we are in RESTART_CI_DOCKER_BEFORE_RUN. To be safe, still prune all images if RESTART_CI_DOCKER_BEFORE_RUN in case the filtering doesn't work, or if images were created on an earlier version that did not assign labels.
stickies-v
force-pushed
the
ci-label-images
branch
from
be99d4d to
e44c574
Compare
|
Force-pushed to address merge conflict from #28547 and incorporate suggestion from maflcko to keep the unfiltered pruning for now, as belt and suspenders approach. |
…s selectively e44c574 ci: always prune all dangling bitcoin-ci-test images (stickies-v) ce16997 ci: add label to docker images (stickies-v) Pull request description: Follow-up from bitcoin#27777 (comment). Labeling the docker images produced by the CI allows us/the user to apply batch operations to all images (including dangling ones) produced by the ci without affecting other, non-bitcoin-ci images. With labeling, we can safely always prune dangling bitcoin-ci-test images without checking for `RESTART_CI_DOCKER_BEFORE_RUN`, which we enable on our persistent runners. ACKs for top commit: fanquake: utACK e44c574 Tree-SHA512: 1009fb1be78fbc80b5341ba92eac2991e77d050e1ab6048d1d9a65af73413a6be7afc1e1c764eb3f347f363af31245b93fdb38f6ac016d775aad4a0f36e4c98f
7 participants
Follow-up from #27777 (comment).
Labeling the docker images produced by the CI allows us/the user to apply batch operations to all images (including dangling ones) produced by the ci without affecting other, non-bitcoin-ci images. With labeling, we can safely always prune dangling bitcoin-ci-test images without checking for
RESTART_CI_DOCKER_BEFORE_RUN, which we enable on our persistent runners.