Skip to content

rpc: remove deprecated "warning" field from {create,load,restore,unload}wallet #27757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
achow101 merged 3 commits into from
Jun 16, 2023
Merged

rpc: remove deprecated "warning" field from {create,load,restore,unload}wallet #27757

achow101 merged 3 commits into from
Jun 16, 2023

Conversation

@theStack
Copy link
Contributor

@theStack theStack commented May 25, 2023

The "warning" string field for wallet creating/loading RPCs (createwallet, loadwallet, unloadwallet and restorewallet) has been deprecated with the configuration option -deprecatedrpc=walletwarningfield in PR #27279 (released in v25.0). For the next release v26.0, the field and the configuration option can be removed.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 25, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK jonatack, achow101
Stale ACK kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #27322 (Move IsDeprecatedRPCEnabled to rpc/util, rm redundant rpcEnableDeprecated by jonatack)
  • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@theStack theStack force-pushed the 202305-deprecate_walletwarningfield branch 2 times, most recently from 8d76484 to 262e8d1 Compare May 25, 2023 15:00
@theStack theStack force-pushed the 202305-deprecate_walletwarningfield branch from 262e8d1 to d78f9a7 Compare May 25, 2023 15:18
This was referenced May 25, 2023
Closed
Closed
@kevkevinpal
Copy link
Contributor

kevkevinpal commented May 26, 2023

ACK d78f9a7

compiled and ran the code below and got the following response

--> ./src/bitcoin-cli -regtest -named createwallet wallet_name=oops2 descriptors=false passphrase=""
{
  "name": "oops2",
  "warnings": [
    "Empty string given as passphrase, wallet will not be encrypted.",
    "Wallet created successfully. The legacy wallet type is being deprecated and support for creating and opening legacy wallets will be removed in the future."
  ]
}

jonatack
jonatack reviewed May 31, 2023
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK. Did this a few weeks back in master...jonatack:bitcoin:2023-05-remove-deprecated-warning-fields and the diff is the same except as where noted below. Feel free to pull in 39f1496 in that branch if you think it's worthwhile.

@theStack theStack force-pushed the 202305-deprecate_walletwarningfield branch from d78f9a7 to 11cd828 Compare June 2, 2023 10:26
@theStack
Copy link
Contributor Author

theStack commented Jun 2, 2023

@jonatack: Oh sorry, wasn't aware you already put time into this. Pulled in your documentation fixup commit and took also your other suggestions for the removal and release note commits.

@theStack theStack force-pushed the 202305-deprecate_walletwarningfield branch from 11cd828 to 5524fa0 Compare June 4, 2023 21:53
jonatack
jonatack approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theStack Oh, you couldn't know. Thanks for updating!

ACK 5524fa0

@fanquake fanquake requested a review from achow101 June 16, 2023 08:22
@achow101
Copy link
Member

achow101 commented Jun 16, 2023

ACK 5524fa0

@DrahtBot DrahtBot removed the request for review from achow101 June 16, 2023 19:05
@achow101 achow101 merged commit f0758d8 into bitcoin:master Jun 16, 2023
@theStack theStack deleted the 202305-deprecate_walletwarningfield branch June 16, 2023 19:32
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 19, 2023
@achow101
Merge bitcoin#27757: rpc: remove deprecated "warning" field from {cre…
89506d8 
…ate,load,restore,unload}wallet

5524fa0 doc: add release note about removal of `deprecatedrpc=walletwarningfield` flag (Sebastian Falbesoner)
5c77db7 Restorewallet/createwallet help documentation fixups/improvements (Jon Atack)
a00ae31 rpc: remove deprecated "warning" field from {create,load,restore,unload}wallet (Sebastian Falbesoner)

Pull request description:

  The "warning" string field for wallet creating/loading RPCs (`createwallet`, `loadwallet`, `unloadwallet` and `restorewallet`) has been deprecated with the configuration option `-deprecatedrpc=walletwarningfield` in PR bitcoin#27279 (released in v25.0). For the next release v26.0, the field and the configuration option can be removed.

ACKs for top commit:
  achow101:
    ACK 5524fa0
  jonatack:
    ACK 5524fa0

Tree-SHA512: 8212f72067d08095304018b8a95d2ebef630004b65123483fbbfb078cc5709c2d825bbc35b16ea5f6b28ae7377347382d7e9afaf7bdbf0575d2c229d970784de
@bitcoin bitcoin locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonatack jonatack jonatack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

RPC/REST/ZMQ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theStack @DrahtBot @kevkevinpal @achow101 @jonatack