build: Bump minimum supported Clang to clang-10 #27682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer applicable after CONFIG_SHELL must be explicitly set to dash after commit fafc55a.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
DrahtBot
changed the title
maflcko
changed the title
Member
Concept ACK. |
hebasto
reviewed
May 17, 2023
Member
|
Just noting that our current Guix environment uses Clang 10.0.1. |
added 2 commits
May 17, 2023 10:30
This partially reverts commit 71383f2. This should be fine, because if warnings are issues again in the future, it can be disabled again, along with a list of the false warnings.
hebasto
approved these changes
May 17, 2023
Member
|
Guix builds: |
Member
Author
|
For completeness, building with clang-9 is likely still possible, it is just not supported and checked by the CI. |
Member
|
Guix Build: 87a9f57e4436db8aa1f892cd7a5bfacaade632d518cf99f3f036ea59936b01a6 guix-build-fa199ee614a7/output/aarch64-linux-gnu/SHA256SUMS.part
7f2cb983eb4433db2e7e8acaa014069b978e999330a2850846ecff66e5276c30 guix-build-fa199ee614a7/output/aarch64-linux-gnu/bitcoin-fa199ee614a7-aarch64-linux-gnu-debug.tar.gz
ba5144a64d5f70adf26b072c966925c79a56d4501389478d2a240daacd523a96 guix-build-fa199ee614a7/output/aarch64-linux-gnu/bitcoin-fa199ee614a7-aarch64-linux-gnu.tar.gz
00d8f4b7904f6e712c2a319ef77ab33770703347d7b8901d28ef644fead73887 guix-build-fa199ee614a7/output/arm-linux-gnueabihf/SHA256SUMS.part
25ebac3e9418c6d742e444695342b7d68ca6fd01558a38d4d7812c6fe52a0bbd guix-build-fa199ee614a7/output/arm-linux-gnueabihf/bitcoin-fa199ee614a7-arm-linux-gnueabihf-debug.tar.gz
24443acc11a13958566e7d272b98d00c9894364005462e40b2d6e95908ab8b0b guix-build-fa199ee614a7/output/arm-linux-gnueabihf/bitcoin-fa199ee614a7-arm-linux-gnueabihf.tar.gz
4837adede6c57a98c0bc0ddaa178870a543c3f6ce9c3c8cd47841262937637c7 guix-build-fa199ee614a7/output/arm64-apple-darwin/SHA256SUMS.part
7ff35a219b09300f27a03b00196367ae9f17effab610e440a60322b0dd6a22e8 guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin-unsigned.dmg
4dcf0408d81b0558f30055749334b966b8b1d2269da32238ff1f219e3e027bfc guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin-unsigned.tar.gz
169fea2e7e671692b611e555e00f1c282efb862b3abc080df50897251f188a8b guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin.tar.gz
56ce8a8945ab2b1f1cebec4c07eb2cd62e8292b97d8240ed15dded1490e196fd guix-build-fa199ee614a7/output/dist-archive/bitcoin-fa199ee614a7.tar.gz
d1c1452c9fd368a9f1b974b9539e468b16ebe8cf2e5d3a58c8f704092ff365b7 guix-build-fa199ee614a7/output/powerpc64-linux-gnu/SHA256SUMS.part
06aecc75730870954fd5e12454f86c1e70eb7456fca7472e2cf80eefc11c4c01 guix-build-fa199ee614a7/output/powerpc64-linux-gnu/bitcoin-fa199ee614a7-powerpc64-linux-gnu-debug.tar.gz
724d581d4f27912bbcb0d61837f822292ec53e4cea1978243bd08e54a33f577c guix-build-fa199ee614a7/output/powerpc64-linux-gnu/bitcoin-fa199ee614a7-powerpc64-linux-gnu.tar.gz
f399d55f7e158432530d6c89e39d40db1e937ef823c3dcb36ef77e9a62534f76 guix-build-fa199ee614a7/output/powerpc64le-linux-gnu/SHA256SUMS.part
6fd9fac36a2c7cb88ef1fd40cd3d3961e1de97f18142244216a3092928fd29a6 guix-build-fa199ee614a7/output/powerpc64le-linux-gnu/bitcoin-fa199ee614a7-powerpc64le-linux-gnu-debug.tar.gz
6a89449b213935baf61fc02ba56f74ad9748ab945d9cd8d6cf3a507869c0532d guix-build-fa199ee614a7/output/powerpc64le-linux-gnu/bitcoin-fa199ee614a7-powerpc64le-linux-gnu.tar.gz
a735905eff1b310bbd12ec4348d609f56d86ce92cef23e5bc67f97517dba7e43 guix-build-fa199ee614a7/output/riscv64-linux-gnu/SHA256SUMS.part
242740d4222b8808c379d38cb657011b696e0c71690e16880a23418df4458192 guix-build-fa199ee614a7/output/riscv64-linux-gnu/bitcoin-fa199ee614a7-riscv64-linux-gnu-debug.tar.gz
fd44487f5f1d5d08c61eeba727c75b21397dc90f96ac883933a2dfa2a96fa271 guix-build-fa199ee614a7/output/riscv64-linux-gnu/bitcoin-fa199ee614a7-riscv64-linux-gnu.tar.gz
6765669d7170f6490b644fc278dd2ff92fd19d6dba21d7e68cf68c6a5ce3f13c guix-build-fa199ee614a7/output/x86_64-apple-darwin/SHA256SUMS.part
fffe1dbf1736d23fe03c5fe1351ead10be1ed509871779bd185c655e87d17225 guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin-unsigned.dmg
0f20ad10bbfc1c68e352682f7ae9ba8105a7f27c72f066158fd63a085c007541 guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin-unsigned.tar.gz
20b4e3fd43b878722f390ebd394fcee6a320630c9d73d67565231ba6536e55aa guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin.tar.gz
ffa43154cc7a04a1de47b7dd048b3a0f81bf4b80d6aec9cf0c34a2fbace1ba41 guix-build-fa199ee614a7/output/x86_64-linux-gnu/SHA256SUMS.part
0c022395d14342c5c47af6159d012ec893a563507ff982b027f5795a618c7b1e guix-build-fa199ee614a7/output/x86_64-linux-gnu/bitcoin-fa199ee614a7-x86_64-linux-gnu-debug.tar.gz
d53c0a1892365a76138a4b4de2669ab45aa7a39cabc9f7948f97f9c9c375e09d guix-build-fa199ee614a7/output/x86_64-linux-gnu/bitcoin-fa199ee614a7-x86_64-linux-gnu.tar.gz
295f21754d327d02de041e3c40ccc489b7eb9e3082169707c6877d083224f773 guix-build-fa199ee614a7/output/x86_64-w64-mingw32/SHA256SUMS.part
c05dd128aca5e2845670ce412432704a44bf4fb61023df3d8d9079c7c91a9eab guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64-debug.zip
6bffc1901af5ae0623c586392d221be62a177cbddcf6adca4f4f73a44581ee16 guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64-setup-unsigned.exe
58623eb17277782e952defb013a0ae7090b2db6c00b6d43d37d4c6d3fae53fe9 guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64-unsigned.tar.gz
d7e8f973e9a6282c59545e1f52d92c758da57e16d1ef531d43754bc99932f671 guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64.zip |
fanquake
approved these changes
May 17, 2023
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to support a minimum clang version that is difficult to install on all supported operating systems, which generally ship a later version:
Also, it allows to drop build code, which means it won't waste review when rolling over into cmake (
cmake/module/CheckStdFilesystem.cmake).